This is an archive of the discontinued LLVM Phabricator instance.

[NFCI][CostModel] Unify ExtractElement cost.
ClosedPublic

Authored by samparker on Jun 11 2020, 3:31 AM.

Details

Summary

Move the cost modelling, with the reduction pattern matching, from getInstructionThroughput into generic TTIImpl::getUserCost. The modelling in the AMDGPU backend can now be removed.

Diff Detail

Event Timeline

samparker created this revision.Jun 11 2020, 3:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2020, 3:31 AM
dfukalov accepted this revision.Jun 13 2020, 4:02 AM
dfukalov added inline comments.
llvm/lib/Analysis/TargetTransformInfo.cpp
1290

It seems this (and the same 3 lines before) may be removed?

This revision is now accepted and ready to land.Jun 13 2020, 4:02 AM
This revision was automatically updated to reflect the committed changes.

Hi!

I wrote
https://bugs.llvm.org/show_bug.cgi?id=46430
about a crash that started happening with this patch.