Page MenuHomePhabricator

[DebugInfo] Fix printing of unrecognised standard opcodes
ClosedPublic

Authored by jhenderson on Jun 4 2020, 7:48 AM.

Details

Summary

The verbose printing of unrecognised standard opcodes was broken in multiple ways (additional blank lines, a closing parenthesis without opening parenthesis and so on). This patch fixes it, and makes the output more consistent with other opcodes.

Depends on D81102 (it might be possible to avoid the dependency by splitting off some of the test changes from D81102, but I haven't done that for convenience).

Diff Detail

Event Timeline

jhenderson created this revision.Jun 4 2020, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2020, 7:48 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
MaskRay accepted this revision.Jun 4 2020, 12:07 PM

LGTM.

llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
1064

No need to use format. ')'

This revision is now accepted and ready to land.Jun 4 2020, 12:07 PM
jhenderson closed this revision.Jun 9 2020, 6:38 AM

Oops, forgot to add the tags to my commit before pushing. This patch landed as rG3b7ec64d59748765990ed99716034ab8d5533673.