Implemented in replaceZeroVectorStore(). Fixes several warnings in AArch64 SVE unit tests.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
After D80720 this function will no longer be called from splitStores for scalable vectors, but it still makes sense to bail out early in case that ever changes.
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
12071–12075 | Probably better to bail out directly if VT is scalable and leave the call to getVectorNumElements() intact. |
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
12071–12075 | Thanks for the review. I reverted the change to use getVectorNumElements(), and added a check above. |
Comment Actions
LGTM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
12073 | I think you can remove the condition || !VT.isFixedLengthVector(), because this function would otherwise break if it isn't. |
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
12073 | Fixed, thanks for feedback. |