User Details
- User Since
- Oct 17 2019, 7:31 AM (205 w, 5 d)
Jul 27 2021
May 12 2021
May 7 2021
@paulwalker-arm @sdesmalen I will be picking up this work, I will study this patch and see if I have any questions. Thanks!
Apr 15 2021
Updated last comments.
Apr 6 2021
@dmgreen I fixed the issues that you pointed out. This patch prevents the test case from getting stuck on the exponential explosion of the algorithm. Could you review it? Thanks!
Fixed formatting and add test run line
Feb 25 2021
@dmgreen I think so. The code is indeed exponential. Adding this check will avoid the exponential case, but we will be visiting each instruction both ways, we just avoid visiting repeated ones. IMO it won't affect the analysis result.
Feb 24 2021
Jan 26 2021
@dmgreen @fhahn Sorry about that, the test case I posted was incorrect. I updated the test.c file, and in the process of finding the correct test case for you to be able to reproduce I found out the bug is worse than I expected.
Jan 20 2021
Are there any opinions on this bugfix?
Jan 19 2021
Dec 17 2020
Sep 30 2020
Sep 22 2020
Sep 15 2020
Sep 4 2020
Sep 2 2020
Aug 26 2020
Jul 13 2020
Jul 2 2020
Jun 9 2020
Jun 3 2020
May 29 2020
@efriedma Thanks Eli, I will close it, as that other patch already fixed that issue.
May 28 2020
Hello David, I have this patch here that I was going to upstream (https://reviews.llvm.org/D80746), but I just realized that it is exactly the same as this one.
Mar 5 2020
Feb 27 2020
Feb 26 2020
Feb 21 2020
Latest commit adds a change to the failing MC tests to be exactly the same as the MC tests for eor3 and bcax.
Will look into that and update this review with the necessary changes.
Feb 20 2020
Feb 19 2020
Merging all instructions into same multiclass.
Feb 18 2020
Feb 12 2020
Feb 10 2020
Jan 31 2020
Add missing i16 tests.
Jan 30 2020
Jan 29 2020
@sdesmalen Hopefully all comments from D73576 were addressed with this patch.
I will make the changes suggested by Sander in a following patch, joined with the saturating multiply-add long intirnsics.
Jan 28 2020
Jan 23 2020
Jan 22 2020
Remove _m from intrinsics, as it is the default behaviour. Also, add unpredicated patterns for SVE2 smulh, umulh.
Jan 20 2020
I'm not sure on some parts, but I have prepared a major update for this patch that I hope will fix most of @sdesmalen concerns.
Jan 16 2020
Tentative changes to address some comments from the reviewers.
I'm not sure on some parts, but I have prepared a major update for this patch that I hope will fix most of @sdesmalen concerns.
Jan 15 2020
Jan 14 2020
Fix whitespace errors and add a couple negative tests for invalid input.