Page MenuHomePhabricator

andwar (DO NOT USE)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2019, 10:50 AM (54 w, 2 d)

Recent Activity

Thu, Sep 17

andwar updated andwar.
Thu, Sep 17, 1:17 AM

Wed, Aug 26

andwar updated the diff for D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
  • Canonicalised FLANG_BUILD_NEW_DRIVER in flang/test/CMakeLists.txt and updated the LIT config scripts accordingly
  • Implemented proper handling of -emit-obj (via diagnostics) in CompilerInvocation.cpp
  • Removed members from InputKind which are not needed (and the related methods)
  • Removed/updated comments, added new comments to clarify the design and to highlight the future steps
  • Simplified the original change in OptTable::PrintHelp (made it more generic)
  • Removed unused #includes
  • Fine-tuned the tests (I wanted to make sure that they clearly communicate what is currently supported and what is not)
  • Addressed all the outstanding comments
Wed, Aug 26, 9:55 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2020

andwar updated the diff for D85078: [flang] Fix multi-config generator builds.
  • Fixed the LIT config - originally config.flang_standalone_build was a string

(either "ON" or "OFF"), but the canonical LLVM way is to use
llvm_canonicalize_cmake_booleans so that the corresponding LIT variable becomes
numeric 0 or 1

  • Added David's original commit message and attributed the patch to him (I'm not

sure whether that will be visible in Phab)

Aug 4 2020, 4:37 AM · Restricted Project

Aug 1 2020

andwar requested review of D85078: [flang] Fix multi-config generator builds.
Aug 1 2020, 1:05 PM · Restricted Project

Jul 3 2020

andwar committed rGef875c228ae7: [clang][NFC] Removed unused parameters in InitializeSourceManager (authored by andwar).
[clang][NFC] Removed unused parameters in InitializeSourceManager
Jul 3 2020, 8:34 AM

Apr 22 2020

andwar committed rG72f565899dd4: [SveEmitter] Implement builtins for gathers/scatters (authored by andwar).
[SveEmitter] Implement builtins for gathers/scatters
Apr 22 2020, 5:55 AM
andwar closed D77735: [SveEmitter] Implement builtins for gathers/scatters.
Apr 22 2020, 5:55 AM · Restricted Project
andwar added a comment to D77735: [SveEmitter] Implement builtins for gathers/scatters.

The buildbot failures are unrelated to this patch, and locally make check-all worked fine. I'll submit this patch as is.

Apr 22 2020, 5:22 AM · Restricted Project

Apr 21 2020

andwar added inline comments to D77735: [SveEmitter] Implement builtins for gathers/scatters.
Apr 21 2020, 3:44 AM · Restricted Project
andwar updated the diff for D77735: [SveEmitter] Implement builtins for gathers/scatters.

Thank you both for reviewing!

Apr 21 2020, 3:44 AM · Restricted Project

Apr 14 2020

andwar committed rG8fc7e6dcd837: [AArch64][SVE] Refine node definitions for ff & nf loads/stores (NFC) (authored by andwar).
[AArch64][SVE] Refine node definitions for ff & nf loads/stores (NFC)
Apr 14 2020, 10:45 AM
andwar closed D77724: [AArch64][SVE] Refine node definitions for ff & nf loads/stores (NFC).
Apr 14 2020, 10:44 AM · Restricted Project
andwar accepted D77839: [llvm][CodeGen] Rename SVE gather prefetch intrinsics. [NFC].

LGTM, thanks for the improvements!

Apr 14 2020, 10:10 AM · Restricted Project

Apr 8 2020

andwar added reviewers for D77735: [SveEmitter] Implement builtins for gathers/scatters: sdesmalen, SjoerdMeijer.
Apr 8 2020, 9:12 AM · Restricted Project
andwar created D77735: [SveEmitter] Implement builtins for gathers/scatters.
Apr 8 2020, 8:39 AM · Restricted Project
andwar created D77724: [AArch64][SVE] Refine node definitions for ff & nf loads/stores (NFC).
Apr 8 2020, 5:55 AM · Restricted Project

Apr 6 2020

andwar added a comment to D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags.

This patch now implements a bit more than the original commit message would suggest. Could you please update? Thanks for working on this!

Apr 6 2020, 4:17 AM · Restricted Project
andwar added inline comments to D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags.
Apr 6 2020, 3:45 AM · Restricted Project

Apr 3 2020

andwar added a comment to D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ.

Btw, could you also add some negative tests? (e.g. out-of-range immediate)

Apr 3 2020, 5:20 AM · Restricted Project

Apr 2 2020

andwar added a comment to D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ.

Cheers for working on this @kmclaughlin !

Apr 2 2020, 4:18 AM · Restricted Project

Mar 24 2020

andwar added a comment to D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags.

Cheers for the fix @sdesmalen !

Mar 24 2020, 3:12 AM · Restricted Project

Mar 23 2020

andwar added a comment to D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations.

Thanks for the updates @kmclaughlin ! Would you mind adding a comment to clearly mark the negative tests? E.g. for @reinterpret_reductions_1? Maybe also a comment why a particular case is not optimised? You've already done that for some tests, but not all of them.

Mar 23 2020, 4:53 AM · Restricted Project

Mar 20 2020

andwar added a comment to D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations.

Have you considered adding an interface for the new PM?

Mar 20 2020, 5:23 AM · Restricted Project

Mar 19 2020

andwar committed rG0ea4fb5bb77b: [AArch64][SVE] Rename intrinsics for gather prefetch [NFC] (authored by andwar).
[AArch64][SVE] Rename intrinsics for gather prefetch [NFC]
Mar 19 2020, 5:55 AM
andwar closed D76421: [AArch64][SVE] Rename intrinsics for gather prefetch [NFC].
Mar 19 2020, 5:55 AM · Restricted Project
andwar created D76421: [AArch64][SVE] Rename intrinsics for gather prefetch [NFC].
Mar 19 2020, 3:11 AM · Restricted Project

Mar 18 2020

andwar accepted D76209: [llvm][SVE] Addressing mode for FF/NF loads..

LGTM

Mar 18 2020, 5:56 AM · Restricted Project
andwar added a comment to D76209: [llvm][SVE] Addressing mode for FF/NF loads..

Cheers for working on this, LGTM!

Mar 18 2020, 3:13 AM · Restricted Project

Mar 17 2020

andwar added inline comments to D76209: [llvm][SVE] Addressing mode for FF/NF loads..
Mar 17 2020, 6:52 AM · Restricted Project

Mar 16 2020

andwar added a comment to D76237: [AArch64][SVE] Change pointer type of nontemporal load/store intrinsics.

LGTM

Mar 16 2020, 12:34 PM · Restricted Project
andwar added a comment to D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations.

Cheers for working on this @kmclaughlin ! Have you considered adding an interface for the new PM? You could check this for reference: https://reviews.llvm.org/rGd6de5f12d485a85504bc99d384a85634574a27e2 (also implements a FunctionPass).

Mar 16 2020, 12:34 PM · Restricted Project
andwar added a comment to D75580: [llvm][CodeGen][SVE] Implement IR intrinsics for gather prefetch..

LGTM

Mar 16 2020, 10:20 AM · Restricted Project
andwar added inline comments to D76209: [llvm][SVE] Addressing mode for FF/NF loads..
Mar 16 2020, 10:20 AM · Restricted Project

Mar 13 2020

andwar committed rGa0c15ed46056: [AArch64][SVE] Add the @llvm.aarch64.sve.dup.x intrinsic (authored by andwar).
[AArch64][SVE] Add the @llvm.aarch64.sve.dup.x intrinsic
Mar 13 2020, 5:47 AM
andwar closed D75900: [AArch64][SVE] Add the @llvm.aarch64.sve.dup.unpred intrinsic.
Mar 13 2020, 5:46 AM · Restricted Project
andwar added a comment to D75580: [llvm][CodeGen][SVE] Implement IR intrinsics for gather prefetch..

Thanks you for addressing my comments @fpetrogalli !

Mar 13 2020, 4:24 AM · Restricted Project

Mar 12 2020

andwar committed rG46b9f14d712d: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers (authored by andwar).
[AArch64][SVE] Add intrinsics for non-temporal scatters/gathers
Mar 12 2020, 7:03 AM
andwar closed D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.
Mar 12 2020, 7:03 AM · Restricted Project
andwar updated the diff for D75900: [AArch64][SVE] Add the @llvm.aarch64.sve.dup.unpred intrinsic.
  • Renamed @llvm.aarch64.sve.dup.unpred as @llvm.aarch64.sve.dup.x (this is consistent with other unpredicated intrinsics)
  • Restored the original name of @llvm.aarch64.sve.dup
Mar 12 2020, 7:03 AM · Restricted Project

Mar 11 2020

andwar committed rGa9f15832287e: [AArch64][SVE] Add the @llvm.aarch64.sve.sel intrinsic (authored by andwar).
[AArch64][SVE] Add the @llvm.aarch64.sve.sel intrinsic
Mar 11 2020, 10:14 AM
andwar closed D75928: [AArch64][SVE] Add the @llvm.aarch64.sve.sel intrinsic.
Mar 11 2020, 10:13 AM · Restricted Project
andwar added inline comments to D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.
Mar 11 2020, 10:09 AM · Restricted Project
andwar updated the diff for D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.

Rename getScaledOffsetForLDNT1 as getScaledOffsetForBitwidth

Mar 11 2020, 10:09 AM · Restricted Project

Mar 10 2020

andwar added a reviewer for D75900: [AArch64][SVE] Add the @llvm.aarch64.sve.dup.unpred intrinsic: kmclaughlin.
Mar 10 2020, 9:12 AM · Restricted Project
andwar created D75928: [AArch64][SVE] Add the @llvm.aarch64.sve.sel intrinsic.
Mar 10 2020, 9:12 AM · Restricted Project
andwar added a comment to D75580: [llvm][CodeGen][SVE] Implement IR intrinsics for gather prefetch..

@fpetrogalli Thanks for the update - this has evolved into a very neat patch! I've left a few nits, nothing major. One additional nice-to-have: could the commit message contain the list of intrinsics that you are adding? Personally I think that making references to ACLE there is not needed, but I don't mind it being there.

Mar 10 2020, 5:12 AM · Restricted Project
andwar updated the diff for D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.

Fix formatting to appease Harbormaster.

Mar 10 2020, 3:46 AM · Restricted Project
andwar created D75900: [AArch64][SVE] Add the @llvm.aarch64.sve.dup.unpred intrinsic.
Mar 10 2020, 3:46 AM · Restricted Project

Mar 6 2020

andwar updated the summary of D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.
Mar 6 2020, 5:31 AM · Restricted Project
andwar added inline comments to D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.
Mar 6 2020, 5:31 AM · Restricted Project
andwar updated the diff for D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.
  • Replaced ISD::MUL from my original patch with ISD::SHL
  • Added patterns for ISD::SHL for scalable types
  • Extracted the scaling into a seperate function
Mar 6 2020, 4:57 AM · Restricted Project

Mar 5 2020

andwar added a comment to D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.

If I'm following correctly, you don't actually create any SSTNT1_INDEX nodes? You're just using it as a placeholder in the call to performScatterStoreCombine? I guess that's not a big deal.

Mar 5 2020, 6:01 AM · Restricted Project

Mar 4 2020

andwar added a comment to D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.

Just a quick note: this patch is formatted consistently with the files that it touches. Since these files diverge from the official clang-format rules, clang-format pre-merge checks failed.

Mar 4 2020, 11:15 AM · Restricted Project
andwar added a comment to D75580: [llvm][CodeGen][SVE] Implement IR intrinsics for gather prefetch..

Hi @fpetrogalli, thank you for working on this!

Mar 4 2020, 6:11 AM · Restricted Project
andwar added inline comments to D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.
Mar 4 2020, 3:59 AM · Restricted Project
andwar created D75601: [AArch64][SVE] Add intrinsics for non-temporal scatters/gathers.
Mar 4 2020, 3:58 AM · Restricted Project
andwar accepted D75160: [AArch64][SVE] Add SVE2 intrinsic for xar.

LGTM, cheers for working on this!

Mar 4 2020, 3:26 AM · Restricted Project

Mar 2 2020

andwar committed rG9249f606024b: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores (authored by andwar).
[AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores
Mar 2 2020, 2:42 AM
andwar closed D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.
Mar 2 2020, 2:42 AM · Restricted Project

Feb 27 2020

andwar committed rGfa9439fac84e: [AArch64][SVE] Add intrinsics for first-faulting gather loads (authored by andwar).
[AArch64][SVE] Add intrinsics for first-faulting gather loads
Feb 27 2020, 9:48 AM
andwar closed D75128: [AArch64][SVE] Add intrinsics for first-faulting gather loads.
Feb 27 2020, 9:48 AM · Restricted Project

Feb 26 2020

andwar added inline comments to D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.
Feb 26 2020, 5:49 AM · Restricted Project
andwar updated the diff for D75128: [AArch64][SVE] Add intrinsics for first-faulting gather loads.

@sdesmalen Thank you for reviewing! Yes, the tests were failing with expensive checks enabled. Great catch, thank you!

Feb 26 2020, 3:33 AM · Restricted Project

Feb 25 2020

andwar added a comment to D75128: [AArch64][SVE] Add intrinsics for first-faulting gather loads.

This is almost literally copy & paste of the implementation of the regular gather loads, hence submitting as one patch (there are only few meaningful changes). I generated the tests by copying the corresponding tests for regular gather loads (I did update the opcodes though).

Feb 25 2020, 9:42 AM · Restricted Project
andwar created D75128: [AArch64][SVE] Add intrinsics for first-faulting gather loads.
Feb 25 2020, 9:31 AM · Restricted Project
andwar updated the diff for D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.

I've already updated the summary and replied to comments inline. Here's a summary of the latest changes:

Feb 25 2020, 7:52 AM · Restricted Project
andwar added a comment to D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.

This patch is doing a lot of refactoring/renaming, can you separate that out into a separate NFC patch?

Feb 25 2020, 7:43 AM · Restricted Project
andwar updated the summary of D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.
Feb 25 2020, 7:42 AM · Restricted Project
andwar committed rGcff90c938b7b: [AArch64][SVE] Update names and comments for gathers/scatters (NFC) (authored by andwar).
[AArch64][SVE] Update names and comments for gathers/scatters (NFC)
Feb 25 2020, 3:12 AM
andwar closed D75035: [AArch64][SVE] Update names and comments for gathers/scatters (NFC).
Feb 25 2020, 3:12 AM · Restricted Project
andwar retitled D75035: [AArch64][SVE] Update names and comments for gathers/scatters (NFC) from [AArch64][SVE] Refactor the implementation of gathers/scatters (NFC) to [AArch64][SVE] Update names and comments for gathers/scatters (NFC).
Feb 25 2020, 1:01 AM · Restricted Project
andwar added a comment to D75035: [AArch64][SVE] Update names and comments for gathers/scatters (NFC).

Thank you for taking a look @sdesmalen!

Feb 25 2020, 1:01 AM · Restricted Project
andwar updated the diff for D75035: [AArch64][SVE] Update names and comments for gathers/scatters (NFC).

I removed the functional changes from AArch64ISelLowering.cpp.

Feb 25 2020, 12:51 AM · Restricted Project

Feb 24 2020

andwar added a comment to D74969: [ReleaseNotes] Mention the `vector-function-abi-variant` attribute..

LGTM

Feb 24 2020, 8:21 AM · Restricted Project
andwar added inline comments to D74581: [llvm][CodeGen][aarch64] Add contiguous prefetch intrinsics for SVE..
Feb 24 2020, 6:05 AM · Restricted Project
andwar created D75035: [AArch64][SVE] Update names and comments for gathers/scatters (NFC).
Feb 24 2020, 2:06 AM · Restricted Project

Feb 21 2020

andwar updated the diff for D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.

Fixing typo: STD --> SDT.

Feb 21 2020, 6:42 AM · Restricted Project
andwar added inline comments to D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.
Feb 21 2020, 5:29 AM · Restricted Project
andwar added a comment to D74782: [llvm][CodeGen] DAG Combiner folds for vscale..

@fpetrogalli Thank you for working on this! A few nits, but nothing blocking. LGTM!

Feb 21 2020, 3:05 AM · Restricted Project
andwar added a comment to D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.

That's a good point, thank you! I've updated the summary to reflect that.

Feb 21 2020, 2:56 AM · Restricted Project
andwar updated the summary of D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.
Feb 21 2020, 2:56 AM · Restricted Project
andwar added a comment to D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup.

Cheers for working on this @kmclaughlin!

Feb 21 2020, 2:29 AM · Restricted Project

Feb 20 2020

andwar updated the diff for D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.

I've made some NFC changes, so that we re-use more code.

Feb 20 2020, 6:13 AM · Restricted Project
andwar added a comment to D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.

Hi @efriedma , thank you for taking a look!

Feb 20 2020, 5:10 AM · Restricted Project
andwar committed rG0e417b034ad2: [AArch64][SVE] Re-arrange definitions in AArch64SVEInstrInfo.td (NFC) (authored by andwar).
[AArch64][SVE] Re-arrange definitions in AArch64SVEInstrInfo.td (NFC)
Feb 20 2020, 4:43 AM

Feb 19 2020

andwar created D74858: [AArch64][SVE] Add intrinsics for non-temporal gather-loads/scatter-stores.
Feb 19 2020, 11:46 AM · Restricted Project
andwar added a comment to D74254: [llvm][aarch64] SVE addressing modes..

Thank you for all the updates @fpetrogalli ! LGTM

Feb 19 2020, 6:32 AM · Restricted Project

Feb 17 2020

andwar added inline comments to D74254: [llvm][aarch64] SVE addressing modes..
Feb 17 2020, 11:16 AM · Restricted Project
andwar added a comment to D74254: [llvm][aarch64] SVE addressing modes..

Cheers for updating this @fpetrogalli ! My most recent comments are mostly nits.

Feb 17 2020, 11:16 AM · Restricted Project

Feb 13 2020

andwar added inline comments to D74550: [AArch64][SVE] Add SVE index intrinsic.
Feb 13 2020, 9:56 AM · Restricted Project
andwar added a comment to D74254: [llvm][aarch64] SVE addressing modes..

IMHO every test functions (e.g.:test_masked_ldst_sv2i8 ) should either test contiguous load or store (i.e. only one thing at a time). That will help triaging potential bugs in the future and also would be consistent with other test files in this folder.

I see your point, but the tests that use merge and store at the same time are using exactly the same addressing modes, it is not that they are using something different. So if something fails in the addressing mode of the load, it fails in the addressing mode of the store. Having them merged together saves quite some typing, and has no disadvantages in term of unit testing.

Feb 13 2020, 4:34 AM · Restricted Project

Feb 12 2020

andwar added a comment to D74254: [llvm][aarch64] SVE addressing modes..

Hi @fpetrogalli, thank you for working on this.

Feb 12 2020, 6:32 AM · Restricted Project

Feb 11 2020

andwar added inline comments to D73602: [SVE] Add support for lowering GEPs involving scalable vectors..
Feb 11 2020, 9:30 AM · Restricted Project

Jan 28 2020

andwar added a comment to D73286: [llvm][VectorUtils] Tweak VFShape for scalable vector functions..

One [nit] (non-blocking), otherwise LGTM.

Jan 28 2020, 2:05 AM · Restricted Project

Jan 27 2020

andwar added a comment to D73286: [llvm][VectorUtils] Tweak VFShape for scalable vector functions..

A few nits. Also, in the commit msg:

Jan 27 2020, 10:00 AM · Restricted Project

Jan 25 2020

andwar added a comment to D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variant`..

LGTM

Jan 25 2020, 4:20 AM · Restricted Project

Jan 20 2020

andwar committed rG7e717b399055: [AArch64][SVE] Extend int_aarch64_sve_ld1_gather_imm (authored by andwar).
[AArch64][SVE] Extend int_aarch64_sve_ld1_gather_imm
Jan 20 2020, 4:26 AM
andwar closed D71773: [AArch64][SVE] Update the definition of AdvSIMD_GatherLoad_VecTorBase_Intrinsic.
Jan 20 2020, 4:26 AM · Restricted Project
andwar added inline comments to D71773: [AArch64][SVE] Update the definition of AdvSIMD_GatherLoad_VecTorBase_Intrinsic.
Jan 20 2020, 1:49 AM · Restricted Project
andwar added inline comments to D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variant`..
Jan 20 2020, 1:31 AM · Restricted Project