[mlir][gpu] Fix CMake errors in case NVPTX is not enabled. NFC.

[mehdi_amini]

I only see this now, I already reverted the offending patch I think. In the future if you have a fix for a build failure, please land it directly without code review: it is more important to unbreak everyone ASAP (either through revert or hot fix).
You can always ping the original revision to indicate that you had to do that so that the original reviewer can take a look at it post-review.

Right now the best course of action is to squash this into your original patch and land it back (there is a comment from Richard in your original revision that should likely be addressed first).

mlir/test/lib/Transforms/CMakeLists.txt

6

This is too intrusive: can we define an *empty* target MLIRGPUtoCUDATransforms always instead? (just not using add_mlir_conversion_library to do so)

[whchung]

In D80343#2048267, @mehdi_amini wrote:

I only see this now, I already reverted the offending patch I think. In the future if you have a fix for a build failure, please land it directly without code review: it is more important to unbreak everyone ASAP (either through revert or hot fix).
You can always ping the original revision to indicate that you had to do that so that the original reviewer can take a look at it post-review.

Right now the best course of action is to squash this into your original patch and land it back (there is a comment from Richard in your original revision that should likely be addressed first).

@mehdi_amini Sorry for causing the confusions. Will follow the guidance in the future. I've reopened D80167 and addressed comments from @rsmith and you.

mlir/lib/Conversion/GPUToCUDA/CMakeLists.txt

 set(LLVM_OPTIONAL_SOURCES
   ConvertKernelFuncToCubin.cpp
 )
 
 if (MLIR_CUDA_CONVERSIONS_ENABLED)
- list(APPEND SOURCES "ConvertKernelFuncToCubin.cpp")
   set(NVPTX_LIBS
     MC
     NVPTXCodeGen
     NVPTXDesc
     NVPTXInfo
   )
 
-endif()
-
 add_mlir_conversion_library(MLIRGPUtoCUDATransforms
-  ${SOURCES}
+  ConvertKernelFuncToCubin.cpp
 
   DEPENDS
   MLIRConversionPassIncGen
   intrinsics_gen
 
   LINK_COMPONENTS
   Core
   ${NVPTX_LIBS}
 
   LINK_LIBS PUBLIC
   MLIRGPU
   MLIRIR
   MLIRLLVMIR
   MLIRNVVMIR
   MLIRPass
   MLIRSupport
   MLIRTargetNVVMIR
 )
+endif()

mlir/test/lib/Transforms/CMakeLists.txt

+if (MLIR_CUDA_CONVERSIONS_ENABLED)
+  set(CUDA_TRANSFORMS
+    MLIRGPUtoCUDATransforms
+  )
+endif()
+
 # Exclude tests from libMLIR.so
 add_mlir_library(MLIRTestTransforms
   TestAllReduceLowering.cpp
   TestBufferPlacement.cpp
   TestCallGraph.cpp
   TestConstantFold.cpp
   TestConvertGPUKernelToCubin.cpp
   TestDominance.cpp
add_mlir_library(MLIRTestTransforms
   MLIRStandardOpsIncGen
   MLIRTestVectorTransformPatternsIncGen
 
   LINK_LIBS PUBLIC
   MLIRAffineOps
   MLIRAnalysis
   MLIREDSC
   MLIRGPU
-  MLIRGPUtoCUDATransforms
   MLIRLinalgOps
   MLIRLinalgTransforms
   MLIRSCF
   MLIRGPU
   MLIRPass
   MLIRStandardOpsTransforms
   MLIRTestDialect
   MLIRTransformUtils
   MLIRVectorToSCF
   MLIRVector
+  ${CUDA_TRANSFORMS}
   )
 
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../Dialect/Test)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../Dialect/Test)
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../DeclarativeTransforms)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../DeclarativeTransforms)