Page MenuHomePhabricator

[mlir][gpu] Fix CMake errors in case NVPTX is not enabled. NFC.
AbandonedPublic

Authored by whchung on Wed, May 20, 4:30 PM.

Details

Diff Detail

Event Timeline

whchung created this revision.Wed, May 20, 4:30 PM
Herald added a project: Restricted Project. · View Herald Transcript
whchung retitled this revision from [mlir][gpu] Fix CMake errors in case NVPTX is not enabled. to [mlir][gpu] Fix CMake errors in case NVPTX is not enabled. NFC..Wed, May 20, 8:19 PM

I only see this now, I already reverted the offending patch I think. In the future if you have a fix for a build failure, please land it directly without code review: it is more important to unbreak everyone ASAP (either through revert or hot fix).
You can always ping the original revision to indicate that you had to do that so that the original reviewer can take a look at it post-review.

Right now the best course of action is to squash this into your original patch and land it back (there is a comment from Richard in your original revision that should likely be addressed first).

mlir/test/lib/Transforms/CMakeLists.txt
6

This is too intrusive: can we define an *empty* target MLIRGPUtoCUDATransforms always instead? (just not using add_mlir_conversion_library to do so)

whchung abandoned this revision.Wed, May 20, 9:03 PM
whchung added a subscriber: rsmith.Wed, May 20, 9:56 PM

I only see this now, I already reverted the offending patch I think. In the future if you have a fix for a build failure, please land it directly without code review: it is more important to unbreak everyone ASAP (either through revert or hot fix).
You can always ping the original revision to indicate that you had to do that so that the original reviewer can take a look at it post-review.

Right now the best course of action is to squash this into your original patch and land it back (there is a comment from Richard in your original revision that should likely be addressed first).

@mehdi_amini Sorry for causing the confusions. Will follow the guidance in the future. I've reopened D80167 and addressed comments from @rsmith and you.