Page MenuHomePhabricator

[yaml2obj] - Implement the "Offset" property for the Fill Chunk.
ClosedPublic

Authored by grimar on May 19 2020, 8:18 AM.

Details

Summary

Similar to a regular section chunk, a Fill should have this property.
This patch implements it.

Diff Detail

Event Timeline

grimar created this revision.May 19 2020, 8:18 AM
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.May 19 2020, 5:02 PM

Looks great!

This revision is now accepted and ready to land.May 19 2020, 5:02 PM
jhenderson added inline comments.May 20 2020, 8:35 AM
llvm/test/tools/yaml2obj/ELF/custom-fill.yaml
305

arbitraty -> arbitrary

309

I'm not sure we really need to check the section header table offset, as the position of .bar is sufficient to show the fill impacts the offset calculations.

grimar updated this revision to Diff 265180.May 20 2020, 9:33 AM
grimar marked 3 inline comments as done.
  • Addressed review comments.
llvm/test/tools/yaml2obj/ELF/custom-fill.yaml
309

Probably you're right. Not sure why I've added this line.

This revision was automatically updated to reflect the committed changes.