Page MenuHomePhabricator

StoreInst should store Align, not MaybeAlign
ClosedPublic

Authored by efriedma on May 14 2020, 2:50 PM.

Details

Summary

This is D77454, except for stores. All the infrastructure work was done for loads, so the remaining changes necessary are relatively small.

Diff Detail

Event Timeline

efriedma created this revision.May 14 2020, 2:50 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
jdoerfert accepted this revision.May 14 2020, 8:48 PM

LGTM, two minor things below.

clang/lib/CodeGen/CGExpr.cpp
130

Nit: I guess /* volatile */ false

llvm/lib/IR/Instructions.cpp
1422

Minor: Do we want toe keep the name? computeAccessAlign maybe? Or a shallow computeStoreAlign wrapper? No strong feelings, just odd.

This revision is now accepted and ready to land.May 14 2020, 8:48 PM
This revision was automatically updated to reflect the committed changes.