Page MenuHomePhabricator

[mlir][Linalg] Retire C++ MatmulOp in favor of a linalg-ods-gen'd op.
ClosedPublic

Authored by nicolasvasilache on May 11 2020, 8:40 PM.

Details

Summary

This revision replaces MatmulOp, now that DRR rules have been dropped.
This revision also fixes minor parsing bugs and a plugs a few holes to get e2e paths working (e.g. library call emission).

During the replacement the i32 version had to be dropped because only the EDSC operators +, *, etc support type inference.

Deciding on a type-polymorphic behavior, and implementing it, is left for future work.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald Transcript
mravishankar accepted this revision.May 11 2020, 10:55 PM

This looks fine to me.

This revision is now accepted and ready to land.May 11 2020, 10:55 PM
antiagainst accepted this revision.May 14 2020, 4:42 AM

Looks good!

Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
This revision was automatically updated to reflect the committed changes.