Page MenuHomePhabricator

[lld-macho][reland] Add support for emitting dylibs with a single symbol
ClosedPublic

Authored by int3 on Apr 28 2020, 4:12 PM.

Details

Summary

This got reverted due to UBSAN errors in a diff lower in the stack,
which is being fixed in D79050: [lld-macho][reland] Add basic symbol table output. This diff is otherwise identical to
the original D76908: [lld-macho] Add support for emitting dylibs with a single symbol.

Depends on D79050.

Diff Detail

Event Timeline

int3 created this revision.Apr 28 2020, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2020, 4:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 5:18 PM
This revision was automatically updated to reflect the committed changes.

(this was a recommit, so I just landed it without an explicit accept)

For a reland, you could reuse the old differential and click "Reopen" instead of opening a new one.

Commits will clearly show what commits are associated with that differential revision.

int3 added a comment.Apr 28 2020, 11:13 PM

Yeah I belatedly noticed that the original differentials were reopened after the unland. FB's Phabricator doesn't work that way so it came as a bit of a surprise. Will keep it in mind for future un/relands.

Yeah I belatedly noticed that the original differentials were reopened after the unland. FB's Phabricator doesn't work that way so it came as a bit of a surprise. Will keep it in mind for future un/relands.

I reopened them manually. I don't think they automatically reopen.

int3 added a comment.Apr 29 2020, 2:02 PM

Ahh I see, got it