Page MenuHomePhabricator

christylee (Christy Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2018, 3:54 PM (42 w, 18 h)

Recent Activity

Mar 11 2019

christylee abandoned D59051: Fix ASTReader invalid bounds check.
Mar 11 2019, 10:12 AM · Restricted Project
christylee abandoned D59162: Fix Perf build failure due to getLineInfoForAddress API change.
Mar 11 2019, 10:12 AM · Restricted Project

Mar 8 2019

christylee added reviewers for D59162: Fix Perf build failure due to getLineInfoForAddress API change: avl, twoh.
Mar 8 2019, 3:33 PM · Restricted Project
christylee created D59162: Fix Perf build failure due to getLineInfoForAddress API change.
Mar 8 2019, 3:32 PM · Restricted Project

Mar 6 2019

christylee added a comment to D59051: Fix ASTReader invalid bounds check.

include/llvm/ADT/SmallVector.h:153 has an assert statement, but I'm not sure why I'm the only one who's experienced problems so far.

Mar 6 2019, 2:18 PM · Restricted Project
christylee created D59051: Fix ASTReader invalid bounds check.
Mar 6 2019, 2:07 PM · Restricted Project
christylee added reviewers for D59051: Fix ASTReader invalid bounds check: tks2103, modocache.
Mar 6 2019, 2:07 PM · Restricted Project
christylee planned changes to D56205: Add -z common-page-size option.
Mar 6 2019, 1:47 PM · Restricted Project

Jan 14 2019

christylee accepted D56631: [MSVC Compat] Fix typo correction for inclusion directives..

Thanks for catching that!

Jan 14 2019, 9:07 AM

Jan 2 2019

christylee added a comment to D56205: Add -z common-page-size option.

Could you elaborate a bit on why hot text (is that .text.hot section?) needs to have a stricter alignment requirement than the common-page-size?

Jan 2 2019, 3:02 PM · Restricted Project
christylee added a comment to D56205: Add -z common-page-size option.

Do you know why that system uses not only max-page-size but also common-page-size?

Jan 2 2019, 2:20 PM · Restricted Project
christylee added a comment to D56205: Add -z common-page-size option.

I wonder if you found a use case of -z common-page-size with a page size that is different from the ABI's default. For example, did you find a use case of the option for x86-64 with a page size larger than 4096?

Jan 2 2019, 11:47 AM · Restricted Project
christylee changed the repository for D56205: Add -z common-page-size option from rL LLVM to rLLD LLVM Linker.
Jan 2 2019, 10:15 AM · Restricted Project
christylee created D56205: Add -z common-page-size option.
Jan 2 2019, 10:14 AM · Restricted Project

Nov 30 2018

christylee commandeered D46628: [ELF] Add --strip-debug-non-line option.

I spoke with @modocache and I'm going to take a crack at this.

Nov 30 2018, 10:07 AM

Oct 26 2018

christylee committed rL345413: Pointer types were treated as zero-size by MergeICmps.
Pointer types were treated as zero-size by MergeICmps
Oct 26 2018, 11:05 AM
christylee closed D53536: Pointer types were treated as zero-size by MergeICmps.
Oct 26 2018, 11:05 AM
christylee added a comment to D53536: Pointer types were treated as zero-size by MergeICmps.

One more favor to ask: Could I please have some help committing this fix? I'm new to the project and don't have write access yet...

Oct 26 2018, 10:55 AM

Oct 23 2018

christylee added a reviewer for D53536: Pointer types were treated as zero-size by MergeICmps: courbet.
Oct 23 2018, 8:58 AM

Sep 24 2018

christylee abandoned D51550: Use alias analysis to check for real interference in cascade comparison.

The changes were landed in D52433

Sep 24 2018, 1:51 PM
christylee committed rL342919: Re-submitting changes in D51550 because it failed to patch..
Re-submitting changes in D51550 because it failed to patch.
Sep 24 2018, 1:50 PM
christylee closed D52433: Re-submitting changes in D51550 because it failed to patch..
Sep 24 2018, 1:50 PM
christylee added reviewers for D52433: Re-submitting changes in D51550 because it failed to patch.: trentxintong, courbet.
Sep 24 2018, 1:33 PM
christylee created D52433: Re-submitting changes in D51550 because it failed to patch..
Sep 24 2018, 1:32 PM
christylee committed rL342907: Reland r342494 after fixing LIT checks..
Reland r342494 after fixing LIT checks.
Sep 24 2018, 10:30 AM
christylee added a comment to D51550: Use alias analysis to check for real interference in cascade comparison.

@courbet , @lebedev.ri , I'm trying to commit the patch by first running "arc patch D51550", but it keeps saying unable to apply patch because llvm/trunk/test/Transforms/MergeICmps/X86/alias-merge-blocks.ll does not exists in index. How should I go about this?

Sep 24 2018, 9:23 AM
christylee updated the diff for D51550: Use alias analysis to check for real interference in cascade comparison.

Going back to previous revision to include the test in this revision.

Sep 24 2018, 9:17 AM

Sep 20 2018

christylee accepted D52280: Don't trim non-alphanumeric characters in 'file not found' errors for include directives..

Thanks for the fix!

Sep 20 2018, 5:21 AM

Sep 18 2018

christylee committed rL342498: Do not optimize atomic load to non-atomic memcmp.
Do not optimize atomic load to non-atomic memcmp
Sep 18 2018, 10:04 AM
christylee closed D51998: Do not optimize atomic load to non-atomic memcmp.
Sep 18 2018, 10:04 AM
christylee committed rL342494: Check lines before using alias analysis to check for interference.
Check lines before using alias analysis to check for interference
Sep 18 2018, 9:45 AM
christylee closed D52044: Check lines before using alias analysis to check for interference.
Sep 18 2018, 9:45 AM

Sep 13 2018

christylee updated the diff for D51333: Diagnose likely typos in include statements.

Added tests.

Sep 13 2018, 12:56 PM
christylee added a comment to D51333: Diagnose likely typos in include statements.

@rsmith , thanks for the review, I fixed the variable capitalization. If you could land it for me that'll be awesome!

Sep 13 2018, 12:33 PM
christylee updated the diff for D51333: Diagnose likely typos in include statements.
Sep 13 2018, 12:31 PM
christylee updated the diff for D51333: Diagnose likely typos in include statements.
Sep 13 2018, 12:27 PM
christylee updated the diff for D51550: Use alias analysis to check for real interference in cascade comparison.
Sep 13 2018, 11:49 AM
christylee added a comment to D51550: Use alias analysis to check for real interference in cascade comparison.

Fixed diff dependencies.

Sep 13 2018, 11:11 AM
christylee added a parent revision for D51550: Use alias analysis to check for real interference in cascade comparison: D52044: Check lines before using alias analysis to check for interference.
Sep 13 2018, 11:10 AM
christylee added a child revision for D52044: Check lines before using alias analysis to check for interference: D51550: Use alias analysis to check for real interference in cascade comparison.
Sep 13 2018, 11:10 AM
christylee removed a parent revision for D52044: Check lines before using alias analysis to check for interference: D51550: Use alias analysis to check for real interference in cascade comparison.
Sep 13 2018, 11:10 AM
christylee removed a child revision for D51550: Use alias analysis to check for real interference in cascade comparison: D52044: Check lines before using alias analysis to check for interference.
Sep 13 2018, 11:10 AM
christylee updated the diff for D51550: Use alias analysis to check for real interference in cascade comparison.

Addressed @lebedev.ri 's comment and added dependent child diff to show original check-lines.

Sep 13 2018, 9:33 AM
christylee added a child revision for D51550: Use alias analysis to check for real interference in cascade comparison: D52044: Check lines before using alias analysis to check for interference.
Sep 13 2018, 9:27 AM
christylee added a parent revision for D52044: Check lines before using alias analysis to check for interference: D51550: Use alias analysis to check for real interference in cascade comparison.
Sep 13 2018, 9:27 AM
christylee added reviewers for D52044: Check lines before using alias analysis to check for interference: lebedev.ri, courbet.
Sep 13 2018, 9:27 AM
christylee created D52044: Check lines before using alias analysis to check for interference.
Sep 13 2018, 9:27 AM
christylee updated the diff for D51333: Diagnose likely typos in include statements.

Addressed @rsmith 's comments.

Sep 13 2018, 9:08 AM
christylee added inline comments to D51333: Diagnose likely typos in include statements.
Sep 13 2018, 8:43 AM

Sep 12 2018

christylee updated the diff for D51333: Diagnose likely typos in include statements.

Emit non-fatal error for typo if file exists.

Sep 12 2018, 3:06 PM
christylee added a comment to D51998: Do not optimize atomic load to non-atomic memcmp.

And of course thank you to @trentxintong :)

Sep 12 2018, 11:31 AM
christylee added a comment to D51998: Do not optimize atomic load to non-atomic memcmp.

Thanks for the review! @efriedma

Sep 12 2018, 11:28 AM
christylee created D51998: Do not optimize atomic load to non-atomic memcmp.
Sep 12 2018, 11:00 AM
christylee updated the diff for D51550: Use alias analysis to check for real interference in cascade comparison.

Addressed @courbet comment

Sep 12 2018, 10:23 AM

Sep 10 2018

christylee added inline comments to D51550: Use alias analysis to check for real interference in cascade comparison.
Sep 10 2018, 3:48 PM
christylee updated the diff for D51550: Use alias analysis to check for real interference in cascade comparison.
Sep 10 2018, 3:47 PM
christylee added inline comments to D51550: Use alias analysis to check for real interference in cascade comparison.
Sep 10 2018, 1:38 PM
christylee updated the diff for D51550: Use alias analysis to check for real interference in cascade comparison.

Removed clang-format changes unrelated to this patch.

Sep 10 2018, 1:28 PM
christylee updated the diff for D51550: Use alias analysis to check for real interference in cascade comparison.

For instructions that may have side effects, check that the instruction is a simple load or simple store before checking for alias. For things like function calls, we would have to check that they don't throw and have no read/write to memory. The function calls are potentially nested as well, it's probably better to just bail on those cases.

Sep 10 2018, 11:57 AM

Sep 7 2018

christylee added a comment to D51550: Use alias analysis to check for real interference in cascade comparison.

Friendly ping @courbet :)

Sep 7 2018, 11:48 AM

Aug 31 2018

christylee created D51550: Use alias analysis to check for real interference in cascade comparison.
Aug 31 2018, 10:51 AM
christylee added a comment to D51333: Diagnose likely typos in include statements.

Instead of guessing whether the corrected filename would be valid, why not strip off the leading and trailing non-alphanumeric characters, look up the resulting filename, and find out? If we did that, then not only could we be a lot more confident that we'd found the file that was intended, but we could also recover from the error by including the trimmed filename.

Aug 31 2018, 7:52 AM

Aug 29 2018

christylee updated the diff for D51333: Diagnose likely typos in include statements.

Merged warning with existing file_not_found_error.

Aug 29 2018, 10:25 AM

Aug 27 2018

christylee created D51333: Diagnose likely typos in include statements.
Aug 27 2018, 4:59 PM