This is an archive of the discontinued LLVM Phabricator instance.

Differential D78344

[Object] Use BFD name for little-endian PowerPC64
ClosedPublic

Authored by void on Apr 16 2020, 8:03 PM.

Details

Reviewers
jhenderson
MaskRay
• espindola
alexander-shaposhnikov
rupprecht
Group Reviewers
Restricted Project
Commits
rGedcfc391e142: [Object] Use BFD name for little-endian PowerPC64
Summary

Little-endian PowerPC object files should report "elf64-powerpcle" instead of
"elf64-powerpc".

Diff Detail

Event Timeline

void created this revision.Apr 16 2020, 8:03 PM
Herald added a reviewer: • espindola. · View Herald TranscriptApr 16 2020, 8:03 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald Transcript
Herald added a reviewer: rupprecht. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, steven.zhang, shchenz and 2 others. · View Herald Transcript
Harbormaster failed remote builds in B53672: Diff 258226!Apr 16 2020, 8:33 PM
Herald added a subscriber: • wuzish. · View Herald TranscriptApr 16 2020, 8:33 PM
jsji added a reviewer: Restricted Project.Apr 16 2020, 8:38 PM
jsji added a project: Restricted Project.
MaskRay added a comment.Apr 16 2020, 10:09 PM

See D76046 . elf64-powerpc64le is called a BFD name (or bfdname)

void added a comment.Apr 19 2020, 3:44 PM
In D78344#1988166, @MaskRay wrote:

See D76046 . elf64-powerpc64le is called a BFD name (or bfdname)

Okay. Did you need me to change something? :-)

MaskRay accepted this revision.Apr 19 2020, 5:56 PM
MaskRay retitled this revision from Add "powerpcle" as a file format to [Object] Use BFD name for little-endian PowerPC64.
MaskRay edited the summary of this revision. (Show Details)

With the subject changed, LG

This revision is now accepted and ready to land.Apr 19 2020, 5:57 PM
Closed by commit rGedcfc391e142: [Object] Use BFD name for little-endian PowerPC64 (authored by void). · Explain WhyApr 19 2020, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
include/
llvm/
Object/
2 lines
test/
tools/
llvm-objcopy/
ELF/
2 lines

Diff 258646

llvm/include/llvm/Object/ELFObjectFile.h

Show First 20 Lines • Show All 1,115 Lines • ▼ Show 20 Lines case ELF::ELFCLASS64:
switch (EF.getHeader()->e_machine) { switch (EF.getHeader()->e_machine) {
case ELF::EM_386: case ELF::EM_386:
return "elf64-i386"; return "elf64-i386";
case ELF::EM_X86_64: case ELF::EM_X86_64:
return "elf64-x86-64"; return "elf64-x86-64";
case ELF::EM_AARCH64: case ELF::EM_AARCH64:
return (IsLittleEndian ? "elf64-littleaarch64" : "elf64-bigaarch64"); return (IsLittleEndian ? "elf64-littleaarch64" : "elf64-bigaarch64");
case ELF::EM_PPC64: case ELF::EM_PPC64:
return "elf64-powerpc"; return (IsLittleEndian ? "elf64-powerpcle" : "elf64-powerpc");
case ELF::EM_RISCV: case ELF::EM_RISCV:
return "elf64-littleriscv"; return "elf64-littleriscv";
case ELF::EM_S390: case ELF::EM_S390:
return "elf64-s390"; return "elf64-s390";
case ELF::EM_SPARCV9: case ELF::EM_SPARCV9:
return "elf64-sparc"; return "elf64-sparc";
case ELF::EM_MIPS: case ELF::EM_MIPS:
return "elf64-mips"; return "elf64-mips";
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines

llvm/test/tools/llvm-objcopy/ELF/cross-arch-headers.test

Show First 20 Lines • Show All 141 Lines • ▼ Show 20 Lines
# I386-SAME: i386 # I386-SAME: i386
# IAMCU-SAME: iamcu # IAMCU-SAME: iamcu
# AARCH-SAME: aarch64 # AARCH-SAME: aarch64
# ARM-SAME: littlearm # ARM-SAME: littlearm
# HEXAGON-SAME: hexagon # HEXAGON-SAME: hexagon
# MIPS-SAME: mips # MIPS-SAME: mips
# PPC-SAME: powerpc{{$}} # PPC-SAME: powerpc{{$}}
# PPC64BE-SAME: powerpc{{$}} # PPC64BE-SAME: powerpc{{$}}
# PPC64LE-SAME: powerpc{{$}} # PPC64LE-SAME: powerpcle{{$}}
# RISCV32-SAME: riscv{{$}} # RISCV32-SAME: riscv{{$}}
# RISCV64-SAME: riscv{{$}} # RISCV64-SAME: riscv{{$}}
# SPARC-SAME: sparc # SPARC-SAME: sparc
# X86-64-SAME: x86-64 # X86-64-SAME: x86-64
# DEFAULT-SAME: unknown # DEFAULT-SAME: unknown
# I386-NEXT: Arch: i386 # I386-NEXT: Arch: i386
# IAMCU-NEXT: Arch: i386 # IAMCU-NEXT: Arch: i386
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines