- Remove the no longer used Darwin CalleeSavedRegs
- Combine the SVR464 callee saved regs and AIX64 since the two are (and should be) identical into PPC64
- Update tests for 64-bit CSR change
Details
- Reviewers
sfertile ZarkoCA cebowleratibm jasonliu - Group Reviewers
Restricted Project - Commits
- rGb9245f14b799: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/PowerPC/PPCCallingConv.td | ||
---|---|---|
328 | The SVR4 is no longer appropriate, since this represent the CSRs for all the 64-bit targets, not just ELF. I think CSR_64 is fine, but open to better suggestions. |
llvm/lib/Target/PowerPC/PPCCallingConv.td | ||
---|---|---|
328 | I agree with Sean. If we are going to use this for all 64BIT targets then we should name it appropriately. You may need to change the following tests when doing so: |
llvm/lib/Target/PowerPC/PPCCallingConv.td | ||
---|---|---|
328 | CSR_64 is in use by X86, so to keep things clear I opted for CSR_PPC64 |
I would rather we don't rename any of the ViaCopy lists, or CSR_SRV464_TLS_PE_SaveList since they are likely dead. We can write IR that triggers them, but Clang will only generate said IR for Darwin IIUC and from the name of the calling convention it is limited to C++.
Also please clang format the changes.
llvm/lib/Target/PowerPC/PPCCallingConv.td | ||
---|---|---|
328 | Works for me. |
The SVR4 is no longer appropriate, since this represent the CSRs for all the 64-bit targets, not just ELF. I think CSR_64 is fine, but open to better suggestions.