This is an archive of the discontinued LLVM Phabricator instance.

Expose `attributor-disable` to the new and old pass managers
ClosedPublic

Authored by tarinduj on Mar 26 2020, 11:12 AM.

Details

Summary

The new and old pass managers (PassManagerBuilder.cpp and PassBuilder.cpp) are exposed to an extern declaration of attributor-disable option which will guard the addition of the attributor passes to the pass pipelines.

Diff Detail

Event Timeline

tarinduj created this revision.Mar 26 2020, 11:12 AM
Herald added a reviewer: uenoku. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
tarinduj updated this revision to Diff 252943.Mar 26 2020, 12:21 PM

I think the patch description is lacking - the switch already exists, and it works.
There should be an explanation as to why it is being moved.

I think the patch description is lacking - the switch already exists, and it works.
There should be an explanation as to why it is being moved.

I'll provide the link to the request by @fhahn later but I asked @tarinduj to work on this. We should put the link into the commit message as well.

jdoerfert requested changes to this revision.Mar 26 2020, 1:29 PM

This will have an effect on the tests in llvm/tests/Other, please update them accordingly

This revision now requires changes to proceed.Mar 26 2020, 1:29 PM
tarinduj updated this revision to Diff 254794.Apr 3 2020, 7:22 AM

modified the files in test/Other

jdoerfert accepted this revision.Apr 4 2020, 8:59 AM

Apologies for the delay. LGTM.

Can you provide me with "Firstname Lastname <email>" from you so I can attribute it to you?

This revision is now accepted and ready to land.Apr 4 2020, 8:59 AM

Apologies for the delay. LGTM.

Can you provide me with "Firstname Lastname <email>" from you so I can attribute it to you?

Tarindu Jayatilaka
tarindujayatilaka@gmail.com

This revision was automatically updated to reflect the committed changes.