Page MenuHomePhabricator

tarinduj (Tarindu Jayatilaka)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2020, 4:54 AM (77 w, 3 d)

Recent Activity

Aug 9 2021

tarinduj updated the diff for D107746: Function Annotation with Function Attributes.

Fixed case style for variable

Aug 9 2021, 2:07 AM · Restricted Project
tarinduj requested review of D107746: Function Annotation with Function Attributes.
Aug 9 2021, 1:06 AM · Restricted Project

Jul 29 2021

tarinduj updated the diff for D107025: Take OptimizationLevel class out of Pass Builder.

added newline at the end to OptimizationLevel.h

Jul 29 2021, 8:06 PM · Restricted Project, Restricted Project
tarinduj updated the diff for D107025: Take OptimizationLevel class out of Pass Builder.

clang-format

Jul 29 2021, 2:43 AM · Restricted Project, Restricted Project
tarinduj updated the diff for D107025: Take OptimizationLevel class out of Pass Builder.

added namespace, header guards, and the include

Jul 29 2021, 1:49 AM · Restricted Project, Restricted Project

Jul 28 2021

tarinduj requested review of D107025: Take OptimizationLevel class out of Pass Builder.
Jul 28 2021, 8:55 PM · Restricted Project, Restricted Project

Jul 22 2020

tarinduj updated the diff for D82283: Add new function properties to FunctionPropertiesAnalysis.

[rebased] can someone upstream this? I do not have commit access.

Jul 22 2020, 8:24 AM · Restricted Project
tarinduj updated the diff for D82523: Add a Printer to the FunctionPropertiesAnalysis.

[rebased] can someone upstream this? I do not have commit access.

Jul 22 2020, 8:24 AM · Restricted Project
tarinduj updated the diff for D82521: Refactor FunctionPropertiesAnalysis .

[rebased] can someone upstream this? I do not have commit access.

Jul 22 2020, 8:24 AM · Restricted Project
tarinduj updated the diff for D82044: Rename InlineFeatureAnalysis to FunctionPropertiesAnalysis.

[rebased] can someone upstream this? I do not have commit access.

Jul 22 2020, 8:24 AM · Restricted Project

Jun 26 2020

tarinduj updated the diff for D82283: Add new function properties to FunctionPropertiesAnalysis.
Jun 26 2020, 2:40 AM · Restricted Project

Jun 25 2020

tarinduj updated the diff for D82523: Add a Printer to the FunctionPropertiesAnalysis.

rebased

Jun 25 2020, 10:46 AM · Restricted Project
tarinduj updated the diff for D82521: Refactor FunctionPropertiesAnalysis .

added a static factory method getFunctionPropertiesInfo.

Jun 25 2020, 10:46 AM · Restricted Project
tarinduj updated the diff for D82283: Add new function properties to FunctionPropertiesAnalysis.

fixed formatting and renamed the LoopCount to TopLevelLoopCount.

Jun 25 2020, 1:03 AM · Restricted Project
tarinduj retitled D81716: Extend InlineFeatureAnalysis to more extract generic code features [Obsolete] from Extend InlineFeatureAnalysis to more extract generic code features to Extend InlineFeatureAnalysis to more extract generic code features [Obsolete].
Jun 25 2020, 12:29 AM · Restricted Project
tarinduj retitled D82270: Added a Printer to the FunctionPropertiesAnalysis [Obsolete] from Added a Printer to the FunctionPropertiesAnalysis to Added a Printer to the FunctionPropertiesAnalysis [Obsolete].
Jun 25 2020, 12:29 AM · Restricted Project
tarinduj created D82523: Add a Printer to the FunctionPropertiesAnalysis.
Jun 25 2020, 12:29 AM · Restricted Project

Jun 24 2020

tarinduj updated the diff for D82521: Refactor FunctionPropertiesAnalysis .
Jun 24 2020, 11:57 PM · Restricted Project
tarinduj created D82521: Refactor FunctionPropertiesAnalysis .
Jun 24 2020, 11:57 PM · Restricted Project
tarinduj added a comment to D82270: Added a Printer to the FunctionPropertiesAnalysis [Obsolete].

I think it'd still make sense to split the patch one chunk to refactor (NFC), one to add the printer with test and all that - wdyt?

Jun 24 2020, 11:25 PM · Restricted Project

Jun 21 2020

tarinduj updated the summary of D82283: Add new function properties to FunctionPropertiesAnalysis.
Jun 21 2020, 10:45 PM · Restricted Project
tarinduj created D82283: Add new function properties to FunctionPropertiesAnalysis.
Jun 21 2020, 10:45 PM · Restricted Project

Jun 20 2020

tarinduj created D82270: Added a Printer to the FunctionPropertiesAnalysis [Obsolete].
Jun 20 2020, 9:43 PM · Restricted Project

Jun 18 2020

tarinduj updated the summary of D82044: Rename InlineFeatureAnalysis to FunctionPropertiesAnalysis.
Jun 18 2020, 12:30 AM · Restricted Project
tarinduj added a comment to D82044: Rename InlineFeatureAnalysis to FunctionPropertiesAnalysis.

Nit: I think the motivation was that we want to experiment with extending it and purposing it for other than inliner usecases (as opposed to avoiding confusion - it's not clear what confusion there was)

Jun 18 2020, 12:30 AM · Restricted Project

Jun 17 2020

tarinduj created D82044: Rename InlineFeatureAnalysis to FunctionPropertiesAnalysis.
Jun 17 2020, 12:56 PM · Restricted Project

Jun 16 2020

tarinduj updated the diff for D81716: Extend InlineFeatureAnalysis to more extract generic code features [Obsolete].

added comments

Jun 16 2020, 3:51 AM · Restricted Project
tarinduj updated the diff for D81716: Extend InlineFeatureAnalysis to more extract generic code features [Obsolete].

Replaced InlineFeatureAnalysis with FunctionPropertiesAnalysis.

Jun 16 2020, 2:09 AM · Restricted Project

Jun 15 2020

tarinduj added a comment to D81716: Extend InlineFeatureAnalysis to more extract generic code features [Obsolete].

As a first step, if the planned new features would add space or computational overhead, could the work requiring the extra features have its own analysis and consume both analysis results? As we have examples of more such analyses and understand the usecases and performance tradeoffs, we can very easily refactor / rename.

While we can have more analysis if we want, I somehow doubt that will make it better. I was envisioning a lazy approach in which the analysis will not do anything until instructed to. Users can "ask" for what they want while reuse is still possible and code is kept at a single place. As an example, if users ask to findCFGstructureFeatures they will not get any instruction level results. Querying those could assert w/o extra cost. I don't see why this would cost us extra and I would prefer it very much over a multitude of passes. WDYT?

IIUC, that means the one analysis memoizes results. I'm speculating invalidation would be total - i.e. even if only some results were needed (and, thus, computed), invalidation clears everything. Getting results would be semantically equivalent to having many analyses. Invalidating would be semantically equivalent to going piecemeal through the analyses that should be cleared and doing that. I'm not sure if that'd be always desirable, I suppose we'll learn when we hit a specific problem.

How about this:

  • we rename InlineFeaturesAnalysis to FunctionFeaturesAnalysis (just because "Code" is too general - do we use that term elsewhere in LLVM?)

I think that is fine. @tarinduj, WDYT?

Jun 15 2020, 7:19 PM · Restricted Project

Jun 11 2020

tarinduj retitled D81716: Extend InlineFeatureAnalysis to more extract generic code features [Obsolete] from Extend InlineFeatureAnalysis to extract generic code features to Extend InlineFeatureAnalysis to more extract generic code features.
Jun 11 2020, 11:57 PM · Restricted Project
tarinduj created D81716: Extend InlineFeatureAnalysis to more extract generic code features [Obsolete].
Jun 11 2020, 11:57 PM · Restricted Project

Apr 5 2020

tarinduj added a comment to D76871: Expose `attributor-disable` to the new and old pass managers.

Apologies for the delay. LGTM.

Can you provide me with "Firstname Lastname <email>" from you so I can attribute it to you?

Apr 5 2020, 5:19 AM · Restricted Project

Apr 3 2020

tarinduj updated the diff for D76871: Expose `attributor-disable` to the new and old pass managers.

modified the files in test/Other

Apr 3 2020, 7:29 AM · Restricted Project

Mar 26 2020

tarinduj updated the diff for D76871: Expose `attributor-disable` to the new and old pass managers.
Mar 26 2020, 12:29 PM · Restricted Project
tarinduj created D76871: Expose `attributor-disable` to the new and old pass managers.
Mar 26 2020, 11:22 AM · Restricted Project