Page MenuHomePhabricator

[AArch64][SVE] Add DestructiveBinaryImm SQSHLU patterns.
ClosedPublic

Authored by cameron.mcinally on Mar 24 2020, 1:28 PM.

Details

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2020, 1:28 PM

Ping and rebase.

c-rhodes accepted this revision.Apr 16 2020, 9:46 AM

@cameron.mcinally thanks for the patch! Just one minor nit, otherwise LGTM. Is it be worth setting the DestructiveInstType in this patch also given it'll only be a couple of line change?

llvm/test/CodeGen/AArch64/sve2-intrinsics-uniform-dsp-zeroing.ll
15

nit: align args (and below)

This revision is now accepted and ready to land.Apr 16 2020, 9:46 AM
cameron.mcinally marked an inline comment as done.Apr 16 2020, 11:39 AM

@cameron.mcinally thanks for the patch! Just one minor nit, otherwise LGTM. Is it be worth setting the DestructiveInstType in this patch also given it'll only be a couple of line change?

It's already set to DestructiveBinaryImm in the sve_int_bin_pred_shift_imm class.

llvm/lib/Target/AArch64/SVEInstrFormats.td
4752

DestructiveInstType is set here.

This revision was automatically updated to reflect the committed changes.
cameron.mcinally marked an inline comment as done.Apr 16 2020, 12:27 PM