Page MenuHomePhabricator

[analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard
ClosedPublic

Authored by RKSimon on Mar 23 2020, 9:27 AM.

Details

Summary

This was noticed on D71817, which removed another use of OPTIMIZE

Diff Detail

Event Timeline

RKSimon created this revision.Mar 23 2020, 9:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2020, 9:27 AM
Charusso retitled this revision from ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard to [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard.Mar 23 2020, 9:51 AM
Charusso added a reviewer: NoQ.
Charusso accepted this revision.Mar 23 2020, 9:55 AM

Nice catch, thanks! We have some FIXMEs about MSVC sadly and I was thinking about the same change back in the days.

This revision is now accepted and ready to land.Mar 23 2020, 9:55 AM
xbolva00 accepted this revision.Mar 23 2020, 10:09 AM
This revision was automatically updated to reflect the committed changes.
NoQ added a comment.Mar 23 2020, 4:34 PM

Sounds good but eventually i hope we re-enable this assert in release+assert builds (D57062).

In D76622#1938009, @NoQ wrote:

Sounds good but eventually i hope we re-enable this assert in release+assert builds (D57062).

SGTM as long as you don't reintroduce a compiler specific guard