Page MenuHomePhabricator
People ddcc

ddcc (Dominic Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2016, 7:04 PM (314 w, 6 d)

Recent Activity
View All

Apr 28 2022

ddcc committed rGce6bfd102af5: [libc] Support 32-bit ARM platform tests (authored by ddcc).
[libc] Support 32-bit ARM platform tests
Apr 28 2022, 12:01 PM · Restricted Project, Restricted Project
ddcc closed D124204: [libc] Support 32-bit ARM platform tests.
Apr 28 2022, 12:00 PM · Restricted Project, Restricted Project

Apr 27 2022

ddcc updated the diff for D124204: [libc] Support 32-bit ARM platform tests.

Remove unnecessary changes to str_to_float_test.cpp

Apr 27 2022, 5:27 PM · Restricted Project, Restricted Project
ddcc added inline comments to D124204: [libc] Support 32-bit ARM platform tests.
Apr 27 2022, 5:27 PM · Restricted Project, Restricted Project

Apr 26 2022

ddcc added a comment to D124204: [libc] Support 32-bit ARM platform tests.
In D124204#3475478, @michaelrj wrote:

you'll probably also need to add #ifdef conditions to src/__support/CPP/Limits.h and its corresponding test.

Apr 26 2022, 5:25 PM · Restricted Project, Restricted Project
ddcc updated the diff for D124204: [libc] Support 32-bit ARM platform tests.

Add more ifdef coverage

Apr 26 2022, 5:25 PM · Restricted Project, Restricted Project
ddcc committed rG684b1f03e336: Fix [libc] Minor test signedness fixes (authored by ddcc).
Fix [libc] Minor test signedness fixes
Apr 26 2022, 5:15 PM · Restricted Project, Restricted Project
ddcc committed rGde94cf528627: [libc] Minor test signedness fixes (authored by ddcc).
[libc] Minor test signedness fixes
Apr 26 2022, 5:11 PM · Restricted Project, Restricted Project
ddcc closed D124468: [libc] Minor test signedness fixes.
Apr 26 2022, 5:11 PM · Restricted Project, Restricted Project
ddcc requested review of D124468: [libc] Minor test signedness fixes.
Apr 26 2022, 10:27 AM · Restricted Project, Restricted Project
ddcc added a reviewer for D124204: [libc] Support 32-bit ARM platform tests: lntue.
Apr 26 2022, 10:26 AM · Restricted Project, Restricted Project

Apr 21 2022

ddcc committed rGfcbca197f2e6: [scudo] Disable memory tagging on arm64_32 (authored by ddcc).
[scudo] Disable memory tagging on arm64_32
Apr 21 2022, 5:22 PM · Restricted Project, Restricted Project
ddcc closed D124135: [scudo] Disable memory tagging on arm64_32.
Apr 21 2022, 5:22 PM · Restricted Project, Restricted Project
ddcc added a reviewer for D124135: [scudo] Disable memory tagging on arm64_32: eugenis.
Apr 21 2022, 3:24 PM · Restricted Project, Restricted Project
ddcc updated the diff for D124135: [scudo] Disable memory tagging on arm64_32.

Use ILP32 macro

Apr 21 2022, 3:24 PM · Restricted Project, Restricted Project
ddcc committed rGe8572aca0c42: [libc] Use correct mnemonic for arm64_32 architecture (authored by ddcc).
[libc] Use correct mnemonic for arm64_32 architecture
Apr 21 2022, 3:13 PM · Restricted Project, Restricted Project
ddcc closed D124134: [libc] Use correct mnemonic for arm64_32 architecture.
Apr 21 2022, 3:13 PM · Restricted Project, Restricted Project
ddcc requested review of D124204: [libc] Support 32-bit ARM platform tests.
Apr 21 2022, 3:12 PM · Restricted Project, Restricted Project

Apr 20 2022

ddcc requested review of D124135: [scudo] Disable memory tagging on arm64_32.
Apr 20 2022, 5:34 PM · Restricted Project, Restricted Project
ddcc requested review of D124134: [libc] Use correct mnemonic for arm64_32 architecture.
Apr 20 2022, 5:32 PM · Restricted Project, Restricted Project

Apr 7 2022

ddcc added a comment to D122761: [scudo] Enable more warnings for standalone build.

ping

Apr 7 2022, 3:00 PM · Restricted Project, Restricted Project

Mar 30 2022

ddcc requested review of D122761: [scudo] Enable more warnings for standalone build.
Mar 30 2022, 2:27 PM · Restricted Project, Restricted Project
ddcc committed rG5fd0925bc98e: [scudo] Reland: Add noreturn/pragma to suppress compiler warnings (authored by ddcc).
[scudo] Reland: Add noreturn/pragma to suppress compiler warnings
Mar 30 2022, 11:42 AM · Restricted Project, Restricted Project

Mar 29 2022

ddcc added a reverting change for rG686dcbe8b018: [scudo] Add noreturn/pragma to suppress compiler warnings: rG22a95dd3e6c9: Revert "[scudo] Wrap clang pragma to avoid GCC error".
Mar 29 2022, 5:53 PM · Restricted Project, Restricted Project
ddcc added a reverting change for rG030d8262a6e8: [scudo] Wrap clang pragma to avoid GCC error: rG22a95dd3e6c9: Revert "[scudo] Wrap clang pragma to avoid GCC error".
Mar 29 2022, 5:53 PM · Restricted Project, Restricted Project
ddcc committed rG22a95dd3e6c9: Revert "[scudo] Wrap clang pragma to avoid GCC error" (authored by ddcc).
Revert "[scudo] Wrap clang pragma to avoid GCC error"
Mar 29 2022, 5:53 PM · Restricted Project, Restricted Project
ddcc added a comment to D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.

Reverting for now, looks like there's some other build failures.

Mar 29 2022, 5:53 PM · Restricted Project, Restricted Project
ddcc added a reverting change for D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array: rG22a95dd3e6c9: Revert "[scudo] Wrap clang pragma to avoid GCC error".
Mar 29 2022, 5:53 PM · Restricted Project, Restricted Project
ddcc committed rG6ba8c8abe982: [scudo] Provide allocator declaration (authored by ddcc).
[scudo] Provide allocator declaration
Mar 29 2022, 5:40 PM · Restricted Project, Restricted Project
ddcc committed rG030d8262a6e8: [scudo] Wrap clang pragma to avoid GCC error (authored by ddcc).
[scudo] Wrap clang pragma to avoid GCC error
Mar 29 2022, 5:40 PM · Restricted Project, Restricted Project
ddcc closed D121848: [scudo] Provide allocator declaration.
Mar 29 2022, 5:40 PM · Restricted Project, Restricted Project
ddcc retitled D121848: [scudo] Provide allocator declaration from [scudo] Remove unused header includes and fix declarations to [scudo] Provide allocator declaration.
Mar 29 2022, 3:02 PM · Restricted Project, Restricted Project
ddcc updated the diff for D121848: [scudo] Provide allocator declaration.

Move extern declarations to common header

Mar 29 2022, 3:01 PM · Restricted Project, Restricted Project
ddcc committed rG686dcbe8b018: [scudo] Add noreturn/pragma to suppress compiler warnings (authored by ddcc).
[scudo] Add noreturn/pragma to suppress compiler warnings
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc committed rGdb13f5a1b01e: [scudo] Add missing include for extern variable declaration (authored by ddcc).
[scudo] Add missing include for extern variable declaration
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc committed rGd0eeb0fba09f: [scudo] Fix definition of canCache() function (authored by ddcc).
[scudo] Fix definition of canCache() function
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc committed rG92897217fa14: [scudo] Initialize local variable to avoid compiler warning (authored by ddcc).
[scudo] Initialize local variable to avoid compiler warning
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc closed D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc closed D122630: [scudo] Add missing include for extern variable declaration.
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc closed D122631: [scudo] Fix definition of canCache() function.
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc closed D122632: [scudo] Initialize local variable to avoid compiler warning.
Mar 29 2022, 2:26 PM · Restricted Project, Restricted Project
ddcc added a comment to D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.
In D121853#3414960, @vitalybuka wrote:

BTW, I suspect your fixes are going to regress with the time.
Would you like to update scudo_standalone cmake files so buildbots check these warnings?

Mar 29 2022, 2:22 PM · Restricted Project, Restricted Project

Mar 28 2022

ddcc added inline comments to D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.
Mar 28 2022, 10:07 PM · Restricted Project, Restricted Project
ddcc updated the diff for D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.

Add noreturn attribute

Mar 28 2022, 10:02 PM · Restricted Project, Restricted Project
ddcc requested review of D122632: [scudo] Initialize local variable to avoid compiler warning.
Mar 28 2022, 9:56 PM · Restricted Project, Restricted Project
ddcc added inline comments to D121848: [scudo] Provide allocator declaration.
Mar 28 2022, 9:53 PM · Restricted Project, Restricted Project
ddcc requested review of D122631: [scudo] Fix definition of canCache() function.
Mar 28 2022, 9:53 PM · Restricted Project, Restricted Project
ddcc requested review of D122630: [scudo] Add missing include for extern variable declaration.
Mar 28 2022, 9:51 PM · Restricted Project, Restricted Project
ddcc committed rG0e1d2007aa3c: [scudo] Use template specialization on Quarantine to avoid zero-length array (authored by ddcc).
[scudo] Use template specialization on Quarantine to avoid zero-length array
Mar 28 2022, 9:36 PM · Restricted Project, Restricted Project
ddcc closed D122518: [scudo] Use template specialization on Quarantine to avoid zero-length array.
Mar 28 2022, 9:36 PM · Restricted Project, Restricted Project
ddcc updated the diff for D122518: [scudo] Use template specialization on Quarantine to avoid zero-length array.

Add another template argument to avoid exposing private struct

Mar 28 2022, 7:22 PM · Restricted Project, Restricted Project
ddcc updated the diff for D122518: [scudo] Use template specialization on Quarantine to avoid zero-length array.

Move definitions out of class

Mar 28 2022, 7:11 PM · Restricted Project, Restricted Project
ddcc added a reverting change for rG7dda44c189d7: [scudo] Use template specialization on Quarantine to avoid zero-length array: rGa52868a55c45: Revert "[scudo] Use template specialization on Quarantine to avoid zero-length….
Mar 28 2022, 7:09 PM · Restricted Project, Restricted Project
ddcc committed rGa52868a55c45: Revert "[scudo] Use template specialization on Quarantine to avoid zero-length… (authored by ddcc).
Revert "[scudo] Use template specialization on Quarantine to avoid zero-length…
Mar 28 2022, 7:09 PM · Restricted Project, Restricted Project
ddcc added a reverting change for D122518: [scudo] Use template specialization on Quarantine to avoid zero-length array: rGa52868a55c45: Revert "[scudo] Use template specialization on Quarantine to avoid zero-length….
Mar 28 2022, 7:09 PM · Restricted Project, Restricted Project
ddcc committed rG9343fc76133b: [scudo] Use cast on calls to __builtin_umul_overflow/__builtin_umull_overflow (authored by ddcc).
[scudo] Use cast on calls to __builtin_umul_overflow/__builtin_umull_overflow
Mar 28 2022, 4:37 PM · Restricted Project, Restricted Project
ddcc committed rG7dda44c189d7: [scudo] Use template specialization on Quarantine to avoid zero-length array (authored by ddcc).
[scudo] Use template specialization on Quarantine to avoid zero-length array
Mar 28 2022, 4:36 PM · Restricted Project, Restricted Project
ddcc closed D121852: [scudo] Use templated builtins to avoid assumptions on SCUDO_WORDSIZE.
Mar 28 2022, 4:36 PM · Restricted Project, Restricted Project
ddcc closed D122518: [scudo] Use template specialization on Quarantine to avoid zero-length array.
Mar 28 2022, 4:36 PM · Restricted Project, Restricted Project

Mar 25 2022

ddcc abandoned D121851: [scudo][tests] Ensure test assertions have matching type.
Mar 25 2022, 4:54 PM · Restricted Project, Restricted Project
ddcc added a comment to D121851: [scudo][tests] Ensure test assertions have matching type.

Hmmm yeah this is pretty ugly, I'll look into changing the test matcher template instead.

Mar 25 2022, 4:54 PM · Restricted Project, Restricted Project
ddcc added inline comments to D121848: [scudo] Provide allocator declaration.
Mar 25 2022, 4:50 PM · Restricted Project, Restricted Project
ddcc requested review of D122518: [scudo] Use template specialization on Quarantine to avoid zero-length array.
Mar 25 2022, 4:45 PM · Restricted Project, Restricted Project
ddcc updated the diff for D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.

Initialize HeaderPos, drop Quarantine changes

Mar 25 2022, 4:43 PM · Restricted Project, Restricted Project
ddcc added inline comments to D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.
Mar 25 2022, 4:42 PM · Restricted Project, Restricted Project
ddcc updated the diff for D121852: [scudo] Use templated builtins to avoid assumptions on SCUDO_WORDSIZE.

Use cast instead of template

Mar 25 2022, 4:06 PM · Restricted Project, Restricted Project

Mar 18 2022

ddcc added inline comments to D121848: [scudo] Provide allocator declaration.
Mar 18 2022, 12:58 PM · Restricted Project, Restricted Project
ddcc updated the diff for D121848: [scudo] Provide allocator declaration.

Revert header file removal

Mar 18 2022, 12:57 PM · Restricted Project, Restricted Project
ddcc committed rG58a583c22958: [scudo] Fix static and unused function type annotations (authored by ddcc).
[scudo] Fix static and unused function type annotations
Mar 18 2022, 12:54 PM · Restricted Project
ddcc committed rG26a5f9bd0302: [scudo] Don't assume preprocessor macro is defined (authored by ddcc).
[scudo] Don't assume preprocessor macro is defined
Mar 18 2022, 12:54 PM · Restricted Project
ddcc closed D121855: [scudo] Fix static and unused function type annotations.
Mar 18 2022, 12:54 PM · Restricted Project, Restricted Project
ddcc closed D121857: [scudo] Don't assume preprocessor macro is defined.
Mar 18 2022, 12:54 PM · Restricted Project, Restricted Project
ddcc abandoned D121849: [scudo][NFC] Rename local variables to avoid shadowing class members.

Ok, we can workaround this locally.

Mar 18 2022, 12:53 PM · Restricted Project, Restricted Project
ddcc added a comment to D121851: [scudo][tests] Ensure test assertions have matching type.

@vitalybuka ping

Mar 18 2022, 12:53 PM · Restricted Project, Restricted Project
ddcc added a comment to D121852: [scudo] Use templated builtins to avoid assumptions on SCUDO_WORDSIZE.

@vitalybuka ping

Mar 18 2022, 12:53 PM · Restricted Project, Restricted Project
ddcc added a comment to D121853: [scudo][NFC] Suppress warnings for missing-noreturn, conditional-uninitialized, zero-length-array.

@vitalybuka ping

Mar 18 2022, 12:53 PM · Restricted Project, Restricted Project

Mar 17 2022

ddcc committed rG58b6521eb5a0: [scudo] Use portable sysconf instead of deprecated getpagesize (authored by ddcc).
[scudo] Use portable sysconf instead of deprecated getpagesize
Mar 17 2022, 11:03 AM · Restricted Project
ddcc closed D121859: [scudo] Use portable sysconf instead of deprecated getpagesize.
Mar 17 2022, 11:02 AM · Restricted Project, Restricted Project
ddcc updated the diff for D121848: [scudo] Provide allocator declaration.

Fix extern declaration of SCUDO_ALLOCATOR

Mar 17 2022, 10:58 AM · Restricted Project, Restricted Project
ddcc added a comment to D121848: [scudo] Provide allocator declaration.

Do you split want the non-#include changes split out?

Mar 17 2022, 10:55 AM · Restricted Project, Restricted Project
ddcc added a comment to D121849: [scudo][NFC] Rename local variables to avoid shadowing class members.

That's fair, we're building the standalone version out-of-tree with -Weverything -Werror among other things in our build system, which is why I've been seeing more warnings. Not sure if anything needs to be done then for the in-tree standalone build, since -Wall isn't documented to include -Wshadow?

Mar 17 2022, 10:39 AM · Restricted Project, Restricted Project
ddcc updated the diff for D121855: [scudo] Fix static and unused function type annotations.

Remove unneeded static

Mar 17 2022, 10:35 AM · Restricted Project, Restricted Project
ddcc added inline comments to D121857: [scudo] Don't assume preprocessor macro is defined.
Mar 17 2022, 10:21 AM · Restricted Project, Restricted Project
ddcc added a comment to D121859: [scudo] Use portable sysconf instead of deprecated getpagesize.

It seems to be implemented, does that look right? https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/src/conf/sysconf.c;l=56?q=sysconf&ss=fuchsia%2Ffuchsia

Mar 17 2022, 10:19 AM · Restricted Project, Restricted Project
ddcc committed rG6ce08d5c2786: [scudo][tests] Pass read-only vector by reference (authored by ddcc).
[scudo][tests] Pass read-only vector by reference
Mar 17 2022, 10:18 AM · Restricted Project
ddcc committed rG03e82d94fcbe: [scudo] Fix test harness integration (authored by ddcc).
[scudo] Fix test harness integration
Mar 17 2022, 10:18 AM · Restricted Project
ddcc committed rG7abd6837a0a0: [scudo] Use nullptr instead of integer-to-pointer cast (authored by ddcc).
[scudo] Use nullptr instead of integer-to-pointer cast
Mar 17 2022, 10:18 AM · Restricted Project
ddcc committed rG4787e5c34ec8: [scudo] Don't unmap other low memory pages if mapping doesn't exist (authored by ddcc).
[scudo] Don't unmap other low memory pages if mapping doesn't exist
Mar 17 2022, 10:18 AM · Restricted Project
ddcc committed rGe53641927918: [scudo] Explicitly mark enum as unsigned (authored by ddcc).
[scudo] Explicitly mark enum as unsigned
Mar 17 2022, 10:18 AM · Restricted Project
ddcc closed D121850: [scudo][tests] Pass read-only vector by reference.
Mar 17 2022, 10:18 AM · Restricted Project, Restricted Project
ddcc closed D121854: [scudo] Fix test harness integration.
Mar 17 2022, 10:18 AM · Restricted Project, Restricted Project
ddcc committed rGa6b7f3189578: [scudo] Remove unused vector value initializer (authored by ddcc).
[scudo] Remove unused vector value initializer
Mar 17 2022, 10:18 AM · Restricted Project
ddcc closed D121856: [scudo] Use nullptr instead of integer-to-pointer cast.
Mar 17 2022, 10:18 AM · Restricted Project, Restricted Project
ddcc closed D121858: [scudo] Don't unmap other low memory pages if mapping doesn't exist.
Mar 17 2022, 10:17 AM · Restricted Project, Restricted Project
ddcc closed D121860: [scudo] Explicitly mark enum as unsigned.
Mar 17 2022, 10:17 AM · Restricted Project, Restricted Project
ddcc closed D121861: [scudo] Remove unused vector value initializer.
Mar 17 2022, 10:17 AM · Restricted Project, Restricted Project

Mar 16 2022

ddcc abandoned D121772: [scudo] Fix various compiler warnings, minor bugs, remove unused header files.

Ok, I've split this up and will close it.

Mar 16 2022, 2:18 PM · Restricted Project, Restricted Project
ddcc requested review of D121861: [scudo] Remove unused vector value initializer.
Mar 16 2022, 2:17 PM · Restricted Project, Restricted Project
ddcc requested review of D121860: [scudo] Explicitly mark enum as unsigned.
Mar 16 2022, 2:16 PM · Restricted Project, Restricted Project
ddcc requested review of D121859: [scudo] Use portable sysconf instead of deprecated getpagesize.
Mar 16 2022, 2:15 PM · Restricted Project, Restricted Project