Page MenuHomePhabricator

ddcc (Dominic Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2016, 7:04 PM (228 w, 3 h)

Recent Activity

Wed, Oct 7

ddcc committed rGc10248829357: Add test for disabling Dead Virtual Function Elimination (authored by ddcc).
Add test for disabling Dead Virtual Function Elimination
Wed, Oct 7, 4:43 PM
ddcc closed D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination.
Wed, Oct 7, 4:43 PM · Restricted Project
ddcc added a comment to D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination.

Hmm, looks like this was already fixed by e5158b52730d323bb8cd2cba6dc6c89b90cba452. I guess I'll just commit the test then?

Wed, Oct 7, 4:18 PM · Restricted Project
ddcc updated the diff for D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination.

Update tests

Wed, Oct 7, 4:18 PM · Restricted Project
ddcc updated the diff for D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination.

Add test

Wed, Oct 7, 1:23 PM · Restricted Project

Mon, Oct 5

ddcc added a comment to D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination.

ping

Mon, Oct 5, 1:37 PM · Restricted Project
ddcc added a comment to D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

ping

Mon, Oct 5, 1:37 PM · Restricted Project

Sep 28 2020

ddcc committed rG06e68f05dafb: [AddressSanitizer] Copy type metadata to prevent miscompilation (authored by ddcc).
[AddressSanitizer] Copy type metadata to prevent miscompilation
Sep 28 2020, 10:57 AM
ddcc closed D88368: [AddressSanitizer] Copy type metadata to prevent miscompilation.
Sep 28 2020, 10:57 AM · Restricted Project
ddcc added inline comments to D88368: [AddressSanitizer] Copy type metadata to prevent miscompilation.
Sep 28 2020, 10:54 AM · Restricted Project

Sep 26 2020

ddcc updated the diff for D88368: [AddressSanitizer] Copy type metadata to prevent miscompilation.

Fix optional regex

Sep 26 2020, 4:02 PM · Restricted Project
ddcc requested review of D88368: [AddressSanitizer] Copy type metadata to prevent miscompilation.
Sep 26 2020, 3:55 PM · Restricted Project

Sep 25 2020

ddcc requested review of D88349: Fix inconsistent flag for disabling Dead Virtual Function Elimination.
Sep 25 2020, 6:50 PM · Restricted Project

Sep 21 2020

ddcc added a comment to D87407: [WebAssembly][MC] Fix computation of relative symbol offset.

Landed, mind looking at https://reviews.llvm.org/D87258#2267267 when you get the time?

Sep 21 2020, 9:55 PM · Restricted Project
ddcc committed rG9c7b58080ebd: [WebAssembly][MC] Fix computation of relative symbol offset (authored by ddcc).
[WebAssembly][MC] Fix computation of relative symbol offset
Sep 21 2020, 9:54 PM
ddcc closed D87407: [WebAssembly][MC] Fix computation of relative symbol offset.
Sep 21 2020, 9:53 PM · Restricted Project
ddcc added inline comments to D87407: [WebAssembly][MC] Fix computation of relative symbol offset.
Sep 21 2020, 9:42 PM · Restricted Project
ddcc updated the diff for D87407: [WebAssembly][MC] Fix computation of relative symbol offset.

Check relocation output

Sep 21 2020, 9:42 PM · Restricted Project
ddcc added a comment to D87407: [WebAssembly][MC] Fix computation of relative symbol offset.

Is this essentially a fix for the work that was started in https://reviews.llvm.org/D79462 ?

Sep 21 2020, 8:47 PM · Restricted Project
ddcc updated the diff for D87407: [WebAssembly][MC] Fix computation of relative symbol offset.

Merge tests

Sep 21 2020, 8:47 PM · Restricted Project

Sep 10 2020

ddcc added a comment to D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

So is the idea that the table indexes would be reserved also by the linker?

Right now wasm-ld completely ignores the table elements in the object files and generates contiguous table entries when if finds TABLE_INDEX relocations.

Ah, so under LTO, the output from WasmObjectWriter is linked by lld with libc, etc, which writes the final output? I was hoping to avoid changing the object format to explicitly assign table element indices, since that would involve amending the specification, by just emitting the table elements in the correct order. Would it be sufficient to have WasmObjectWriter::recordRelocation also ensure that TABLE_INDEX relocations are inserted into CodeRelocations in the correct assigned order? Right now I only push them to the front of CodeRelocations to avoid conflicts when assigning indices with subsequent elements.

Sep 10 2020, 10:31 PM · Restricted Project
ddcc updated the diff for D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

Switch to absolute_symbol metadata, which is undroppable, instead of wasm.index

Sep 10 2020, 10:25 PM · Restricted Project
ddcc committed rG4252f3009b16: [WebAssembly] Set unreachable as canonical to permit disassembly (authored by ddcc).
[WebAssembly] Set unreachable as canonical to permit disassembly
Sep 10 2020, 12:08 PM
ddcc closed D87431: [WebAssembly] Set unreachable as canonical to permit disassembly.
Sep 10 2020, 12:08 PM · Restricted Project

Sep 9 2020

ddcc requested review of D87431: [WebAssembly] Set unreachable as canonical to permit disassembly.
Sep 9 2020, 10:06 PM · Restricted Project
ddcc updated the diff for D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

Fix undefined arithmetic range ops in LowerTypeTests, split WebAssembly relative symbol bugfix into D87407

Sep 9 2020, 6:56 PM · Restricted Project
ddcc added inline comments to D87407: [WebAssembly][MC] Fix computation of relative symbol offset.
Sep 9 2020, 12:07 PM · Restricted Project
ddcc requested review of D87407: [WebAssembly][MC] Fix computation of relative symbol offset.
Sep 9 2020, 12:06 PM · Restricted Project

Sep 8 2020

ddcc added a comment to D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

Currently, I am seeing some false positive CFI failures that only occur with WebAssembly and not native, so I still need to look into what's causing that.

Sep 8 2020, 6:03 PM · Restricted Project
ddcc added a comment to D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

One thing that's happened since you did all of this originally is multiple-table support; the reference-types proposal includes multiple tables, has been standardized, and will soon be (or is already?) available in all the browsers. IIRC you originally did both a version with and without multiple-tables, but I forget how much of that was in s2wasm vs in LLVM. IMO we should just make CFI require multiple tables, and then we can dedicate as many tables for whatever purposes we like.
I assume that we'll still need the core functionality of this CL, which is having the table layout be determined at IPO time rather than being assigned by the objectWriter/linker?

Can you remind me of what the state was for multiple-table support when you originally wrote all this?

Sep 8 2020, 12:06 PM · Restricted Project

Sep 7 2020

ddcc updated the diff for D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

Fix Twine issue

Sep 7 2020, 7:03 PM · Restricted Project
ddcc added inline comments to D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.
Sep 7 2020, 5:35 PM · Restricted Project
ddcc requested review of D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.
Sep 7 2020, 5:32 PM · Restricted Project

Jul 10 2020

ddcc added a comment to D83558: [analyzer] Use %clang_cc1 instead of %clang_analyze_cc1 if the test requires a specific constraint manager.

The original intention was to have tests run with both constraint managers, unless Z3 was required, in which case it would be Z3 only, but AFAIK that testing infrastructure was never set up. This was before Z3 got merged into LLVM proper, so the additional USE_Z3_SOLVER was to prevent bots from failing if Z3 wasn't installed. Given that all of this should be unused, if there's interest in setting up test bots for the SMT constraint manager, it should be fine to change any of this as needed.

Jul 10 2020, 10:18 AM

May 21 2020

ddcc added a comment to D80319: [LICM] Allow movement of non-aliasing calls that at most only write to memory.

Thanks for mentioning it; yeah, I think restrict support would be useful for functions that do access arguments, but it wouldn't cover aliasing in the second case between external functions with attributes that don't access arguments.

May 21 2020, 9:05 PM · Restricted Project
ddcc committed rGabf02d978854: [llvm-extract] Fix basic block extraction by delaying search until the function… (authored by ddcc).
[llvm-extract] Fix basic block extraction by delaying search until the function…
May 21 2020, 6:26 PM
ddcc closed D80346: [llvm-extract] Fix basic block extraction by delaying search until the function is materialized.
May 21 2020, 6:25 PM · Restricted Project
ddcc added a comment to D80346: [llvm-extract] Fix basic block extraction by delaying search until the function is materialized.

Sure, I will add some comments and push. Thanks!

May 21 2020, 6:25 PM · Restricted Project
ddcc added a comment to D80319: [LICM] Allow movement of non-aliasing calls that at most only write to memory.

Thanks for the feedback!

May 21 2020, 6:25 PM · Restricted Project
ddcc committed rG31984063678e: llvm-diff: Avoid crash with complex expressions (authored by ddcc).
llvm-diff: Avoid crash with complex expressions
May 21 2020, 3:13 PM
ddcc closed D80351: llvm-diff: Avoid crash with complex expressions.
May 21 2020, 3:13 PM · Restricted Project

May 20 2020

ddcc retitled D80319: [LICM] Allow movement of non-aliasing calls that at most only write to memory from [LICM] Allow movement of calls that at most only write to memory to [LICM] Allow movement of non-aliasing calls that at most only write to memory.
May 20 2020, 11:06 PM · Restricted Project
ddcc updated the diff for D80319: [LICM] Allow movement of non-aliasing calls that at most only write to memory.

Drop ineffective loop aliasing check

May 20 2020, 11:05 PM · Restricted Project
ddcc added a comment to D80319: [LICM] Allow movement of non-aliasing calls that at most only write to memory.

The idea does not seem right. If a call can only write and not read, it cannot necessarily be moved.

Your test2() example looks incorrect. If foo2b writes to str and foo2c reads from it and writes to it, then foo2c should read the value written inside the loop, which can be overwritten on different iterations.

Example:

  • foo2b writes value 2 to str.
  • foo2c reads value from str, increments by 1 and writes back.
  • loop runs 3 times.

With foo2b inside the loop, final value in str is 3.
With foo2b outside the loop, final value in str is 5.

May 20 2020, 10:33 PM · Restricted Project
ddcc updated the diff for D80319: [LICM] Allow movement of non-aliasing calls that at most only write to memory.

Check aliasing on arguments, update tests

May 20 2020, 10:33 PM · Restricted Project
ddcc created D80351: llvm-diff: Avoid crash with complex expressions.
May 20 2020, 6:48 PM · Restricted Project
ddcc added a comment to D80351: llvm-diff: Avoid crash with complex expressions.

I can trigger the runtime crash when comparing the _ZN13LaplaceSolver6SolverILi3EE22assemble_linear_systemERNS1_12LinearSystemE function from the SPEC2006 benchmark 447.dealII, but unfortunately even with llvm-extract, I haven't been able to generate a simple testcase for this.

May 20 2020, 6:48 PM · Restricted Project
ddcc created D80346: [llvm-extract] Fix basic block extraction by delaying search until the function is materialized.
May 20 2020, 5:40 PM · Restricted Project
ddcc added a comment to D80227: Fix FindZ3.cmake to work with static Z3 libraries.

I'm not entirely convinced that it's a race, but a separate file seems fine. Have you tested with e.g. LLVM_OPTIMIZED_TABLEGEN? It might be safer to use LLVM_MAIN_SRC_DIR instead of CMAKE_SOURCE_DIR.

May 20 2020, 2:18 PM · Restricted Project, Restricted Project
ddcc added a reviewer for D80227: Fix FindZ3.cmake to work with static Z3 libraries: NoQ.
May 20 2020, 2:18 PM · Restricted Project, Restricted Project
ddcc added a comment to D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

ping

May 20 2020, 2:18 PM · Restricted Project
ddcc created D80319: [LICM] Allow movement of non-aliasing calls that at most only write to memory.
May 20 2020, 2:18 PM · Restricted Project

May 19 2020

ddcc added a comment to D80227: Fix FindZ3.cmake to work with static Z3 libraries.

I'm not too familiar with this part of CMake, but this mechanism is how CMake themselves implement C++ compilation and testing: https://github.com/Kitware/CMake/blob/master/Modules/CheckCXXSourceRuns.cmake . In fact, this code does include CheckCXXSourceRuns, but seems to reimplement most of the internals. Perhaps @esteffin would know more?

May 19 2020, 2:53 PM · Restricted Project, Restricted Project
ddcc updated subscribers of D80227: Fix FindZ3.cmake to work with static Z3 libraries.
May 19 2020, 2:53 PM · Restricted Project, Restricted Project

May 17 2020

ddcc added reviewers for D77704: [gold] Add support for loading pass plugins: efriedma, tmsriram.
May 17 2020, 5:02 PM · Restricted Project, Restricted Project
ddcc added a comment to D77704: [gold] Add support for loading pass plugins.

ping, any feedback?

May 17 2020, 5:02 PM · Restricted Project, Restricted Project

Apr 24 2020

ddcc added a comment to D77704: [gold] Add support for loading pass plugins.

In order to reload the gold plugin, I'm modifying the Clang driver to pass in our own path as a separate argument, which is the most generic approach. Another method would be to use e.g. dladdr() to grab our own path from one of our exported functions, but that method appears to be a glibc extension which isn't cross-platform.

Apr 24 2020, 2:05 PM · Restricted Project, Restricted Project
ddcc added a comment to D77704: [gold] Add support for loading pass plugins.

Thanks, seems to be working now for statically-built passes on a default LLVM build without LLVM_LINK_LLVM_DYLIB.

Apr 24 2020, 2:05 PM · Restricted Project, Restricted Project
ddcc updated the diff for D77704: [gold] Add support for loading pass plugins.

Support statically-built passes

Apr 24 2020, 2:05 PM · Restricted Project, Restricted Project

Apr 19 2020

ddcc added inline comments to D78453: [llvm][Z3][NFC] Improve mkBitvector performance.
Apr 19 2020, 3:29 PM · Restricted Project

Apr 16 2020

ddcc added inline comments to D77704: [gold] Add support for loading pass plugins.
Apr 16 2020, 7:29 PM · Restricted Project, Restricted Project

Apr 15 2020

ddcc added inline comments to D77704: [gold] Add support for loading pass plugins.
Apr 15 2020, 4:34 PM · Restricted Project, Restricted Project

Apr 14 2020

ddcc retitled D77704: [gold] Add support for loading pass plugins from [LTO][gold] Add support for loading pass plugins to [gold] Add support for loading pass plugins.
Apr 14 2020, 11:22 PM · Restricted Project, Restricted Project
ddcc updated the diff for D77704: [gold] Add support for loading pass plugins.

Rebase

Apr 14 2020, 10:50 PM · Restricted Project, Restricted Project
ddcc added a comment to D77704: [gold] Add support for loading pass plugins.

Here's the updated patch, though it still only works when LLVM is built with LLVM_LINK_LLVM_DYLIB=ON. Otherwise, with or without the LLVM_EXPORTED_SYMBOL_FILE definition, I get the following error with a static build:

Apr 14 2020, 10:50 PM · Restricted Project, Restricted Project

Apr 13 2020

ddcc added a comment to D77704: [gold] Add support for loading pass plugins.

It looks like this overlaps with https://reviews.llvm.org/D76866 ; maybe wait for that to merge, then we can handle the gold-specific changes as a followup.

(Probably you need export_executable_symbols_for_plugins to fix the missing symbol issues.)

Apr 13 2020, 12:25 PM · Restricted Project, Restricted Project
ddcc added a comment to D77704: [gold] Add support for loading pass plugins.

Alright, is it feasible to add small tests or provide instructions on how you would load an example pass?

Apr 13 2020, 10:44 AM · Restricted Project, Restricted Project

Apr 8 2020

ddcc added a comment to D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

ping

Apr 8 2020, 11:25 PM · Restricted Project
ddcc added a comment to D77705: [Driver] Forward pass plugin arguments to gold.

Originally, I tried forwarding the -Xclang -load arguments, but couldn't access the options::OPT_plugin arguments from the argument list. I'm not familiar with tablegen and argument processing, there was some issue with the group not being available causing the arguments to be skipped when filtering the argument list, so I ended up reusing the OPT_fplugin and OPT_fpass_plugin arguments instead. As far as I can tell, OPT_fplugin seems to work for both Clang and LLVM plugins, but I haven't used the former.

Apr 8 2020, 11:25 PM · Restricted Project
ddcc updated the summary of D77704: [gold] Add support for loading pass plugins.
Apr 8 2020, 11:12 PM · Restricted Project, Restricted Project
ddcc added a comment to D77704: [gold] Add support for loading pass plugins.

Sure. I've written some local optimizations in a loadable pass that uses one of the LTO extension points, EP_FullLinkTimeOptimizationEarly, but it seems that there's no way to actually load out-of-tree LTO passes into gold. This patch fixes that by modifying the gold plugin to support two additional arguments for loading external passes with the old/new pass manager, though I've only tested it with my local legacy pass.

Apr 8 2020, 11:12 PM · Restricted Project, Restricted Project

Apr 7 2020

ddcc created D77705: [Driver] Forward pass plugin arguments to gold.
Apr 7 2020, 9:45 PM · Restricted Project
ddcc created D77704: [gold] Add support for loading pass plugins.
Apr 7 2020, 9:45 PM · Restricted Project, Restricted Project

Mar 31 2020

ddcc updated subscribers of D77154: [cmake] Add LLVM_USE_GDB_INDEX option for gold/lld linkers.

The same patch posted previously, https://reviews.llvm.org/D58628

Mar 31 2020, 3:27 PM · Restricted Project
ddcc added a comment to D77154: [cmake] Add LLVM_USE_GDB_INDEX option for gold/lld linkers.

Some people don't use -DLLVM_USE_LINKER=lld, but use -DLLVM_ENABLE_LLD=On.

Mar 31 2020, 2:52 PM · Restricted Project
ddcc retitled D77154: [cmake] Add LLVM_USE_GDB_INDEX option for gold/lld linkers from [cmake] Add LLVM_USE_GDB_INDEX option for gold linker to [cmake] Add LLVM_USE_GDB_INDEX option for gold/lld linkers.
Mar 31 2020, 12:00 PM · Restricted Project
ddcc created D77154: [cmake] Add LLVM_USE_GDB_INDEX option for gold/lld linkers.
Mar 31 2020, 11:26 AM · Restricted Project

Mar 30 2020

ddcc updated the diff for D76965: [FunctionAttrs][Mem2Reg] Handle Alloca passed as function call operand with function attributes.

Update tests with update_test_checks.py, fix bug

Mar 30 2020, 1:04 PM · Restricted Project
ddcc updated the diff for D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Update tests with update_test_checks.py

Mar 30 2020, 1:04 PM · Restricted Project
ddcc added a comment to D76965: [FunctionAttrs][Mem2Reg] Handle Alloca passed as function call operand with function attributes.

I'm unsure about the scope of this. It seems to match a particular pattern and it is unclear this is the right place to do so. Have you considered doing this as part of AAPrivatizablePtr (or a new AbstractAttribute) in the Attributor?

Mar 30 2020, 1:04 PM · Restricted Project

Mar 28 2020

ddcc updated the diff for D76965: [FunctionAttrs][Mem2Reg] Handle Alloca passed as function call operand with function attributes.

Add more tests, fix bugs

Mar 28 2020, 10:32 PM · Restricted Project
ddcc added a comment to D76966: [GlobalOpt/GlobalStatus][Mem2Reg] Handle PtrToInt passed as function call operand.

I'm not sure yet if I'll need to support ptrtoint; I haven't rebuilt my benchmarks with the parent changes to see if optimizations are being inhibited. But I am more inclined to avoid it if possible since I'll need to refactor and call the code to infer pointer capture.

Mar 28 2020, 4:08 PM · Restricted Project
ddcc updated the diff for D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Remove unneeded store code

Mar 28 2020, 4:08 PM · Restricted Project
ddcc added a comment to D76965: [FunctionAttrs][Mem2Reg] Handle Alloca passed as function call operand with function attributes.

Hmm, yeah, undef is probably too strong. Ok, how about I replace the argument with a fresh alloca? It should still permit load/store optimizations on the original alloca, while still providing some alloca that isn't accessed.

Mar 28 2020, 4:08 PM · Restricted Project
ddcc updated the diff for D76965: [FunctionAttrs][Mem2Reg] Handle Alloca passed as function call operand with function attributes.

Create fresh alloca instead of undefvalue

Mar 28 2020, 4:08 PM · Restricted Project
ddcc updated the diff for D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Fix load type and store

Mar 28 2020, 3:36 PM · Restricted Project
ddcc added a comment to D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Thanks for the feedback, I've sent you an email.

Mar 28 2020, 3:36 PM · Restricted Project

Mar 27 2020

ddcc added a comment to D76966: [GlobalOpt/GlobalStatus][Mem2Reg] Handle PtrToInt passed as function call operand.

I'm not quite sure what the intended semantics for inaccessiblememonly and readnone are here. If a pointer operand is converted to an integer and passed as an argument to a function call, when can that pointer be optimized out? Does that function need to have either attribute, or does it not matter that an integer argument is casted from a pointer? This patch currently assumes that the attribute must still be present on the function (since it can't be set on a non-pointer argument).

Mar 27 2020, 7:17 PM · Restricted Project
ddcc created D76966: [GlobalOpt/GlobalStatus][Mem2Reg] Handle PtrToInt passed as function call operand.
Mar 27 2020, 7:17 PM · Restricted Project
ddcc created D76965: [FunctionAttrs][Mem2Reg] Handle Alloca passed as function call operand with function attributes.
Mar 27 2020, 6:46 PM · Restricted Project
ddcc updated the diff for D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Fix test failures

Mar 27 2020, 1:43 PM · Restricted Project
ddcc added a comment to D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Sure, I'm working on a instrumentation pass which is inserting calls that inhibit optimization, so I'm trying to work around the issue using function attributes, and need to look into memory to register promotion next.

Mar 27 2020, 1:10 PM · Restricted Project
ddcc updated the diff for D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Revise based on feedback

Mar 27 2020, 1:10 PM · Restricted Project

Mar 26 2020

ddcc added a reviewer for D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes: jdoerfert.
Mar 26 2020, 8:40 PM · Restricted Project
ddcc updated the diff for D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.

Remove explicit std::make_pair

Mar 26 2020, 8:40 PM · Restricted Project
ddcc created D76894: [GlobalOpt/GlobalStatus] Handle GlobalVariables passed as function call operands with access attributes.
Mar 26 2020, 4:52 PM · Restricted Project

Jan 31 2020

ddcc committed rG562a19e079d5: [Typo fix] RNG: Take pass name as argument instead of pass pointer. (authored by ddcc).
[Typo fix] RNG: Take pass name as argument instead of pass pointer.
Jan 31 2020, 11:41 AM
ddcc committed rG73713f3e5ef2: RNG: Take pass name as argument instead of pass pointer. (authored by ddcc).
RNG: Take pass name as argument instead of pass pointer.
Jan 31 2020, 11:22 AM
ddcc closed D73390: RNG: Take pass name as argument instead of pass pointer..
Jan 31 2020, 11:22 AM · Restricted Project
ddcc added a comment to D73390: RNG: Take pass name as argument instead of pass pointer..

ping

Jan 31 2020, 8:10 AM · Restricted Project