Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People ddcc

ddcc (Dominic Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2016, 7:04 PM (379 w, 2 d)

Recent Activity
View All

Tue, Sep 5

ddcc added a comment to D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.

I don't have the time right now, feel free to take it over.

Tue, Sep 5, 12:18 AM · Restricted Project, Restricted Project

Jul 12 2023

ddcc committed rG50414422ac15: [libc][math] Fix floating-point test support on x86_64 Apple machines (authored by ddcc).
[libc][math] Fix floating-point test support on x86_64 Apple machines
Jul 12 2023, 12:39 AM · Restricted Project, Restricted Project
ddcc closed D153823: [libc][math] Fix floating-point test support on x86_64 Apple machines.
Jul 12 2023, 12:38 AM · Restricted Project, Restricted Project

Jun 30 2023

ddcc added inline comments to D153823: [libc][math] Fix floating-point test support on x86_64 Apple machines.
Jun 30 2023, 7:55 PM · Restricted Project, Restricted Project
ddcc added inline comments to D153823: [libc][math] Fix floating-point test support on x86_64 Apple machines.
Jun 30 2023, 12:56 AM · Restricted Project, Restricted Project

Jun 26 2023

ddcc added inline comments to D153823: [libc][math] Fix floating-point test support on x86_64 Apple machines.
Jun 26 2023, 8:12 PM · Restricted Project, Restricted Project
ddcc updated the diff for D153823: [libc][math] Fix floating-point test support on x86_64 Apple machines.

Combine ifdef section

Jun 26 2023, 6:49 PM · Restricted Project, Restricted Project
ddcc requested review of D153823: [libc][math] Fix floating-point test support on x86_64 Apple machines.
Jun 26 2023, 5:20 PM · Restricted Project, Restricted Project

Dec 14 2022

ddcc committed rG3d3bc72c0454: [scudo] Reland: Fix and enable more warnings for standalone build (authored by ddcc).
[scudo] Reland: Fix and enable more warnings for standalone build
Dec 14 2022, 10:30 AM · Restricted Project, Restricted Project
ddcc closed D122761: [scudo] Enable more warnings for standalone build.
Dec 14 2022, 10:30 AM · Restricted Project, Restricted Project

Dec 12 2022

ddcc added a comment to D122761: [scudo] Enable more warnings for standalone build.

Ran a local build and this should be the only fix needed, will see what the CI results say

Dec 12 2022, 5:38 PM · Restricted Project, Restricted Project
ddcc updated the diff for D122761: [scudo] Enable more warnings for standalone build.

Add fix for unused variable

Dec 12 2022, 5:37 PM · Restricted Project, Restricted Project
ddcc updated the summary of D135119: [scudo] Optimize scudo test string allocation.
Dec 12 2022, 4:14 PM · Restricted Project, Restricted Project
ddcc committed rG119f977d9e3f: [scudo] Optimize scudo test string allocation (authored by ddcc).
[scudo] Optimize scudo test string allocation
Dec 12 2022, 4:14 PM · Restricted Project, Restricted Project
ddcc closed D135119: [scudo] Optimize scudo test string allocation.
Dec 12 2022, 4:14 PM · Restricted Project, Restricted Project
ddcc added a comment to D122761: [scudo] Enable more warnings for standalone build.

Sorry, I tested it when I opened the revision but forgot to account for changes since then.

Dec 12 2022, 11:20 AM · Restricted Project, Restricted Project

Dec 9 2022

ddcc added a comment to D129326: [scudo] Pass MapPlatformData to all map/unmap calls.

Yes, we need the MapPlatformData structure to always be allocated, though we only run the primary32.h allocator in tests and not in practice, so there shouldn't be much impact.

Dec 9 2022, 5:34 PM · Restricted Project, Restricted Project
ddcc updated the diff for D135119: [scudo] Optimize scudo test string allocation.

Call new reserve() method

Dec 9 2022, 5:23 PM · Restricted Project, Restricted Project
ddcc committed rGa2b0673dbe5d: [scudo] Enable more warnings for standalone build (authored by ddcc).
[scudo] Enable more warnings for standalone build
Dec 9 2022, 5:17 PM · Restricted Project, Restricted Project
ddcc closed D122761: [scudo] Enable more warnings for standalone build.
Dec 9 2022, 5:17 PM · Restricted Project, Restricted Project

Dec 1 2022

ddcc added inline comments to D135119: [scudo] Optimize scudo test string allocation.
Dec 1 2022, 8:19 PM · Restricted Project, Restricted Project

Nov 7 2022

ddcc added a comment to D137371: [libc] Fix matching on struct tm.
In D137371#3912177, @jeffbailey wrote:

Ate these test changes enough to catch this? It seems a bit magical with the numbers. Should there be an explicit test that tests matching more than one field?

Nov 7 2022, 10:50 AM · Restricted Project, Restricted Project

Nov 3 2022

ddcc updated the diff for D137371: [libc] Fix matching on struct tm.

Last wrong testcase for gmtime

Nov 3 2022, 6:39 PM · Restricted Project, Restricted Project
ddcc updated the diff for D137371: [libc] Fix matching on struct tm.

More gmtime_r test fixes

Nov 3 2022, 6:36 PM · Restricted Project, Restricted Project
ddcc updated the diff for D137371: [libc] Fix matching on struct tm.

More gmtime test fixes

Nov 3 2022, 6:23 PM · Restricted Project, Restricted Project
ddcc updated the diff for D137371: [libc] Fix matching on struct tm.

Fix incorrect testcase for gmtime_r

Nov 3 2022, 4:00 PM · Restricted Project, Restricted Project
ddcc updated the diff for D137371: [libc] Fix matching on struct tm.

Fix incorrect testcase for gmtime

Nov 3 2022, 3:50 PM · Restricted Project, Restricted Project
ddcc requested review of D137371: [libc] Fix matching on struct tm.
Nov 3 2022, 3:40 PM · Restricted Project, Restricted Project

Oct 6 2022

ddcc committed rG74ec46796493: [libc] Resolve NaN/implementation-defined behavior of floating-point tests (authored by ddcc).
[libc] Resolve NaN/implementation-defined behavior of floating-point tests
Oct 6 2022, 9:13 PM · Restricted Project, Restricted Project
ddcc closed D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.
Oct 6 2022, 9:13 PM · Restricted Project, Restricted Project
ddcc added inline comments to D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.
Oct 6 2022, 3:36 PM · Restricted Project, Restricted Project
ddcc updated the diff for D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.

Fix atan behavior

Oct 6 2022, 3:34 PM · Restricted Project, Restricted Project
ddcc reopened D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.
Oct 6 2022, 3:34 PM · Restricted Project, Restricted Project

Oct 5 2022

ddcc added a reverting change for rG5470b1fcb575: [libc] Resolve NaN/implementation-defined behavior of floating-point tests: rG8f10d204d13b: Revert "[libc] Resolve NaN/implementation-defined behavior of floating-point….
Oct 5 2022, 4:34 PM · Restricted Project, Restricted Project
ddcc committed rG8f10d204d13b: Revert "[libc] Resolve NaN/implementation-defined behavior of floating-point… (authored by ddcc).
Revert "[libc] Resolve NaN/implementation-defined behavior of floating-point…
Oct 5 2022, 4:34 PM · Restricted Project, Restricted Project
ddcc added a reverting change for D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests: rG8f10d204d13b: Revert "[libc] Resolve NaN/implementation-defined behavior of floating-point….
Oct 5 2022, 4:33 PM · Restricted Project, Restricted Project
ddcc committed rG5470b1fcb575: [libc] Resolve NaN/implementation-defined behavior of floating-point tests (authored by ddcc).
[libc] Resolve NaN/implementation-defined behavior of floating-point tests
Oct 5 2022, 4:24 PM · Restricted Project, Restricted Project
ddcc closed D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.
Oct 5 2022, 4:23 PM · Restricted Project, Restricted Project
ddcc updated the diff for D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.

Fix x86_64 long double

Oct 5 2022, 2:16 PM · Restricted Project, Restricted Project

Oct 4 2022

ddcc updated the diff for D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.

Fix infinite recursion from sed replace

Oct 4 2022, 3:23 PM · Restricted Project, Restricted Project

Oct 3 2022

ddcc requested review of D135119: [scudo] Optimize scudo test string allocation.
Oct 3 2022, 5:12 PM · Restricted Project, Restricted Project
ddcc updated the diff for D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.

Use build_quiet_nan and update CMakeLists.txt

Oct 3 2022, 5:00 PM · Restricted Project, Restricted Project

Sep 29 2022

ddcc updated the diff for D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.

Remove deprecated change

Sep 29 2022, 3:34 PM · Restricted Project, Restricted Project
ddcc requested review of D134917: [libc] Resolve NaN/implementation-defined behavior of floating-point tests.
Sep 29 2022, 3:33 PM · Restricted Project, Restricted Project

Sep 8 2022

ddcc committed rGac77b3fde120: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin… (authored by ddcc).
[clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin…
Sep 8 2022, 12:48 PM · Restricted Project, Restricted Project
ddcc closed D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header.
Sep 8 2022, 12:48 PM · Restricted Project, Restricted Project

Sep 7 2022

ddcc added a comment to D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header.

Yup, thanks!

Sep 7 2022, 3:21 PM · Restricted Project, Restricted Project
ddcc updated the diff for D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header.

Fix typo in __revsh

Sep 7 2022, 3:21 PM · Restricted Project, Restricted Project

Aug 17 2022

ddcc added a comment to D131999: [libcxx] Resolve warnings for Wshift-sign-overflow.

Hmm apparently there's some CUDA builder failures, so I've reverted for now.

Aug 17 2022, 10:40 AM · Restricted Project, Restricted Project
ddcc added a reverting change for rG774c39313e83: [libcxx] Resolve warnings for Wshift-sign-overflow: rG5a42e2bc2805: Revert "[libcxx] Resolve warnings for Wshift-sign-overflow".
Aug 17 2022, 10:37 AM · Restricted Project, Restricted Project
ddcc committed rG5a42e2bc2805: Revert "[libcxx] Resolve warnings for Wshift-sign-overflow" (authored by ddcc).
Revert "[libcxx] Resolve warnings for Wshift-sign-overflow"
Aug 17 2022, 10:37 AM · Restricted Project, Restricted Project
ddcc added a reverting change for D131999: [libcxx] Resolve warnings for Wshift-sign-overflow: rG5a42e2bc2805: Revert "[libcxx] Resolve warnings for Wshift-sign-overflow".
Aug 17 2022, 10:37 AM · Restricted Project, Restricted Project
ddcc committed rG774c39313e83: [libcxx] Resolve warnings for Wshift-sign-overflow (authored by ddcc).
[libcxx] Resolve warnings for Wshift-sign-overflow
Aug 17 2022, 10:32 AM · Restricted Project, Restricted Project
ddcc closed D131999: [libcxx] Resolve warnings for Wshift-sign-overflow.
Aug 17 2022, 10:31 AM · Restricted Project, Restricted Project

Aug 16 2022

ddcc requested review of D132003: [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header.
Aug 16 2022, 4:45 PM · Restricted Project, Restricted Project
ddcc requested review of D131999: [libcxx] Resolve warnings for Wshift-sign-overflow.
Aug 16 2022, 4:31 PM · Restricted Project, Restricted Project
ddcc updated the diff for D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.

Handle string and variant

Aug 16 2022, 4:30 PM · Restricted Project, Restricted Project
ddcc added inline comments to D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.
Aug 16 2022, 4:28 PM · Restricted Project, Restricted Project
ddcc added inline comments to D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.
Aug 16 2022, 3:32 PM · Restricted Project, Restricted Project
ddcc added inline comments to D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.
Aug 16 2022, 3:30 PM · Restricted Project, Restricted Project
ddcc updated the diff for D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.

Update test suite flags, use numeric_limits

Aug 16 2022, 2:54 PM · Restricted Project, Restricted Project
ddcc added a comment to D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.
In D131929#3727098, @ldionne wrote:

Thanks for the patch!

These warnings should be enabled in the test suite to avoid regressions.

@ddcc You can do that by adding them in libcxx/utils/libcxx/test/params.py.

Aug 16 2022, 2:48 PM · Restricted Project, Restricted Project

Aug 15 2022

ddcc requested review of D131929: [libcxx] Resolve warnings for Wimplicit-float-conversion, Wmacro-redefined, Wzero-as-null-pointer-constant, Wsign-conversion.
Aug 15 2022, 4:34 PM · Restricted Project, Restricted Project

Aug 8 2022

ddcc abandoned D131213: [clang][Headers] Fix unintentional error in D130800.
Aug 8 2022, 3:23 PM · Restricted Project, Restricted Project

Aug 5 2022

ddcc added a comment to D131213: [clang][Headers] Fix unintentional error in D130800.

I missed line 19, yeah that makes sense. @iana is that ok with you?

Aug 5 2022, 10:49 AM · Restricted Project, Restricted Project

Aug 4 2022

ddcc requested review of D131213: [clang][Headers] Fix unintentional error in D130800.
Aug 4 2022, 3:48 PM · Restricted Project, Restricted Project

Aug 3 2022

ddcc committed rGbbf19005714b: [clang][Headers] Avoid compiler warnings in builtin headers (authored by ddcc).
[clang][Headers] Avoid compiler warnings in builtin headers
Aug 3 2022, 5:56 PM · Restricted Project, Restricted Project
ddcc closed D130800: [clang][Headers] Avoid compiler warnings in builtin headers.
Aug 3 2022, 5:56 PM · Restricted Project, Restricted Project

Aug 2 2022

ddcc added inline comments to D130800: [clang][Headers] Avoid compiler warnings in builtin headers.
Aug 2 2022, 9:26 PM · Restricted Project, Restricted Project
ddcc updated the diff for D130800: [clang][Headers] Avoid compiler warnings in builtin headers.

Drop changes to CUDA/HIP/OpenMP headers

Aug 2 2022, 3:21 PM · Restricted Project, Restricted Project
ddcc added inline comments to D130800: [clang][Headers] Avoid compiler warnings in builtin headers.
Aug 2 2022, 3:20 PM · Restricted Project, Restricted Project
ddcc added a reviewer for D130800: [clang][Headers] Avoid compiler warnings in builtin headers: tra.
Aug 2 2022, 1:25 PM · Restricted Project, Restricted Project
ddcc updated the diff for D130800: [clang][Headers] Avoid compiler warnings in builtin headers.

Error out on undef __cplusplus in CUDA headers

Aug 2 2022, 1:25 PM · Restricted Project, Restricted Project
ddcc added inline comments to D130800: [clang][Headers] Avoid compiler warnings in builtin headers.
Aug 2 2022, 1:11 PM · Restricted Project, Restricted Project

Aug 1 2022

ddcc updated the diff for D130800: [clang][Headers] Avoid compiler warnings in builtin headers.

Undef macros instead, handle other header files

Aug 1 2022, 1:56 PM · Restricted Project, Restricted Project
ddcc closed D129391: [scudo] Satisfy -Wstrict-prototypes.

Landed already, not sure why this wasn't automatically closed

Aug 1 2022, 1:34 PM · Restricted Project, Restricted Project

Jul 29 2022

ddcc requested review of D130800: [clang][Headers] Avoid compiler warnings in builtin headers.
Jul 29 2022, 2:38 PM · Restricted Project, Restricted Project

Jul 8 2022

ddcc added inline comments to D129326: [scudo] Pass MapPlatformData to all map/unmap calls.
Jul 8 2022, 3:29 PM · Restricted Project, Restricted Project
ddcc requested review of D129391: [scudo] Satisfy -Wstrict-prototypes.
Jul 8 2022, 12:45 PM · Restricted Project, Restricted Project

Jul 7 2022

ddcc added inline comments to D129326: [scudo] Pass MapPlatformData to all map/unmap calls.
Jul 7 2022, 5:47 PM · Restricted Project, Restricted Project
ddcc resigned from D129331: [scudo][Fuchsia] Don't assume MapPlatformData::Vmar is valid.

I'm not familiar with fuchsia and aren't using its scudo bindings

Jul 7 2022, 5:44 PM · Restricted Project, Restricted Project
ddcc added a comment to D129326: [scudo] Pass MapPlatformData to all map/unmap calls.

Not sure if this approach is correct since we're not using the primary32.h allocator at all except during testing, but I'm sending it along to get some feedback and in case it's useful.

Jul 7 2022, 1:26 PM · Restricted Project, Restricted Project
ddcc requested review of D129326: [scudo] Pass MapPlatformData to all map/unmap calls.
Jul 7 2022, 1:24 PM · Restricted Project, Restricted Project
ddcc committed rG5f3818c7df7d: [scudo] Add [[no_unique_address]] attribute to new MapPlatformData variables (authored by ddcc).
[scudo] Add [[no_unique_address]] attribute to new MapPlatformData variables
Jul 7 2022, 1:13 PM · Restricted Project, Restricted Project
ddcc closed D129237: [scudo] Pass MapPlatformData in more calls.
Jul 7 2022, 1:13 PM · Restricted Project, Restricted Project
ddcc added a comment to D129237: [scudo] Pass MapPlatformData in more calls.

Oops I did, I'll add another commit for that.

Jul 7 2022, 12:49 PM · Restricted Project, Restricted Project
ddcc committed rGff8c0e6eb5a8: [scudo] Pass MapPlatformData in more calls (authored by ddcc).
[scudo] Pass MapPlatformData in more calls
Jul 7 2022, 10:43 AM · Restricted Project, Restricted Project
ddcc closed D129237: [scudo] Pass MapPlatformData in more calls.
Jul 7 2022, 10:43 AM · Restricted Project, Restricted Project

Jul 6 2022

ddcc updated the diff for D129237: [scudo] Pass MapPlatformData in more calls.

Rename variable and reorder

Jul 6 2022, 10:13 PM · Restricted Project, Restricted Project
ddcc updated the diff for D129237: [scudo] Pass MapPlatformData in more calls.

Fix duplicate variable

Jul 6 2022, 6:12 PM · Restricted Project, Restricted Project
ddcc requested review of D129237: [scudo] Pass MapPlatformData in more calls.
Jul 6 2022, 3:53 PM · Restricted Project, Restricted Project

Apr 28 2022

ddcc committed rGce6bfd102af5: [libc] Support 32-bit ARM platform tests (authored by ddcc).
[libc] Support 32-bit ARM platform tests
Apr 28 2022, 12:01 PM · Restricted Project, Restricted Project
ddcc closed D124204: [libc] Support 32-bit ARM platform tests.
Apr 28 2022, 12:00 PM · Restricted Project, Restricted Project

Apr 27 2022

ddcc updated the diff for D124204: [libc] Support 32-bit ARM platform tests.

Remove unnecessary changes to str_to_float_test.cpp

Apr 27 2022, 5:27 PM · Restricted Project, Restricted Project
ddcc added inline comments to D124204: [libc] Support 32-bit ARM platform tests.
Apr 27 2022, 5:27 PM · Restricted Project, Restricted Project

Apr 26 2022

ddcc added a comment to D124204: [libc] Support 32-bit ARM platform tests.
In D124204#3475478, @michaelrj wrote:

you'll probably also need to add #ifdef conditions to src/__support/CPP/Limits.h and its corresponding test.

Apr 26 2022, 5:25 PM · Restricted Project, Restricted Project
ddcc updated the diff for D124204: [libc] Support 32-bit ARM platform tests.

Add more ifdef coverage

Apr 26 2022, 5:25 PM · Restricted Project, Restricted Project
ddcc committed rG684b1f03e336: Fix [libc] Minor test signedness fixes (authored by ddcc).
Fix [libc] Minor test signedness fixes
Apr 26 2022, 5:15 PM · Restricted Project, Restricted Project
ddcc committed rGde94cf528627: [libc] Minor test signedness fixes (authored by ddcc).
[libc] Minor test signedness fixes
Apr 26 2022, 5:11 PM · Restricted Project, Restricted Project
ddcc closed D124468: [libc] Minor test signedness fixes.
Apr 26 2022, 5:11 PM · Restricted Project, Restricted Project