[analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

[RKSimon]

Summary

This was noticed on D71817, which removed another use of OPTIMIZE

[lebedev.ri]

SGTM

[Charusso]

Nice catch, thanks! We have some FIXMEs about MSVC sadly and I was thinking about the same change back in the days.

[NoQ]

Sounds good but eventually i hope we re-enable this assert in release+assert builds (D57062).

[RKSimon]

In D76622#1938009, @NoQ wrote:

Sounds good but eventually i hope we re-enable this assert in release+assert builds (D57062).

SGTM as long as you don't reintroduce a compiler specific guard

clang/include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h

public:
   /// Returns a pair of states (StTrue, StFalse) where the given condition is
   /// assumed to be true or false, respectively.
   ProgramStatePair assumeDual(ProgramStateRef State, DefinedSVal Cond) {
     ProgramStateRef StTrue = assume(State, Cond, true);
 
     // If StTrue is infeasible, asserting the falseness of Cond is unnecessary
     // because the existing constraints already establish this.
     if (!StTrue) {
-#ifndef __OPTIMIZE__
-      // This check is expensive and should be disabled even in Release+Asserts
-      // builds.
-      // FIXME: __OPTIMIZE__ is a GNU extension that Clang implements but MSVC
-      // does not. Is there a good equivalent there?
+#ifdef EXPENSIVE_CHECKS
       assert(assume(State, Cond, false) && "System is over constrained.");
 #endif
       return ProgramStatePair((ProgramStateRef)nullptr, State);
     }
 
     ProgramStateRef StFalse = assume(State, Cond, false);
     if (!StFalse) {
       // We are careful to return the original state, /not/ StTrue,