Page MenuHomePhabricator

Cleanup the plumbing for DILineInfoSpecifier. [NFC]
ClosedPublic

Authored by saugustine on Mar 18 2020, 3:55 PM.

Details

Summary
  1. FileLineInfoSpecifier::Default isn't the default for anything.

Rename to RawValue, which accurately reflects its role.

  1. Most functions that take a part of a FileLineInfoSpecifier end up

constructing a full one later or plumb two values through. Make them
all just take a complete FileLineInfoSpecifier.

  1. Printing basenames only was handled differently from all other

variants, make it parallel to all the other variants.

Diff Detail

Event Timeline

saugustine created this revision.Mar 18 2020, 3:55 PM
dblaikie accepted this revision.Mar 19 2020, 3:12 PM

Probably better as 3 separate commits if you want to do that, but no huge deal - thanks!

This revision is now accepted and ready to land.Mar 19 2020, 3:12 PM
This revision was automatically updated to reflect the committed changes.