Page MenuHomePhabricator
Differential D76313

[mlir][NFC] Replace all usages of PatternMatchResult with LogicalResult
ClosedPublic
Actions

Authored by rriddle on Mar 17 2020, 12:07 PM.

Details

Reviewers
jpienaar
mravishankar
antiagainst
nicolasvasilache
herhut
aartbik
Commits
rG3145427dd73f: [mlir][NFC] Replace all usages of PatternMatchResult with LogicalResult
Summary

This also replaces usages of matchSuccess/matchFailure with success/failure respectively.

Depends On D76203

Diff Detail

Event Timeline

rriddle created this revision.Mar 17 2020, 12:07 PM
Herald added a reviewer: mravishankar. · View Herald TranscriptMar 17 2020, 12:07 PM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: nicolasvasilache. · View Herald Transcript
Herald added a reviewer: herhut. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, bader, Joonsoo and 13 others. · View Herald Transcript
antiagainst accepted this revision.Mar 17 2020, 12:22 PM
This revision is now accepted and ready to land.Mar 17 2020, 12:22 PM
Harbormaster failed remote builds in B49469: Diff 250853!Mar 17 2020, 1:29 PM
rriddle added a child revision: D76335: [mlir] Update DRR patterns to notify the rewriter why a pattern fails to match..Mar 17 2020, 6:01 PM
jpienaar accepted this revision.Mar 17 2020, 6:54 PM
Closed by commit rG3145427dd73f: [mlir][NFC] Replace all usages of PatternMatchResult with LogicalResult (authored by rriddle). · Explain WhyMar 17 2020, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
docs/
2 lines
8 lines
Tutorials/
Toy/
6 lines
4 lines
examples/
toy/
Ch3/
mlir/
6 lines
Ch4/
mlir/
6 lines
Ch5/
mlir/
22 lines
6 lines
Ch6/
mlir/
22 lines
4 lines
6 lines
Ch7/
mlir/
22 lines
4 lines
6 lines
include/
mlir/
Dialect/
Linalg/
Transforms/
10 lines
IR/
47 lines
Transforms/
18 lines
lib/
Conversion/
AffineToStandard/
88 lines
GPUCommon/
6 lines
6 lines
GPUToNVVM/
12 lines
GPUToSPIRV/
60 lines
LinalgToLLVM/
64 lines
LinalgToSPIRV/
14 lines
LoopToStandard/
32 lines
LoopsToGPU/
16 lines
StandardToLLVM/
195 lines
StandardToSPIRV/
70 lines
24 lines
VectorToLLVM/
120 lines
VectorToLoops/
12 lines
Dialect/
AffineOps/
16 lines
FxpMathOps/
Transforms/
30 lines
GPU/
Transforms/
6 lines
Linalg/
Transforms/
10 lines
22 lines
QuantOps/
Transforms/
20 lines
8 lines
SPIRV/
39 lines
10 lines
Transforms/
12 lines
12 lines
StandardOps/
IR/
102 lines
VectorOps/
18 lines
106 lines
IR/
2 lines
Quantizer/
Transforms/
6 lines
Transforms/
10 lines
test/
lib/
Dialect/
SPIRV/
40 lines
TestDialect/
6 lines
58 lines
tools/
mlir-tblgen/
14 lines

Diff 250853

View Options

mlir/docs/DialectConversion.md

Loading...
View Options

mlir/docs/QuickstartRewrites.md

Loading...
View Options

mlir/docs/Tutorials/Toy/Ch-3.md

Loading...
View Options

mlir/docs/Tutorials/Toy/Ch-5.md

Loading...
View Options

mlir/examples/toy/Ch3/mlir/ToyCombine.cpp

Loading...
View Options

mlir/examples/toy/Ch4/mlir/ToyCombine.cpp

Loading...
View Options

mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp

Loading...
View Options

mlir/examples/toy/Ch5/mlir/ToyCombine.cpp

Loading...
View Options

mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp

Loading...
View Options

mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp

Loading...
View Options

mlir/examples/toy/Ch6/mlir/ToyCombine.cpp

Loading...
View Options

mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp

Loading...
View Options

mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp

Loading...
View Options

mlir/examples/toy/Ch7/mlir/ToyCombine.cpp

Loading...
View Options

mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransformPatterns.td

Loading...
View Options

mlir/include/mlir/IR/PatternMatch.h

Loading...
View Options

mlir/include/mlir/Transforms/DialectConversion.h

Loading...
View Options

mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp

Loading...
View Options

mlir/lib/Conversion/GPUCommon/IndexIntrinsicsOpLowering.h

Loading...
View Options

mlir/lib/Conversion/GPUCommon/OpToFuncCallLowering.h

Loading...
View Options

mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp

Loading...
View Options

mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.cpp

Loading...
View Options

mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp

Loading...
View Options

mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp

Loading...
View Options

mlir/lib/Conversion/LoopToStandard/ConvertLoopToStandard.cpp

Loading...
View Options

mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp

Loading...
View Options

mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp

Loading...
View Options

mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp

Loading...
View Options

mlir/lib/Conversion/StandardToSPIRV/LegalizeStandardForSPIRV.cpp

Loading...
View Options

mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

Loading...
View Options

mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp

Loading...
View Options

mlir/lib/Dialect/AffineOps/AffineOps.cpp

Loading...
View Options

mlir/lib/Dialect/FxpMathOps/Transforms/LowerUniformRealMath.cpp

Loading...
View Options

mlir/lib/Dialect/GPU/Transforms/AllReduceLowering.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp

Loading...
View Options

mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp

Loading...
View Options

mlir/lib/Dialect/QuantOps/Transforms/ConvertConst.cpp

Loading...
View Options

mlir/lib/Dialect/QuantOps/Transforms/ConvertSimQuant.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/SPIRVCanonicalization.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/Transforms/DecorateSPIRVCompositeTypeLayoutPass.cpp

Loading...
View Options

mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp

Loading...
View Options

mlir/lib/Dialect/StandardOps/IR/Ops.cpp

Loading...
View Options

mlir/lib/Dialect/VectorOps/VectorOps.cpp

Loading...
View Options

mlir/lib/Dialect/VectorOps/VectorTransforms.cpp

Loading...
View Options

mlir/lib/IR/PatternMatch.cpp

Loading...
View Options

mlir/lib/Quantizer/Transforms/RemoveInstrumentationPass.cpp

Loading...
View Options

mlir/lib/Transforms/DialectConversion.cpp

Loading...
View Options

mlir/test/lib/Dialect/SPIRV/TestAvailability.cpp

Loading...
View Options

mlir/test/lib/TestDialect/TestDialect.cpp

Loading...
View Options

mlir/test/lib/TestDialect/TestPatterns.cpp

Loading...
View Options

mlir/tools/mlir-tblgen/RewriterGen.cpp

Loading...