Page MenuHomePhabricator

[AMDGPU] Use progbits type for .AMDGPU.disasm section
ClosedPublic

Authored by Flakebi on Mar 10 2020, 5:41 AM.

Details

Summary

The note section type implies a specific format that this section does
not have thus tools like readelf fail here. Progbits has no format and
another pipeline compiler already sets the type to progbits.

Konstantin, Mark: Is this going to work on the OpenCL side?

Diff Detail

Event Timeline

Flakebi created this revision.Mar 10 2020, 5:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2020, 5:41 AM

What does the .AMDGPU.disasm setion contain? If it is effectively metadata then using a note record does not seem unreasonable, but that could simply be another note record in the existing note section, and would need to conform to the note record ABI.

If making this a separate section, it would be good to document in https://llvm.org/docs/AMDGPUUsage.html#sections .

Can we finally just remove this? There's a steady stream of issues from having this feature at all, and we really don't need it

nhaehnle accepted this revision.Mar 11 2020, 4:10 AM

Can we finally just remove this? There's a steady stream of issues from having this feature at all, and we really don't need it

I agree. Let's figure this out separately though. This change is a hack (sorry Tony), but I think it's basically fine.

This revision is now accepted and ready to land.Mar 11 2020, 4:10 AM
This revision was automatically updated to reflect the committed changes.