Page MenuHomePhabricator

[MLIR] Ensure that target_link_libraries() always has a keyword.
ClosedPublic

Authored by stephenneuendorffer on Mar 5 2020, 11:09 PM.

Details

Summary

CMake allows calling target_link_libraries() without a keyword,
but this usage is not preferred when also called with a keyword,
and has surprising behavior. This patch explicitly specifies a
keyword when using target_link_libraries().

Diff Detail

Event Timeline

mehdi_amini accepted this revision.Mar 6 2020, 8:18 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2020, 9:21 AM
This revision was automatically updated to reflect the committed changes.