Page MenuHomePhabricator

[llvm-readelf] Make --all output order closer to GNU readelf
ClosedPublic

Authored by MaskRay on Mar 3 2020, 8:14 PM.

Diff Detail

Event Timeline

MaskRay created this revision.Mar 3 2020, 8:14 PM
Herald added a reviewer: alexshap. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
grimar added inline comments.Mar 4 2020, 2:25 AM
llvm/test/tools/llvm-readobj/ELF/all.test
33

Add Symbol table '.dynsym' contains {{.*}} entries: before this line?

grimar accepted this revision.Mar 4 2020, 2:26 AM

LGTM anyways. The new output looks closer to what I see with "GNU readelf (GNU Binutils for Ubuntu) 2.31.1"

This revision is now accepted and ready to land.Mar 4 2020, 2:26 AM
rupprecht accepted this revision.Mar 4 2020, 12:06 PM

Thanks for review! Fixed all lld/test/ELF tests. (Our early tests were not well organized) Will commit soon.

This revision was automatically updated to reflect the committed changes.