Page MenuHomePhabricator

[dsymutil] Avoid copying swiftinterfaces from the SDK into the dsym bundle
ClosedPublic

Authored by aprantl on Feb 26 2020, 10:12 AM.

Details

Summary

This patch fixes a bug that would cause dsymutil to collect .swiftinterface files for the Swift stdlib and other SDK modules. There is no advantage in copying these since they should be loaded from the ones bundled with LLDB's embedded Swift compiler instead and copying them will cause LLDB to recompile them from source instead of loading their prebuilt cached counterparts in the SDK.

Diff Detail

Event Timeline

aprantl created this revision.Feb 26 2020, 10:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: hiraditya. · View Herald Transcript
JDevlieghere accepted this revision.Feb 26 2020, 10:55 AM

LGTM

llvm/lib/DWARFLinker/DWARFLinker.cpp
174

Nit: I'd add a newline before and after the new code to visually distinguish it as a single unit for the given comment.

This revision is now accepted and ready to land.Feb 26 2020, 10:55 AM
friss accepted this revision.Feb 26 2020, 11:01 AM

LGTM