With the introduction of the native fneg instruction, the
fsub -0.0, %x idiom is obsolete. This patch makes LLVM
emit fneg instead of the idiom in all places.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp | ||
---|---|---|
341 | What about this TODO? |
llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp | ||
---|---|---|
341 | Ok. So this seems to be a hack to update the FSub idiom on the fly. |
llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp | ||
---|---|---|
341 | I agree |
Comment Actions
LGTM, with the TODO to be handled under a separate patch.
Thank you for taking care of this, Simon.
llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp | ||
---|---|---|
341 | +1 |
What about this TODO?