This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Move from add_dependencies() to DEPENDS
ClosedPublic

Authored by stephenneuendorffer on Feb 20 2020, 2:07 PM.

Details

Summary

add_llvm_library and add_llvm_executable may need to create new targets with
appropriate dependencies. As a result, it is not sufficient in some
configurations (namely LLVM_BUILD_LLVM_DYLIB=on) to only call
add_dependencies(). Instead, the explicit TableGen dependencies must
be passed to add_llvm_library() or add_llvm_executable() using the DEPENDS
keyword.

Diff Detail

Event Timeline

stephenneuendorffer edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2020, 11:51 AM
This revision was automatically updated to reflect the committed changes.