Page MenuHomePhabricator
Differential D74063

[Clang] Remove #pragma clang __debug handle_crash
ClosedPublic
Actions

Authored by aganea on Feb 5 2020, 8:53 AM.

Details

Reviewers
hans
Commits
rG793d643f6d69: [Clang] Remove unused #pragma clang __debug handle_crash
rG8ecde3ac34bb: [Clang] Remove unused #pragma clang __debug handle_crash
Summary

As discussed in D70568, remove this because it isn't used anywhere, and I think it's better to go through real crashes for testing (#pragma clang __debug crash).
Also remove the support function CrashRecoveryContext::HandleCrash() which was added at the same time by @ddunbar.

Diff Detail

Event Timeline

aganea created this revision.Feb 5 2020, 8:53 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 5 2020, 8:53 AM
Herald added subscribers: llvm-commits, cfe-commits, hiraditya. · View Herald Transcript
aganea mentioned this in D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh.Feb 5 2020, 11:04 AM
hans accepted this revision.Feb 6 2020, 2:45 AM
hans added inline comments.
clang/lib/Lex/Pragma.cpp
42

I think this can be removed now.

This revision is now accepted and ready to land.Feb 6 2020, 2:45 AM
hans mentioned this in D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used.Feb 6 2020, 2:46 AM
aganea marked an inline comment as done.Feb 6 2020, 12:27 PM
Closed by commit rG8ecde3ac34bb: [Clang] Remove unused #pragma clang __debug handle_crash (authored by aganea). · Explain WhyFeb 6 2020, 12:33 PM
This revision was automatically updated to reflect the committed changes.
hans added a comment.Feb 10 2020, 6:32 AM

Cherry-picked to 10.x in 793d643f6d69e6908a6ece4aacb07b6573e33e18

Revision Contents
Changeset List

PathSize
clang/
lib/
Lex/
5 lines
llvm/
include/
llvm/
Support/
4 lines
lib/
Support/
8 lines

Diff 242980

View Options

clang/lib/Lex/Pragma.cpp

Loading...
View Options

llvm/include/llvm/Support/CrashRecoveryContext.h

Loading...
View Options

llvm/lib/Support/CrashRecoveryContext.cpp

Loading...