This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Remove #pragma clang __debug handle_crash
ClosedPublic

Authored by aganea on Feb 5 2020, 8:53 AM.

Details

Summary

As discussed in D70568, remove this because it isn't used anywhere, and I think it's better to go through real crashes for testing (#pragma clang __debug crash).
Also remove the support function CrashRecoveryContext::HandleCrash() which was added at the same time by @ddunbar.

Diff Detail

Event Timeline

aganea created this revision.Feb 5 2020, 8:53 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 5 2020, 8:53 AM
hans accepted this revision.Feb 6 2020, 2:45 AM
hans added inline comments.
clang/lib/Lex/Pragma.cpp
42

I think this can be removed now.

This revision is now accepted and ready to land.Feb 6 2020, 2:45 AM
aganea marked an inline comment as done.Feb 6 2020, 12:27 PM
This revision was automatically updated to reflect the committed changes.