[mlir] Add elementAttr to TypedArrayAttrBase.

[abeakkas]

Summary

In code generators, one can automate the translation of typed ArrayAttrs if element attribute translators are already implemented. However, the type of the element attribute is lost at the construction of TypedArrayAttrBase. With this change one can inspect the element type and generate the translation logic automatically, which will reduce the code repetition.

[abeakkas]

This is a followup commit to https://reviews.llvm.org/D72888 .

[merge_guards_bot]

Unit tests: pass. 62196 tests passed, 0 failed and 815 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

[mehdi_amini]

Can you provide a test?

[abeakkas]

In D73579#1846133, @mehdi_amini wrote:

Can you provide a test?

Can you give me a pointer as to how to test this? I searched for a similar test for baseAttr in the repo but couldn't find one. This is something that you would use while inspecting TableGen records. Should the test be a cpp file under mlir/test/lib/TableGen that inspects a td file?

[mehdi_amini]

@antiagainst : what is the best way to test that?

[antiagainst]

In D73579#1852960, @mehdi_amini wrote:

@antiagainst : what is the best way to test that?

Sorry for the late reply! Existing tests for TableGen are testing TableGen backends in tree. What @abeakkas has here is a field for an out-of-tree TableGen backend so I'm not sure that there is a good approach except for just dumping the record without invoking any backend and check the field is as expected.

[abeakkas]

Adding test that checks the record dump for elementAttr field.

[antiagainst]

mlir/test/mlir-tblgen/op-attribute.td

250 ↗

(On Diff #243233)

Can we have RECORD-LABEL to match SomeTypedArrayAttr before this? Otherwise it's too broad a range to match against.

[abeakkas]

Added RECORD-LABEL to SomeTypedArrayAttr test.

[abeakkas]

I don't have commit access to the GitHub repo. Can someone land the change for me?

[abeakkas]

Thank you!

mlir/include/mlir/IR/OpBase.td

And<[
       CPred<"$_self.isa<ArrayAttr>()">,
       // Guarantee all elements satisfy the constraints from `element`
       Concat<"llvm::all_of($_self.cast<ArrayAttr>(), "
                           "[](Attribute attr) { return ",
                              SubstLeaves<"$_self", "attr", element.predicate>,
                           "; })">]>,
     description> {
   let constBuilderCall = "$_builder.getArrayAttr($0)";
+
+  Attr elementAttr = element;
 }
 
 def I32ArrayAttr : TypedArrayAttrBase<I32Attr,
                                       "32-bit integer array attribute"> {
   let constBuilderCall = "$_builder.getI32ArrayAttr($0)";
 }
 def I64ArrayAttr : TypedArrayAttrBase<I64Attr,
                                       "64-bit integer array attribute"> {