[mlir] Add baseAttr to TypedArrayAttrBase.

[abeakkas]

Summary

Element type is useful in code generators but it is lost after construction.

[merge_guards_bot]

Unit tests: pass. 61909 tests passed, 0 failed and 782 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

[abeakkas]

I get 403 from Github when I try 'arc land'. I guess it's because I don't have commit access. Can someone else land the commit for me?

[mehdi_amini]

In D72888#1834476, @abeakkas wrote:

I get 403 from Github when I try 'arc land'. I guess it's because I don't have commit access. Can someone else land the commit for me?

Landed here : https://github.com/llvm/llvm-project/commit/eec36909c18b

Note that arc land leaves a lot of noisy tags from Phabricator which I rather filter before committing.

[abeakkas]

Thanks!

[ftynse]

I reverted this change since it broke dependent projects, and the modeling generally looks incorrect.

baseAttr is intended to be used in the decorator classes that are not proper attributes themselves, but only add additional constraints to the existing attributes. For example, default-valued attributes of type XAttr don't need the value to be constructed, but they are still attributes of type XAttr. Array attributes of type XArrayAttr are _not_ XAttr. If you need the element attribute for some reason, store it in a different tablegen field. Please also specify _why_ you need this change in the commit message, not only the contents of the change (https://llvm.org/docs/DeveloperPolicy.html#commit-messages).

mlir/include/mlir/IR/OpBase.td

And<[
       CPred<"$_self.isa<ArrayAttr>()">,
       // Guarantee all elements satisfy the constraints from `element`
       Concat<"llvm::all_of($_self.cast<ArrayAttr>(), "
                           "[](Attribute attr) { return ",
                              SubstLeaves<"$_self", "attr", element.predicate>,
                           "; })">]>,
     description> {
   let constBuilderCall = "$_builder.getArrayAttr($0)";
+
+  let baseAttr = element;
 }
 
 def I32ArrayAttr : TypedArrayAttrBase<I32Attr,
                                       "32-bit integer array attribute"> {
   let constBuilderCall = "$_builder.getI32ArrayAttr($0)";
 }
 def I64ArrayAttr : TypedArrayAttrBase<I64Attr,
                                       "64-bit integer array attribute"> {