This is an archive of the discontinued LLVM Phabricator instance.

[lldb/DWARF] Remove one more auto-dwo method
ClosedPublic

Authored by labath on Jan 21 2020, 8:12 AM.

Details

Summary

Our DWARFUnit was automatically forwarding the requests to the split
unit when looking for a DIE by offset. llvm::DWARFUnit does not do that,
and is not likely to start doing it any time soon.

This patch deletes the this logic and updates the callers to request the
correct unit instead. While doing that, I've found a bit of duplicated
code for lookup up a function and block by address, so I've extracted
that into a helper function.

Event Timeline

labath created this revision.Jan 21 2020, 8:12 AM
Herald added a project: Restricted Project. · View Herald Transcript
This revision is now accepted and ready to land.Jan 21 2020, 1:31 PM
clayborg accepted this revision.Jan 21 2020, 3:22 PM

Thanks for doing the cleanup. After we switched over to using the DWARFDie more, there are probably many more cleanups like this where the code didn't get converted.

This revision was automatically updated to reflect the committed changes.