HomePhabricator

[lld/ELF] PR44498: Support input filename in double quote

Authored by thopre on Jan 10 2020, 8:56 AM.

Description

[lld/ELF] PR44498: Support input filename in double quote

Summary:
Linker scripts allow filenames to be put in double quotes to prevent
characters in filenames that are part of the linker script syntax from
having their special meaning. Case in point the * wildcard character.

Availability of double quoting filenames also allows to fix a failure in
ELF/linkerscript/filename-spec.s when the path contain a @ which the
lexer consider as a special characters and thus break up a filename
containing it. This may happens under Jenkins which createspath such as
pipeline@2.

To avoid the need for escaping GlobPattern metacharacters in filename
in double quotes, GlobPattern::create is augmented with a new parameter
to request literal matching instead of relying on the presence of a
wildcard character in the pattern.

Reviewers: jhenderson, MaskRay, evgeny777, espindola, alexshap

Reviewed By: MaskRay

Subscribers: peter.smith, grimar, ruiu, emaste, arichardson, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72517

Details

Committed
thopreJan 22 2020, 4:03 AM
Reviewer
MaskRay
Differential Revision
D72517: [lld/ELF] PR44498: Support input filename in double quote
Parents
rGcdcc4f2a44b5: [AArch64][SVE] Add intrinsic for non-faulting loads
Branches
Unknown
Tags
Unknown