This patch updates the remark to also include a summary of the number of
vector operations generated for each matrix expression.
Unit tests: fail. 61731 tests passed, 1 failed and 779 were skipped.
clang-tidy: fail. Please fix clang-tidy findings.
So, you are creating a copy of Other.
Did you mean this to be a non mutating function? If so, then it should be marked as const. Otherwise, if the intention was to mutate the this fields then you don't need those copies.
I am writing this because - at least for what I can see - the only use of add() is at line 1208
OpInfoTy Count = CM->second.getOpInfo(); for (Value *Op : cast<Instruction>(Root)->operand_values()) Count = Count.add(sumOpInfos(Op, ReusedExprs)); return Count;
Since Count is assigned to by each iteration, you end up with yet another "copy".