This is an archive of the discontinued LLVM Phabricator instance.

[X86] Custom type legalize v4i64->v4f32 uint_to_fp on sse4.1 targets
ClosedPublic

Authored by craig.topper on Jan 7 2020, 3:15 PM.

Details

Summary

For v4i64->v4f32 uint_to_fp on pre-avx targets where v4i64 isn't legal we create to v2i64->v2f32 uint_to_fp that need to be shuffled together. Our codegen for v2i64->v2f32 involves detecting if the number is larger than (2^31 - 1), if so we do a special divison by 2 so we can do a signed conversion which we need to scalarize, then do a multiply by 2 at the end if we divided earlier.

When v4i64 isn't legal we need to split the checking for a larger number and dividing by 2 into two v2i64 vectors. The scalar part can extract the 4 i64 values from those 4 splits. But we can reassemble the 4 scalar f32 results directly into a single v432 vector. Then we just need to combine the fixup indications from the 2 halves and we can do the final multiply by 2 fixup on all 4 values if needed at once using a single v4f32 blend and v4f32 fadd.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 7 2020, 3:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2020, 3:15 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
RKSimon accepted this revision.Jan 8 2020, 3:30 AM

LGTM - should we enable i686 filechecks in vec_int_to_fp.ll to make sure the codegen actually makes sense?

This revision is now accepted and ready to land.Jan 8 2020, 3:30 AM
This revision was automatically updated to reflect the committed changes.