[llvm-objcopy][test] Fix tests when path contains "bar"

[MaskRay]

Summary

Tests that use --implicit-check-not=bar should be improved to not make jlebar sad.

[merge_guards_bot]

Unit tests: pass. 61303 tests passed, 0 failed and 736 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

[rupprecht]

I left comments on D72357 instead

[MaskRay]

Ping:)

[jhenderson]

In D72358#1823248, @MaskRay wrote:

Ping:)

I'm waiting on @rupprecht's comments in D72357.

[MaskRay]

The argument in D72357 does not need to block this patch. I'll push this, as a straightforward improvement over the existing tests, so that @jlebar and @bbaren can be happy.

[dblaikie]

In D72358#1850950, @MaskRay wrote:

The argument in D72357 does not need to block this patch. I'll push this, as a straightforward improvement over the existing tests, so that @jlebar and @bbaren can be happy.

I feel like this kind of ignored specific feedback I had on the other review that applied equally here. Had I known about this review/commit, I would've objected to it on the same grounds.

Please use redirection in this and future tests to address issues like this to help make tests more resilient to interesting paths on developer/test machines.

[MaskRay]

In D72358#1864752, @dblaikie wrote:

In D72358#1850950, @MaskRay wrote:

The argument in D72357 does not need to block this patch. I'll push this, as a straightforward improvement over the existing tests, so that @jlebar and @bbaren can be happy.

I feel like this kind of ignored specific feedback I had on the other review that applied equally here. Had I known about this review/commit, I would've objected to it on the same grounds.

Please use redirection in this and future tests to address issues like this to help make tests more resilient to interesting paths on developer/test machines.

@dblaikie Almost all llvm-readobj tests do not use input redirection. @rupprecht and @dblaikie raised the concern but @jhenderson and @MaskRay did not think we should do that.

A future %t -> < %t change will not make this patch entirely meaningless. If @jhenderson and @MaskRay changed their mind, they might create a patch to fix all tests for consistency.
Postponing this patch (2 out of probably 400+ tests) can indeed make the file history a bit more tidy. But does that weigh a lot? What I felt a bit sad was that we left @jlebar and @bbaren's issues unresolved for such a long time. We also missed the release/10.x window. Now a random bar user will find check-llvm fail as well.

llvm/test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test

 ## Here we want to check that llvm-objcopy removes an undefined symbol
 ## if all references to it have been stripped.
 
 # RUN: yaml2obj --docnum=1 %s -o %t.o
 # RUN: llvm-objcopy -j .other.section %t.o %t2.o
-# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-readobj --symbols %t2.o | FileCheck %s
 
 # RUN: llvm-objcopy -j .text -j .rela.text1 %t.o %t2.o
 # RUN: llvm-readobj --symbols %t2.o | FileCheck %s --check-prefix=BAR
 
-# BAR: bar
+# CHECK-NOT: Name: bar
+# BAR: Name: bar
 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
   Data:    ELFDATA2LSB
   Type:    ET_REL
   Machine: EM_X86_64
 Sections:
- Name:    bar
     Binding: STB_GLOBAL
 ...
 
 ## Check we remove unreferenced undefined symbols, even if
 ## they weren't previously referenced. This follows GNU.
 
 # RUN: yaml2obj --docnum=2 %s -o %t.o
 # RUN: llvm-objcopy -j .keep_me %t.o %t2.o
-# RUN: llvm-readobj --symbols %t2.o | FileCheck %s --implicit-check-not=bar
+# RUN: llvm-readobj --symbols %t2.o | FileCheck %s
 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64
   Data:    ELFDATA2LSB
   Type:    ET_REL
   Machine: EM_X86_64
 Sections:
   - Name: .keep_me
     Type: SHT_PROGBITS
 Symbols:
   - Name:    bar
     Binding: STB_GLOBAL
 ...

llvm/test/tools/llvm-objcopy/ELF/tail-merged-string-tables.test

 ## This test shows that when symbol/section names are optimized in the string
 ## table to share the same entry, due to tail merging, llvm-objcopy operations
 ## function correctly without corrupting the names of unchanged sections/symbols.
 
 # RUN: yaml2obj %s -o %t.o
 ## Sanity check that the strings have been pooled.
 # RUN: llvm-readobj %t.o --string-dump .strtab --string-dump .shstrtab \
-# RUN:   | FileCheck %s --check-prefix=VALIDATE --implicit-check-not=bar --implicit-check-not=.blag
+# RUN:   | FileCheck %s --check-prefix=VALIDATE --implicit-check-not='] bar' --implicit-check-not=.blag
 
-# VALIDATE: String dump of section '.strtab':
-# VALIDATE: bazfoobar
-# VALIDATE: String dump of section '.shstrtab':
-# VALIDATE: .blam.blah.blag
+# VALIDATE:      String dump of section '.strtab':
+# VALIDATE-NEXT: [     1] bazfoobar
+# VALIDATE-EMPTY:
+# VALIDATE-NEXT: String dump of section '.shstrtab':
+# VALIDATE-NEXT: [     1] .blam.blah.blag
 
 ## Case 1: Basic copy.
 # RUN: llvm-objcopy %t.o %t.copy
 # RUN: llvm-readobj --section-headers --symbols %t.copy | FileCheck %s --check-prefix=COPY
 
 # COPY: Sections [
 # COPY:   Name: .blam.blah.blag (
 # COPY:   Name: .blah.blag (

 
 # REMOVE-SECTION: Sections [
 # REMOVE-SECTION:   Name: .blam.blah.blag (
 # REMOVE-SECTION:   Name: .blag (
 
 ## Case 5: Remove symbol.
 # RUN: llvm-objcopy %t.o %t.remove-symbol -N foobar
 # RUN: llvm-readobj --symbols %t.remove-symbol \
-# RUN:   | FileCheck %s --check-prefix=REMOVE-SYMBOL --implicit-check-not foobar
+# RUN:   | FileCheck %s --check-prefix=REMOVE-SYMBOL --implicit-check-not='Name: foobar'
 
 # REMOVE-SYMBOL: Symbols [
 # REMOVE-SYMBOL:   Name: bar (
 # REMOVE-SYMBOL:   Name: bazfoobar (
 
 --- !ELF
 FileHeader:
   Class:   ELFCLASS64