Page MenuHomePhabricator

[Sema] Fix location of star ('*') inside MemberPointerTypeLoc
Needs ReviewPublic

Authored by ilya-biryukov on Thu, Jan 2, 3:00 AM.

Details

Reviewers
gribozavr2

Diff Detail

Event Timeline

ilya-biryukov created this revision.Thu, Jan 2, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Jan 2, 3:00 AM

Unit tests: pass. 61158 tests passed, 0 failed and 728 were skipped.

clang-tidy: pass.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

gribozavr2 added inline comments.Wed, Jan 15, 12:31 PM
clang/lib/Parse/ParseDecl.cpp
5556

ConsumeToken() returns Tok.getLocation(), so why do we need a separate variable?

D.SetRangeEnd() sets the end of source range to Tok.getLocation, which is then propagated to DeclSpec... I don't think this patch changes the behavior. Is this change testable?