Page MenuHomePhabricator

[NFC] Refactor memory ops cluster method
ClosedPublic

Authored by qiucf on Jan 2 2020, 1:28 AM.

Details

Summary

Current way of implementation in BaseMemOpsClusterMutation::apply is a little bit obscure. We can directly use a map from store chain ID to set of memory instrs to make it simpler, so that future improvements (there's indeed some) are easier to read, update and review.

Diff Detail

Event Timeline

qiucf created this revision.Jan 2 2020, 1:28 AM

Unit tests: pass. 61168 tests passed, 0 failed and 728 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

I like this patch, as it really takes me a while to understand what it is before your patch.

evandro accepted this revision.Jan 10 2020, 12:11 PM
This revision is now accepted and ready to land.Jan 10 2020, 12:11 PM
This revision was automatically updated to reflect the committed changes.