Page MenuHomePhabricator

[ARM][MVE] Refactor complex vector intrinsics [NFCI]
ClosedPublic

Authored by miyuki on Dec 10 2019, 2:32 AM.

Details

Summary

This patch refactors instruction selection of the complex vector
addition, multiplication and multiply-add intrinsics, so that it is
now based on TableGen patterns rather than C++ code.

It also changes the first parameter (halving vs non-halving) of the
arm_mve_vcaddq IR intrinsic to match the corresponding instruction
encoding, hence it requires some changes in the tests.

The patch addresses David's comment in https://reviews.llvm.org/D71190

Diff Detail

Event Timeline

miyuki created this revision.Dec 10 2019, 2:32 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 10 2019, 2:32 AM

Build result: pass - 60668 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

dmgreen accepted this revision.Dec 10 2019, 5:48 AM

Nice one. Thanks.

LGTM

This revision is now accepted and ready to land.Dec 10 2019, 5:48 AM
This revision was automatically updated to reflect the committed changes.