Page MenuHomePhabricator
Differential D71190

[ARM][MVE] Add complex vector intrinsics
ClosedPublic
Actions

Authored by miyuki on Dec 9 2019, 2:59 AM.

Details

Reviewers
simon_tatham
MarkMurrayARM
ostannard
dmgreen
Commits
rG0d1490bf6a68: [ARM][MVE] Add complex vector intrinsics
Summary

This patch adds intrinsics for the following MVE instructions:

  • VCADD, VHCADD
  • VCMUL
  • VCMLA

Each of the above 3 groups has a corresponding new LLVM IR intrinsic.

Diff Detail

Event Timeline

miyuki created this revision.Dec 9 2019, 2:59 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 9 2019, 2:59 AM
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. · View Herald Transcript
merge_guards_bot added a subscriber: merge_guards_bot.Dec 9 2019, 3:36 AM

Build result: pass - 60621 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

Harbormaster completed remote builds in B42102: Diff 232788.Dec 9 2019, 3:37 AM
MarkMurrayARM accepted this revision.Dec 9 2019, 3:57 AM

LGTM

llvm/include/llvm/IR/IntrinsicsARM.td
932

I like this!!

This revision is now accepted and ready to land.Dec 9 2019, 3:57 AM
Closed by commit rG0d1490bf6a68: [ARM][MVE] Add complex vector intrinsics (authored by miyuki). · Explain WhyDec 9 2019, 4:10 AM
This revision was automatically updated to reflect the committed changes.
dmgreen added inline comments.Dec 9 2019, 5:04 AM
llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp
2537

How come there is so much C++ code here, as opposed to using tablegen like all the other intrinsics?

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Basic/
62 lines
test/
CodeGen/
arm-mve-intrinsics/
742 lines
246 lines
373 lines
281 lines
llvm/
include/
llvm/
IR/
36 lines
lib/
Target/
ARM/
178 lines
test/
CodeGen/
Thumb2/
mve-intrinsics/
870 lines
205 lines
323 lines

Diff 232806

View Options

clang/include/clang/Basic/arm_mve.td

Loading...
View Options

clang/test/CodeGen/arm-mve-intrinsics/vcaddq.c

Loading...
View Options

clang/test/CodeGen/arm-mve-intrinsics/vcmlaq.c

Loading...
View Options

clang/test/CodeGen/arm-mve-intrinsics/vcmulq.c

Loading...
View Options

clang/test/CodeGen/arm-mve-intrinsics/vhcaddq.c

Loading...
View Options

llvm/include/llvm/IR/IntrinsicsARM.td

Loading...
View Options

llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp

Loading...
View Options

llvm/test/CodeGen/Thumb2/mve-intrinsics/vcaddq.ll

Loading...
View Options

llvm/test/CodeGen/Thumb2/mve-intrinsics/vcmlaq.ll

Loading...
View Options

llvm/test/CodeGen/Thumb2/mve-intrinsics/vcmulq.ll

Loading...