Page MenuHomePhabricator

[X86] Add supports for strict float operation fpextend/fpround/fsqrt
ClosedPublic

Authored by LiuChen3 on Dec 9 2019, 12:48 AM.

Details

Summary

This patch enables the X86 backend support for strict float operation: fpextend/fpround/fsqrt

Diff Detail

Event Timeline

LiuChen3 created this revision.Dec 9 2019, 12:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2019, 12:48 AM

LGTM with those two comments addressed.

llvm/lib/Target/X86/X86ISelLowering.cpp
632

Please add back the blank line that was here

632

I don't think this FIXME is needed.

craig.topper accepted this revision.Dec 9 2019, 10:42 AM

Forgot click Accept I guess. Please fix those two comments before committing

This revision is now accepted and ready to land.Dec 9 2019, 10:42 AM
LiuChen3 updated this revision to Diff 232970.Dec 9 2019, 5:00 PM

Modify as comments.

Forgot click Accept I guess. Please fix those two comments before committing

Thanks.

This revision was automatically updated to reflect the committed changes.