This is an archive of the discontinued LLVM Phabricator instance.

Differential D71113

Recover shared libs build after 9e8c799e2b0dc3e3b20f5044309fa8e48e8e3e32
AbandonedPublic

Authored by nemanjai on Dec 6 2019, 5:22 AM.

Details

Reviewers
avl
JDevlieghere
Summary

The above commit broke the shared libraries build. Listing CodeGen in the dependencies fixes the problem.

Diff Detail

Event Timeline

nemanjai created this revision.Dec 6 2019, 5:22 AM
Herald added a reviewer: JDevlieghere. · View Herald TranscriptDec 6 2019, 5:22 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: mgorny. · View Herald Transcript
avl added a comment.Dec 6 2019, 5:58 AM

Hi @nemanjai I has recently integrated the fix for that problem https://reviews.llvm.org/rG8c714c93023d7d039a23fb47c8256570ba54b9c7 . I am sorry for inconvenience.

nemanjai abandoned this revision.Dec 6 2019, 7:26 AM
In D71113#1772573, @avl wrote:

Hi @nemanjai I has recently integrated the fix for that problem https://reviews.llvm.org/rG8c714c93023d7d039a23fb47c8256570ba54b9c7 . I am sorry for inconvenience.

Awesome. Thanks for fixing it. I'll abandon this one.

Revision Contents

PathSize
llvm/
tools/
dsymutil/
1 line

Diff 232539

llvm/tools/dsymutil/CMakeLists.txt

set(LLVM_TARGET_DEFINITIONS Options.td) set(LLVM_TARGET_DEFINITIONS Options.td)
tablegen(LLVM Options.inc -gen-opt-parser-defs) tablegen(LLVM Options.inc -gen-opt-parser-defs)
add_public_tablegen_target(DsymutilTableGen) add_public_tablegen_target(DsymutilTableGen)
set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
AllTargetsAsmPrinters AllTargetsAsmPrinters
AllTargetsCodeGens AllTargetsCodeGens
AllTargetsDescs AllTargetsDescs
AllTargetsInfos AllTargetsInfos
AsmPrinter AsmPrinter
CodeGen
DebugInfoDWARF DebugInfoDWARF
MC MC
Object Object
Option Option
Remarks Remarks
Support Support
Target Target
) )
Show All 22 Lines