This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Keep consistent check of legal addressing mode.
ClosedPublic

Authored by hliao on Nov 19 2019, 4:00 PM.

Details

Summary
  • Add test cases for GFX10, which has narrower offset range compared to GFX9.

Event Timeline

hliao created this revision.Nov 19 2019, 4:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2019, 4:00 PM
hliao updated this revision to Diff 230167.Nov 19 2019, 4:04 PM

revise a test

Harbormaster completed remote builds in B41209: Diff 230167.
arsenm added inline comments.Nov 20 2019, 8:47 AM
llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
1434

This is a separate change

hliao marked an inline comment as done.Nov 20 2019, 10:43 AM
hliao added inline comments.
llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
1434

yeah, but this trivial issue is exposed with the new tests added. I'd like to address here as that's the general thing when a register operand is replaced.

This revision is now accepted and ready to land.Nov 20 2019, 11:43 AM
This revision was automatically updated to reflect the committed changes.
arsenm added inline comments.Nov 20 2019, 7:13 PM
llvm/lib/Target/AMDGPU/SIISelLowering.cpp
1098

We should have additional addressing mode stress tests like we already have that hit this issue