Page MenuHomePhabricator

[mips] Enable `la` pseudo instruction on 64-bit arch
ClosedPublic

Authored by atanasyan on Nov 13 2019, 12:28 PM.

Details

Summary

This patch makes LLVM compatible with GAS. It accepts la pseudo instruction on 64-bit arch and just shows a warning.

Diff Detail

Event Timeline

atanasyan created this revision.Nov 13 2019, 12:28 PM
Petar.Avramovic accepted this revision.Nov 14 2019, 7:24 AM

LGTM.

Since n32 worked before, you could change

It accepts la pseudo instruction on 64-bit arch and just shows a warning.

It accepts la pseudo instruction on arch with 64-bit pointers and just shows a warning.

llvm/test/MC/Mips/macro-la-64bit.s
2–7

Judging by the test name, this test should check "la 64-bit-address".
Test has 32bit pointers because abi is O32, thus Is32BitAddress is true.
.set mips64r2 did change the feature bits but abi remains as specified in -triple=mips-unknown-linux.
Additionally it would be nice to add a few instructions with i64 immediates like in macro-dla.s.

This revision is now accepted and ready to land.Nov 14 2019, 7:24 AM

Thanks for review.

This revision was automatically updated to reflect the committed changes.