This is an archive of the discontinued LLVM Phabricator instance.

Differential D70161

[cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows
ClosedPublic

Authored by tstellar on Nov 12 2019, 7:41 PM.

Details

Reviewers
beanz
smeenai
compnerd
phosek
Commits
rGcfca818ef7b8: [cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows
Summary

The BUILD_SHARED_LIBS=ON build fails on Windows, so prevent users from
enabling it.

Diff Detail

Event Timeline

tstellar created this revision.Nov 12 2019, 7:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2019, 7:41 PM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B40861: Diff 229002.Nov 12 2019, 7:44 PM
beanz accepted this revision.Nov 13 2019, 11:22 AM

LGTM.

This revision is now accepted and ready to land.Nov 13 2019, 11:22 AM
Closed by commit rGcfca818ef7b8: [cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows (authored by tstellar). · Explain WhyNov 14 2019, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
3 lines

Diff 229002

llvm/CMakeLists.txt

Show First 20 Lines • Show All 564 Lines • ▼ Show 20 Lines set(LLVM_DYLIB_COMPONENTS "all" CACHE STRING
"Semicolon-separated list of components to include in libLLVM, or \"all\".") "Semicolon-separated list of components to include in libLLVM, or \"all\".")
endif() endif()
if(MSVC) if(MSVC)
option(LLVM_BUILD_LLVM_C_DYLIB "Build LLVM-C.dll (Windows only)" ON) option(LLVM_BUILD_LLVM_C_DYLIB "Build LLVM-C.dll (Windows only)" ON)
# Set this variable to OFF here so it can't be set with a command-line # Set this variable to OFF here so it can't be set with a command-line
# argument. # argument.
set (LLVM_LINK_LLVM_DYLIB OFF) set (LLVM_LINK_LLVM_DYLIB OFF)
if (BUILD_SHARED_LIBS)
message(FATAL_ERROR "BUILD_SHARED_LIBS options is not supported on Windows.")
endif()
else() else()
option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF) option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF) option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF)
set(LLVM_BUILD_LLVM_DYLIB_default OFF) set(LLVM_BUILD_LLVM_DYLIB_default OFF)
if(LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LLVM_C_DYLIB) if(LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LLVM_C_DYLIB)
set(LLVM_BUILD_LLVM_DYLIB_default ON) set(LLVM_BUILD_LLVM_DYLIB_default ON)
endif() endif()
option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_BUILD_LLVM_DYLIB_default}) option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_BUILD_LLVM_DYLIB_default})
▲ Show 20 Lines • Show All 531 Lines • Show Last 20 Lines