This is an archive of the discontinued LLVM Phabricator instance.

Differential D70160

[cmake] Prevent building with BUILD_SHARED_LIBS and LLVM_LINK_LLVM_DYLIB
ClosedPublic

Authored by tstellar on Nov 12 2019, 7:36 PM.

Details

Reviewers
beanz
smeenai
compnerd
phosek
Commits
rG5d035c5d8fe6: [cmake] Prevent building with BUILD_SHARED_LIBS and LLVM_LINK_LLVM_DYLIB
Summary

This doesn't work, so error early if someone tries it.

Diff Detail

Event Timeline

tstellar created this revision.Nov 12 2019, 7:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2019, 7:36 PM
Herald added a subscriber: mgorny. · View Herald Transcript
Harbormaster completed remote builds in B40860: Diff 229001.Nov 12 2019, 7:44 PM
beanz accepted this revision.Nov 13 2019, 11:22 AM

LGTM.

This revision is now accepted and ready to land.Nov 13 2019, 11:22 AM
Closed by commit rG5d035c5d8fe6: [cmake] Prevent building with BUILD_SHARED_LIBS and LLVM_LINK_LLVM_DYLIB (authored by tstellar). · Explain WhyNov 13 2019, 9:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
4 lines

Diff 229227

llvm/CMakeLists.txt

Show First 20 Lines • Show All 578 Lines • ▼ Show 20 Lineselse()
option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF) option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF)
set(LLVM_BUILD_LLVM_DYLIB_default OFF) set(LLVM_BUILD_LLVM_DYLIB_default OFF)
if(LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LLVM_C_DYLIB) if(LLVM_LINK_LLVM_DYLIB OR LLVM_BUILD_LLVM_C_DYLIB)
set(LLVM_BUILD_LLVM_DYLIB_default ON) set(LLVM_BUILD_LLVM_DYLIB_default ON)
endif() endif()
option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_BUILD_LLVM_DYLIB_default}) option(LLVM_BUILD_LLVM_DYLIB "Build libllvm dynamic library" ${LLVM_BUILD_LLVM_DYLIB_default})
endif() endif()
if (LLVM_LINK_LLVM_DYLIB AND BUILD_SHARED_LIBS)
message(FATAL_ERROR "Cannot enable BUILD_SHARED_LIBS with LLVM_LINK_LLVM_DYLIB. We recommend disabling BUILD_SHARED_LIBS.")
endif()
option(LLVM_OPTIMIZED_TABLEGEN "Force TableGen to be built with optimization" OFF) option(LLVM_OPTIMIZED_TABLEGEN "Force TableGen to be built with optimization" OFF)
if(CMAKE_CROSSCOMPILING OR (LLVM_OPTIMIZED_TABLEGEN AND (LLVM_ENABLE_ASSERTIONS OR CMAKE_CONFIGURATION_TYPES))) if(CMAKE_CROSSCOMPILING OR (LLVM_OPTIMIZED_TABLEGEN AND (LLVM_ENABLE_ASSERTIONS OR CMAKE_CONFIGURATION_TYPES)))
set(LLVM_USE_HOST_TOOLS ON) set(LLVM_USE_HOST_TOOLS ON)
endif() endif()
if (MSVC_IDE) if (MSVC_IDE)
option(LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION "Configure project to use Visual Studio native visualizers" TRUE) option(LLVM_ADD_NATIVE_VISUALIZERS_TO_SOLUTION "Configure project to use Visual Studio native visualizers" TRUE)
endif() endif()
▲ Show 20 Lines • Show All 517 Lines • Show Last 20 Lines