This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Disable fuzzer large.test when LLVM_ENABLE_EXPENSIVE_CHECKS=ON.
ClosedPublic

Authored by arphaman on Nov 8 2019, 11:56 AM.

Details

Summary

This test is timing out on Green Dragon http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/
and looks like it's not executed on other bots with expensive checks
enabled
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win

I don't know if it is the right approach or if it defeats the purpose of
the test. So I want to discuss if it is a reasonable fix and then I can
polish the code. So far I haven't tested it but it should convey my
intention.

rdar://problem/56377397

Event Timeline

vsapsai created this revision.Nov 8 2019, 11:56 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 8 2019, 11:56 AM
Herald added subscribers: Restricted Project, ributzka, dexonsmith and 2 others. · View Herald Transcript
vsapsai abandoned this revision.Nov 15 2019, 11:16 AM

Abandon in favor of D70288.

arphaman added a subscriber: arphaman.

LGTM. Based on the analysis I did on the bot, the test takes 2 hours to compile the file, and the majority of time it spent in IR/MIR verifiers. For now it would make sense to disable this test for expensive checks.

vsapsai reclaimed this revision.Dec 3 2019, 1:27 PM
arphaman commandeered this revision.Dec 3 2019, 1:29 PM
arphaman updated this revision to Diff 231976.
arphaman edited reviewers, added: vsapsai; removed: arphaman.

Pass LLVM_ENABLE_EXPENSIVE_CHECKS through over to the lit configurator.

vsapsai accepted this revision.Dec 3 2019, 1:41 PM

Looks good to me.

This revision is now accepted and ready to land.Dec 3 2019, 1:41 PM
This revision was automatically updated to reflect the committed changes.
MatzeB added a subscriber: MatzeB.EditedMar 15 2022, 1:52 PM

FWIW: I also had several instances where fuzzer/large.test times out in the phabricator pre-commit tests. Example: https://buildkite.com/llvm-project/premerge-checks/builds/83760#d1da7a7f-1beb-4495-a338-9802b6108a7d

Those don't even use EXPENSIVE_CHECKS I believe.

Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 1:52 PM
Herald added a subscriber: pengfei. · View Herald Transcript