This is an archive of the discontinued LLVM Phabricator instance.

Differential D68543

openmp: Recognise ARMv7ve machine arch
ClosedPublic

Authored by raj.khem on Oct 5 2019, 3:05 PM.

Details

Reviewers
jdoerfert
AndreyChurbanov
Commits
rG5f8b8d282048: [openmp] Recognise ARMv7ve machine arch.
Summary

-march in clang when set to armv7ve emits ARM_ARCH_7VE internal
define and not ARM_ARCH_7A, hence the condition fails and openmp can
not be compiled, this makes sure that ARM_ARCH_7VE is taken into
consideration as KMP_ARCH_ARMV7 as well

Diff Detail

Event Timeline

raj.khem created this revision.Oct 5 2019, 3:05 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptOct 5 2019, 3:05 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, guansong, kristof.beyls. · View Herald Transcript
huntergr added a subscriber: huntergr.Oct 7 2019, 2:15 AM
AndreyChurbanov accepted this revision.Nov 25 2019, 9:58 AM
AndreyChurbanov added a subscriber: AndreyChurbanov.

LGTM

I am not an ARM expert, but don't see any problems with checking extra define here.

This revision is now accepted and ready to land.Nov 25 2019, 9:58 AM
raj.khem added a comment.Nov 25 2019, 10:12 AM

@AndreyChurbanov Can you push/commit this patch as well. As I dont have commit privs.

Closed by commit rG5f8b8d282048: [openmp] Recognise ARMv7ve machine arch. (authored by AndreyChurbanov). · Explain WhyNov 26 2019, 3:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
openmp/
runtime/
src/
2 lines

Diff 231040

openmp/runtime/src/kmp_platform.h

Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines
#endif #endif
#elif defined __riscv && __riscv_xlen == 64 #elif defined __riscv && __riscv_xlen == 64
#undef KMP_ARCH_RISCV64 #undef KMP_ARCH_RISCV64
#define KMP_ARCH_RISCV64 1 #define KMP_ARCH_RISCV64 1
#endif #endif
#endif #endif
#if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7R__) || \ #if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7R__) || \
defined(__ARM_ARCH_7A__) defined(__ARM_ARCH_7A__) || defined(__ARM_ARCH_7VE__)
#define KMP_ARCH_ARMV7 1 #define KMP_ARCH_ARMV7 1
#endif #endif
#if defined(KMP_ARCH_ARMV7) || defined(__ARM_ARCH_6__) || \ #if defined(KMP_ARCH_ARMV7) || defined(__ARM_ARCH_6__) || \
defined(__ARM_ARCH_6J__) || defined(__ARM_ARCH_6K__) || \ defined(__ARM_ARCH_6J__) || defined(__ARM_ARCH_6K__) || \
defined(__ARM_ARCH_6Z__) || defined(__ARM_ARCH_6T2__) || \ defined(__ARM_ARCH_6Z__) || defined(__ARM_ARCH_6T2__) || \
defined(__ARM_ARCH_6ZK__) defined(__ARM_ARCH_6ZK__)
#define KMP_ARCH_ARMV6 1 #define KMP_ARCH_ARMV6 1
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines