Page MenuHomePhabricator

raj.khem (Khem Raj)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2015, 3:44 PM (370 w, 4 d)

Recent Activity

Sun, Aug 14

raj.khem accepted D131848: [DebugInfo] -fdebug-prefix-map: handle '#line "file"' for asm source.

I have tested this revision and it fixes the problem I was seeing

Sun, Aug 14, 8:27 AM · Restricted Project, Restricted Project

Fri, Aug 12

raj.khem added a comment to D131749: [MCDwarf] Respect -fdebug-prefix-map= for generated assembly debug info (DWARF v5).

I am getting a compiler error on clang-15, can you confirm if this will work with clang-15 too

Fri, Aug 12, 1:20 AM · Restricted Project, Restricted Project

Mar 25 2022

raj.khem accepted D122505: [llvm-objdump] --private-headers: change errors to warnings for dynamic section dumping.

I built this on top if 14.x branch and it fixes the problems, I was seeing and the warning is still emitted as expected.

Mar 25 2022, 2:33 PM · Restricted Project, Restricted Project
Herald added a project to D68249: [llvm-objdump] Don't throw error for empty dynamic section: Restricted Project.

I have submitted a github issue which seems to be related here https://github.com/llvm/llvm-project/issues/54456

Mar 25 2022, 9:13 AM · Restricted Project, Restricted Project

Mar 10 2022

raj.khem updated the diff for D104183: [builtins] Do not force thumb mode directive in arm/sync-ops.h.

rebased

Mar 10 2022, 9:10 PM · Restricted Project, Restricted Project
raj.khem added a comment to D99282: Use mcr for dmb instruction on armv6.

@MaskRay can you help in moving this forward ?

Mar 10 2022, 7:24 PM · Restricted Project, Restricted Project
raj.khem updated the diff for D99282: Use mcr for dmb instruction on armv6.

rebased

Mar 10 2022, 7:23 PM · Restricted Project, Restricted Project
Herald added a project to D104183: [builtins] Do not force thumb mode directive in arm/sync-ops.h: Restricted Project.

@peter.smith Can you help landing this changeset ? there has been no objections on it thus far.

Mar 10 2022, 7:19 PM · Restricted Project, Restricted Project
raj.khem updated the diff for D121379: [compiler-rt][CMake] Enable TF intrinsics on powerpc32 Linux.
Mar 10 2022, 7:17 PM · Restricted Project, Restricted Project
raj.khem added a comment to D121379: [compiler-rt][CMake] Enable TF intrinsics on powerpc32 Linux.

Note: powerpc64 defines __powerpc__ as well. You need to check whether powerpc64 needs this as well.

Mar 10 2022, 1:59 PM · Restricted Project, Restricted Project
raj.khem updated the summary of D121379: [compiler-rt][CMake] Enable TF intrinsics on powerpc32 Linux.
Mar 10 2022, 7:52 AM · Restricted Project, Restricted Project
raj.khem requested review of D121379: [compiler-rt][CMake] Enable TF intrinsics on powerpc32 Linux.
Mar 10 2022, 7:47 AM · Restricted Project, Restricted Project
Herald added a project to D119590: exclude openembedded distributions from setting rpath on openmp executables: Restricted Project.

Cross compilers are a hazard here. I'd expect there to be a fairly long list of magic flags you need to pass to clang to get it to find the right libraries. Can you add fno-openmp-implicit-rpath to that list instead?

Mar 10 2022, 7:22 AM · Restricted Project, Restricted Project

Feb 11 2022

raj.khem requested review of D119590: exclude openembedded distributions from setting rpath on openmp executables.
Feb 11 2022, 1:31 PM · Restricted Project, Restricted Project

Feb 7 2022

raj.khem added a comment to D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

I tested this patch and it fixes lldb build. Thanks for taking care of this,.

Feb 7 2022, 5:13 PM · Restricted Project
raj.khem added a comment to D119058: Fix lld standalone build.

Move LLVM_ENABLE_ZLIB

Feb 7 2022, 11:46 AM · Restricted Project, lld

Aug 28 2021

raj.khem accepted D108868: [libomptarget][amdcgn] Only add opt/llvm-link dependency if TARGET is available.

I verified both patches together on latest 13.x branch and it fixes the issue I was seeing. So please apply both the fixes suggested in description to 13.x branch.

Aug 28 2021, 2:04 PM · Restricted Project, Restricted Project

Aug 27 2021

raj.khem added a comment to D107156: [libomptarget][amdcgn] Add build dependency for opt.

The current trunk cmake guards whether to build this with:

if (LLVM_DIR)
  # Builds that use pre-installed LLVM have LLVM_DIR set.                                                                                                                                                          
  find_program(CLANG_TOOL clang PATHS ${LLVM_TOOLS_BINARY_DIR} NO_DEFAULT_PATH)
  find_program(LINK_TOOL llvm-link PATHS ${LLVM_TOOLS_BINARY_DIR}
    NO_DEFAULT_PATH)
  find_program(OPT_TOOL opt PATHS ${LLVM_TOOLS_BINARY_DIR} NO_DEFAULT_PATH)
  libomptarget_say("Building AMDGCN device RTL. Using clang: ${CLANG_TOOL}")
elseif (LLVM_TOOL_CLANG_BUILD AND NOT CMAKE_CROSSCOMPILING AND NOT OPENMP_STANDALONE_BUILD)
  # LLVM in-tree builds may use CMake target names to discover the tools.                                                                                                                                          
  set(CLANG_TOOL $<TARGET_FILE:clang>)
  set(LINK_TOOL $<TARGET_FILE:llvm-link>)
  set(OPT_TOOL $<TARGET_FILE:opt>)
  libomptarget_say("Building AMDGCN device RTL. Using clang from in-tree build")
else()
  libomptarget_say("Not building AMDGCN device RTL. No appropriate clang found")
  return()
endif()

standalone cross-build

Which path are you hitting? Can grep for 'Building AMDGCN device RTL' to see which.

Aug 27 2021, 3:38 PM · Restricted Project
raj.khem added a comment to D107156: [libomptarget][amdcgn] Add build dependency for opt.

This breaks a case where opt is used from installed locations especially in standalone cross-build environment we pass -DOPT_TOOL=${STAGING_BINDIR_NATIVE}/opt and it worked ok but now its expecting opt to be built along with openmp build and fails like below

Aug 27 2021, 1:30 PM · Restricted Project

Jun 23 2021

raj.khem abandoned D104821: Fix openmp build on arm.

https://reviews.llvm.org/D104788 fixes it as well.

Jun 23 2021, 11:08 PM · Restricted Project
raj.khem added a comment to D104821: Fix openmp build on arm.

Does D104788 take care of it?

Jun 23 2021, 11:07 PM · Restricted Project
raj.khem requested review of D104821: Fix openmp build on arm.
Jun 23 2021, 2:45 PM · Restricted Project

Jun 15 2021

raj.khem added a comment to D104183: [builtins] Do not force thumb mode directive in arm/sync-ops.h.

For ELF targets I think this should work fine. However looking at the previous change I think this may break the Darwin build. This change looks like it reverts:

commit 84610ba9b38d917317ac997074acacd99962d767
Author: Steven Wu <stevenwu@apple.com>
Date:   Sat Oct 4 00:18:59 2014 +0000

    Fix the armv7 thumb builtins on darwin

    The arm builtins converted into thumb in r213481 are not working
    on darwin. On apple platforms, .thumb_func directive is required
    to generated correct symbols for thumb functions.

    <rdar://problem/18523605>

    llvm-svn: 219040

I think we'll need a way to get .thumb_func added for Darwin or potentially call DEFINE_COMPILERRT_FUNCTION for Armv6.

Jun 15 2021, 12:31 PM · Restricted Project, Restricted Project

Jun 14 2021

raj.khem added inline comments to D99282: Use mcr for dmb instruction on armv6.
Jun 14 2021, 12:39 AM · Restricted Project, Restricted Project

Jun 12 2021

raj.khem added a comment to D104183: [builtins] Do not force thumb mode directive in arm/sync-ops.h.

Some platforms (e.g. WoA) do require thumb-only compilation. Can we conditionalize this on whether we are building for ARMv6 or not?

Jun 12 2021, 9:29 AM · Restricted Project, Restricted Project
raj.khem requested review of D104183: [builtins] Do not force thumb mode directive in arm/sync-ops.h.
Jun 12 2021, 9:09 AM · Restricted Project, Restricted Project
raj.khem added a reviewer for D99282: Use mcr for dmb instruction on armv6: phosek.

ping,

Jun 12 2021, 8:56 AM · Restricted Project, Restricted Project

Jun 3 2021

raj.khem added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

http://sprunge.us/FJzZXL is a file from harfbuzz and it warns

Jun 3 2021, 9:04 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 21 2021

raj.khem added a comment to D102872: Fix lldb-server build failure on mips.

I assume this is caused by the removal of the specific NativeRegisterContextLinux_mips and you are building lldb on MIPS but you're going to connect to another debug server (gdb, custom stub etc.).

The problem with doing it this way is then if you build on a supported platform e.g. AArch64 NativeRegisterContextLinux_arm64 we then have two copies of CreateHostNativeRegisterContextLinux. Somehow this isn't an error on my system, and it picks up the one you've added. Meaning that you can't debug a simple hello world.

See the comment in lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h. (though again I'd have expect a hard linker error but anyway) Also the reason CI didn't fail is that lldb is disabled for both of the builds.

I can see the utility in allowing people to build at least lldb (client) on any platform. Perhaps we surround this in the #ifdef that the old mips register context used? Or modify our cmake to allow lldb-server to be disabled. (easier said than done)

May 21 2021, 8:54 AM · Restricted Project

May 20 2021

raj.khem updated the diff for D102872: Fix lldb-server build failure on mips.
May 20 2021, 2:22 PM · Restricted Project
raj.khem added a reviewer for D102872: Fix lldb-server build failure on mips: labath.
May 20 2021, 1:43 PM · Restricted Project
raj.khem requested review of D102872: Fix lldb-server build failure on mips.
May 20 2021, 1:41 PM · Restricted Project

May 17 2021

raj.khem accepted D102568: [Driver] Delete -mimplicit-it=.

LGTM

May 17 2021, 7:05 PM · Restricted Project

May 14 2021

raj.khem added a comment to D102535: [RISCV] -mno-relax: emit .option norelax.

I view this as a bug in whatever calls the assembler; it should be passing -mno-relax, just as it needs to pass -fPIC as appropriate.

I'll use the -g analogy. clang -S -g emits debug info and leaves a .debug_line marker so that the assembler knows it needs to synthesize debug info and should not synthesize .debug_info from ELF symbols.
The assembler doesn't need -g to function.

For .option nopic, I agree it is not useful.

The two aren't comparable. Relaxation affects assembling and not code generation. Debug info affects code generation to emit all the information that's otherwise lost (the assembly doesn't have a copy of your source code...). Even PIC is more useful than .option norelax, as it affects what instructions get used to lower global addresses etc.

I think the -Wa,-mno-relax argument is justified if code generation cannot affect relaxation (which I am unsure).

Can GCC base assembly emission decisions on -mno-relax?

May 14 2021, 3:39 PM · Restricted Project

Mar 25 2021

raj.khem added a comment to D96213: Fix compiler-rt build on musl.

@MaskRay I dont find this in main branch yet, anything pending on me ?

Mar 25 2021, 9:53 PM · Restricted Project

Mar 24 2021

raj.khem accepted D99308: [Triple][Driver] Add muslx32 environment and use /lib/ld-musl-x32.so.1 for -dynamic-linker.

once you fix the clang-format issue reported this looks good to me.

Mar 24 2021, 9:51 PM · Restricted Project, Restricted Project
raj.khem added a comment to D65572: Fix static linking failure with --unwindlib=libunwind.

@MaskRay how should be proceeed here

Mar 24 2021, 11:12 AM · Restricted Project
raj.khem abandoned D71369: Detect libdl from cmake variable.

0073c293a401774ac96b4b3d27f05e13f379f98e has fixed it.

Mar 24 2021, 11:09 AM · Restricted Project
raj.khem added a comment to D70636: Add Cmake Check for atomic<double> intrinsic.

Can someone review this please?

Mar 24 2021, 11:07 AM · Restricted Project
raj.khem abandoned D35696: Fix compiler-rt build with aarch64 using -march=armv8-a.

this is because warning were disabled during cmake tests

Mar 24 2021, 11:05 AM
raj.khem added a reviewer for D36809: Fix ldso name for for musl on x86 and x32 architectures: MaskRay.
Mar 24 2021, 11:02 AM
raj.khem abandoned D46914: Run scan-view on systems with python3 as default python provider.

it works with python3 too, perhaps it would be good to ask for python3 instead

Mar 24 2021, 11:01 AM
raj.khem abandoned D18174: Fix libcxx build on musl.

this is no longer needed.

Mar 24 2021, 10:58 AM
raj.khem added inline comments to D96213: Fix compiler-rt build on musl.
Mar 24 2021, 10:54 AM · Restricted Project
raj.khem updated the diff for D96213: Fix compiler-rt build on musl.
Mar 24 2021, 10:53 AM · Restricted Project
raj.khem requested review of D99282: Use mcr for dmb instruction on armv6.
Mar 24 2021, 10:49 AM · Restricted Project, Restricted Project

Feb 25 2021

raj.khem requested review of D97477: sort ClassInfo lists by name.
Feb 25 2021, 8:32 AM · Restricted Project

Feb 8 2021

raj.khem added a comment to D86173: Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF.

I am still seeing build failures in NATIVE/llvm-config when I am cross building clang for say aarch64 on a x86_64 host. Even when I specify -DLLVM_ENABLE_TERMINFO=OFF, it still goes and pokes for these ncurses libs on build host and adds them to linker cmd. Since my target rootfs is set to not have these libs the final link fails to find -lterminfo rightly. Surprisingly, non NATIVE parts work ok and seem to respect LLVM_ENABLE_TERMINFO settings. Any insights ?

Feb 8 2021, 8:58 AM · Restricted Project, Restricted Project

Feb 6 2021

raj.khem requested review of D96213: Fix compiler-rt build on musl.
Feb 6 2021, 1:46 PM · Restricted Project

Feb 4 2021

raj.khem added a comment to D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

Can we get this on clang 12 release branch as well ?

Feb 4 2021, 8:58 AM · Restricted Project

Nov 17 2020

raj.khem added a comment to D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

I don't understand why this has its place in libc++. Shouldn't this be in glibc instead?

Nov 17 2020, 1:55 PM · Restricted Project

Nov 16 2020

raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

it should have been after including syscall.h

Nov 16 2020, 1:36 PM · Restricted Project

Nov 14 2020

raj.khem retitled D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32 from Fix libcxx build on riscv32 to Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.
Nov 14 2020, 2:59 PM · Restricted Project
raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

Add comments in source

Nov 14 2020, 2:56 PM · Restricted Project
raj.khem added a comment to D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

Can you clarify on the errors you are talking about? Are you building LLVM libc++with glibc?
I have been building LLVM libc++ with MUSl and I do not see a build issue.

Nov 14 2020, 2:51 PM · Restricted Project
raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

this revision is not riscv32 specific. Let me know if this is ok

Nov 14 2020, 2:50 PM · Restricted Project

Aug 3 2020

raj.khem added inline comments to D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.
Aug 3 2020, 10:28 AM · Restricted Project

Aug 2 2020

raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

Fix formatting errors

Aug 2 2020, 10:39 AM · Restricted Project
raj.khem requested review of D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.
Aug 2 2020, 10:18 AM · Restricted Project

Jan 7 2020

raj.khem added a comment to D70764: build: reduce CMake handling for zlib.

this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g.

FAILED: bin/llvm-config
...
.... -o bin/llvm-config -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.a /usr/lib/libz.so -lrt -ldl -ltinfo -lm lib/libLLVMDemangle.a
...

aarch64-yoe-linux-musl/aarch64-yoe-linux-musl-ld: /usr/lib/libz.so: error adding symbols: file in wrong format
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

you can see that its adding /usr/lib/libz.so to linker cmdline while cross linking.

Have you set CMAKE_SYSROOT appropriately?

Jan 7 2020, 9:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 3 2020

raj.khem added a comment to D70764: build: reduce CMake handling for zlib.

this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g.

Jan 3 2020, 12:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 28 2019

raj.khem created D71965: include missing <cstdlib> for std::abort.
Dec 28 2019, 10:48 AM · Restricted Project, Restricted Project
raj.khem edited reviewers for D71369: Detect libdl from cmake variable, added: mehdi_amini; removed: espindola.
Dec 28 2019, 10:39 AM · Restricted Project

Dec 11 2019

raj.khem created D71369: Detect libdl from cmake variable.
Dec 11 2019, 11:10 AM · Restricted Project

Dec 10 2019

raj.khem accepted D71302: [llvm-ar] Improve tool selection logic.

LGTM now. I am testing it in yocto multilib SDK builds.

Dec 10 2019, 3:57 PM · Restricted Project

Dec 4 2019

raj.khem updated the diff for D71030: Tighten the check for Tool name ( ar,nm,dlltool, lib).
Dec 4 2019, 12:56 PM · Restricted Project
raj.khem added a reviewer for D71030: Tighten the check for Tool name ( ar,nm,dlltool, lib): MaskRay.
Dec 4 2019, 12:09 PM · Restricted Project
raj.khem created D71030: Tighten the check for Tool name ( ar,nm,dlltool, lib).
Dec 4 2019, 12:06 PM · Restricted Project

Nov 25 2019

raj.khem added a comment to D68543: openmp: Recognise ARMv7ve machine arch.

@AndreyChurbanov Can you push/commit this patch as well. As I dont have commit privs.

Nov 25 2019, 10:16 AM · Restricted Project

Nov 23 2019

raj.khem updated the diff for D70636: Add Cmake Check for atomic<double> intrinsic.
Nov 23 2019, 7:26 PM · Restricted Project
raj.khem closed D57529: Add .dword direcrive support for aarch64 mc.
Nov 23 2019, 7:26 PM · Restricted Project
raj.khem created D70636: Add Cmake Check for atomic<double> intrinsic.
Nov 23 2019, 12:00 PM · Restricted Project

Oct 7 2019

raj.khem added a comment to D57529: Add .dword direcrive support for aarch64 mc.

A patch adding the same functionality was added back in May: D61719, rL360381.

Reviewers tend to assume that patch authors have commit access, if you don't then just say so when the patch is accepted and the reviewer will commit it for you.

Oct 7 2019, 7:28 AM · Restricted Project

Oct 5 2019

raj.khem created D68543: openmp: Recognise ARMv7ve machine arch.
Oct 5 2019, 3:09 PM · Restricted Project
Herald added a project to D57529: Add .dword direcrive support for aarch64 mc: Restricted Project.

@rengolin who can help committing this patch ?

Oct 5 2019, 3:02 PM · Restricted Project

Sep 12 2019

raj.khem added a comment to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.

somehow when doing stage2 build, it is stubborn and does not respect any of PYTHON_EXECUTABLE. PYTHON_LIBRARY or PYTHON_INCLUDE_DIR that were passed with -D on cmake invocation even after they are added to -DDCLANG_BOOTSTRAP_PASSTHROUGH list. llvm finds its own python during stage2. in stage1 it respects the above settings.

Sep 12 2019, 1:52 AM · Restricted Project, Restricted Project

Sep 9 2019

raj.khem added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

That's a separate issue of clang having a slight types-ABI mismatch with some 32-bit archs whose original ABIs used long instead of int for wchar_t. The wrong header order makes it quickly apparent, but these are independent; wrong header order is still wrong and will break (other) things even without this type mismatch. Backport of the fix would be much appreciated.

Sep 9 2019, 7:27 AM · Restricted Project, Restricted Project

Sep 8 2019

raj.khem added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

one issue I now see is that when we have some thing like

Sep 8 2019, 11:20 PM · Restricted Project, Restricted Project
raj.khem added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

Can we bring this to 9.x release branch as well please ?

Sep 8 2019, 1:51 PM · Restricted Project, Restricted Project

Aug 4 2019

raj.khem added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 4:12 PM · Restricted Project
raj.khem added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 2:43 PM · Restricted Project
raj.khem added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 1:07 PM · Restricted Project
raj.khem added a comment to D65572: Fix static linking failure with --unwindlib=libunwind.

-ldl doesn't work on all platforms (e.g. android, FreeBSD, etc). -lpthread is wrong - if you want to add that, I think that we need to improve the -thread-model flag in clang first (it currently just always passes posix, which is ignored; but would identify the threading model). -lpthread is wrong - consider building on Solaris with Solaris threads rather than POSIX threads, or on Windows with the Win32 threading. This really is inline with the work that needs to be finished up with having library link dependencies for static libraries (i.e. #pragma comment(lib, …)).

Aug 4 2019, 12:15 PM · Restricted Project
raj.khem added a comment to D65572: Fix static linking failure with --unwindlib=libunwind.

This is a tricky one which may vary depending on the libraries available on different systems. Which toolchain is this? Can you add more context?

Aug 4 2019, 12:13 PM · Restricted Project

Aug 1 2019

raj.khem created D65572: Fix static linking failure with --unwindlib=libunwind.
Aug 1 2019, 6:22 AM · Restricted Project

Feb 15 2019

raj.khem added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Feb 15 2019, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
raj.khem added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Feb 15 2019, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map: Restricted Project.
Feb 15 2019, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2019

raj.khem created D57529: Add .dword direcrive support for aarch64 mc.
Jan 31 2019, 11:05 AM · Restricted Project

Aug 26 2018

raj.khem created D51282: Disable calls to *_finite and other glibc-only functions on Musl..
Aug 26 2018, 11:42 PM
raj.khem added a comment to D31275: [lldb] Fix lldb build on musl.

Can someone with commit access push this for me please ?

Aug 26 2018, 11:21 PM · Restricted Project

May 20 2018

raj.khem added a comment to D44607: Recompute invalidated iterator in insertTargetAndModeArgs.

Can this be backported to release_60 branch too please ?

May 20 2018, 12:24 PM

May 15 2018

raj.khem created D46914: Run scan-view on systems with python3 as default python provider.
May 15 2018, 4:22 PM

May 12 2018

Herald added a reviewer for D35696: Fix compiler-rt build with aarch64 using -march=armv8-a: javed.absar.
May 12 2018, 11:20 PM

Apr 21 2018

raj.khem retitled D31275: [lldb] Fix lldb build on musl from Fix lldb build on musl to [lldb] Fix lldb build on musl.
Apr 21 2018, 9:50 AM · Restricted Project
raj.khem updated the diff for D31275: [lldb] Fix lldb build on musl.
Apr 21 2018, 9:46 AM · Restricted Project

Aug 16 2017

raj.khem updated the diff for D36809: Fix ldso name for for musl on x86 and x32 architectures.

This version works across all compilers.

Aug 16 2017, 3:40 PM
raj.khem created D36809: Fix ldso name for for musl on x86 and x32 architectures.
Aug 16 2017, 3:24 PM

Aug 2 2017

raj.khem added a comment to D35697: Fix libcxx build with glibc 2.26+.

@EricWF yes please. I don't have push privileges.

Aug 2 2017, 8:55 PM

Jul 31 2017

raj.khem added a comment to D35564: Suppress -pedantic warnings about GNU extension StmtExpr in glibc's assert macro.

There is a proposed fix for glibc's assert here

Jul 31 2017, 11:28 AM