Page MenuHomePhabricator

raj.khem (Khem Raj)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2015, 3:44 PM (281 w, 4 d)

Recent Activity

Tue, Nov 17

raj.khem added a comment to D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

I don't understand why this has its place in libc++. Shouldn't this be in glibc instead?

Tue, Nov 17, 1:55 PM · Restricted Project

Mon, Nov 16

raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

it should have been after including syscall.h

Mon, Nov 16, 1:36 PM · Restricted Project

Sat, Nov 14

raj.khem retitled D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32 from Fix libcxx build on riscv32 to Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.
Sat, Nov 14, 2:59 PM · Restricted Project
raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

Add comments in source

Sat, Nov 14, 2:56 PM · Restricted Project
raj.khem added a comment to D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

Can you clarify on the errors you are talking about? Are you building LLVM libc++with glibc?
I have been building LLVM libc++ with MUSl and I do not see a build issue.

Sat, Nov 14, 2:51 PM · Restricted Project
raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

this revision is not riscv32 specific. Let me know if this is ok

Sat, Nov 14, 2:50 PM · Restricted Project

Aug 3 2020

raj.khem added inline comments to D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.
Aug 3 2020, 10:28 AM · Restricted Project

Aug 2 2020

raj.khem updated the diff for D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.

Fix formatting errors

Aug 2 2020, 10:39 AM · Restricted Project
raj.khem requested review of D85095: Fix libcxx build on 32bit architectures with 64bit time_t defaults e.g. riscv32.
Aug 2 2020, 10:18 AM · Restricted Project

Jan 7 2020

raj.khem added a comment to D70764: build: reduce CMake handling for zlib.

this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g.

FAILED: bin/llvm-config
...
.... -o bin/llvm-config -Wl,-rpath,"\$ORIGIN/../lib" lib/libLLVMSupport.a /usr/lib/libz.so -lrt -ldl -ltinfo -lm lib/libLLVMDemangle.a
...

aarch64-yoe-linux-musl/aarch64-yoe-linux-musl-ld: /usr/lib/libz.so: error adding symbols: file in wrong format
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

you can see that its adding /usr/lib/libz.so to linker cmdline while cross linking.

Have you set CMAKE_SYSROOT appropriately?

Jan 7 2020, 9:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 3 2020

raj.khem added a comment to D70764: build: reduce CMake handling for zlib.

this is now in master, and I am seeing build failures in cross-building clang, e.g. when building clang for arm on a x86_64 host. its resorting to finding, libz from buildhost instead of target sysroot ( using --sysroot) and failing in link step. e.g.

Jan 3 2020, 12:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 28 2019

raj.khem created D71965: include missing <cstdlib> for std::abort.
Dec 28 2019, 10:48 AM · Restricted Project, Restricted Project
raj.khem edited reviewers for D71369: Detect libdl from cmake variable, added: mehdi_amini; removed: espindola.
Dec 28 2019, 10:39 AM · Restricted Project

Dec 11 2019

raj.khem created D71369: Detect libdl from cmake variable.
Dec 11 2019, 11:10 AM · Restricted Project

Dec 10 2019

raj.khem accepted D71302: [llvm-ar] Improve tool selection logic.

LGTM now. I am testing it in yocto multilib SDK builds.

Dec 10 2019, 3:57 PM · Restricted Project

Dec 4 2019

raj.khem updated the diff for D71030: Tighten the check for Tool name ( ar,nm,dlltool, lib).
Dec 4 2019, 12:56 PM · Restricted Project
raj.khem added a reviewer for D71030: Tighten the check for Tool name ( ar,nm,dlltool, lib): MaskRay.
Dec 4 2019, 12:09 PM · Restricted Project
raj.khem created D71030: Tighten the check for Tool name ( ar,nm,dlltool, lib).
Dec 4 2019, 12:06 PM · Restricted Project

Nov 25 2019

raj.khem added a comment to D68543: openmp: Recognise ARMv7ve machine arch.

@AndreyChurbanov Can you push/commit this patch as well. As I dont have commit privs.

Nov 25 2019, 10:16 AM · Restricted Project

Nov 23 2019

raj.khem updated the diff for D70636: Add Cmake Check for atomic<double> intrinsic.
Nov 23 2019, 7:26 PM · Restricted Project
raj.khem closed D57529: Add .dword direcrive support for aarch64 mc.
Nov 23 2019, 7:26 PM · Restricted Project
raj.khem created D70636: Add Cmake Check for atomic<double> intrinsic.
Nov 23 2019, 12:00 PM · Restricted Project

Oct 7 2019

raj.khem added a comment to D57529: Add .dword direcrive support for aarch64 mc.

A patch adding the same functionality was added back in May: D61719, rL360381.

Reviewers tend to assume that patch authors have commit access, if you don't then just say so when the patch is accepted and the reviewer will commit it for you.

Oct 7 2019, 7:28 AM · Restricted Project

Oct 5 2019

raj.khem created D68543: openmp: Recognise ARMv7ve machine arch.
Oct 5 2019, 3:09 PM · Restricted Project
Herald added a project to D57529: Add .dword direcrive support for aarch64 mc: Restricted Project.

@rengolin who can help committing this patch ?

Oct 5 2019, 3:02 PM · Restricted Project

Sep 12 2019

raj.khem added a comment to D64894: [CMake] Don't set Python_ADDITIONAL_VERSIONS.

somehow when doing stage2 build, it is stubborn and does not respect any of PYTHON_EXECUTABLE. PYTHON_LIBRARY or PYTHON_INCLUDE_DIR that were passed with -D on cmake invocation even after they are added to -DDCLANG_BOOTSTRAP_PASSTHROUGH list. llvm finds its own python during stage2. in stage1 it respects the above settings.

Sep 12 2019, 1:52 AM · Restricted Project, Restricted Project

Sep 9 2019

raj.khem added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

That's a separate issue of clang having a slight types-ABI mismatch with some 32-bit archs whose original ABIs used long instead of int for wchar_t. The wrong header order makes it quickly apparent, but these are independent; wrong header order is still wrong and will break (other) things even without this type mismatch. Backport of the fix would be much appreciated.

Sep 9 2019, 7:27 AM · Restricted Project, Restricted Project

Sep 8 2019

raj.khem added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

one issue I now see is that when we have some thing like

Sep 8 2019, 11:20 PM · Restricted Project, Restricted Project
raj.khem added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

Can we bring this to 9.x release branch as well please ?

Sep 8 2019, 1:51 PM · Restricted Project, Restricted Project

Aug 4 2019

raj.khem added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 4:12 PM · Restricted Project
raj.khem added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 2:43 PM · Restricted Project
raj.khem added inline comments to D60097: Fix implementation of ::abs and std::abs LWG 2192..
Aug 4 2019, 1:07 PM · Restricted Project
raj.khem added a comment to D65572: Fix static linking failure with --unwindlib=libunwind.

-ldl doesn't work on all platforms (e.g. android, FreeBSD, etc). -lpthread is wrong - if you want to add that, I think that we need to improve the -thread-model flag in clang first (it currently just always passes posix, which is ignored; but would identify the threading model). -lpthread is wrong - consider building on Solaris with Solaris threads rather than POSIX threads, or on Windows with the Win32 threading. This really is inline with the work that needs to be finished up with having library link dependencies for static libraries (i.e. #pragma comment(lib, …)).

Aug 4 2019, 12:15 PM · Restricted Project
raj.khem added a comment to D65572: Fix static linking failure with --unwindlib=libunwind.

This is a tricky one which may vary depending on the libraries available on different systems. Which toolchain is this? Can you add more context?

Aug 4 2019, 12:13 PM · Restricted Project

Aug 1 2019

raj.khem created D65572: Fix static linking failure with --unwindlib=libunwind.
Aug 1 2019, 6:22 AM · Restricted Project

Feb 15 2019

raj.khem added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Feb 15 2019, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
raj.khem added inline comments to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map.
Feb 15 2019, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map: Restricted Project.
Feb 15 2019, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2019

raj.khem created D57529: Add .dword direcrive support for aarch64 mc.
Jan 31 2019, 11:05 AM · Restricted Project

Aug 26 2018

raj.khem created D51282: Disable calls to *_finite and other glibc-only functions on Musl..
Aug 26 2018, 11:42 PM
raj.khem added a comment to D31275: [lldb] Fix lldb build on musl.

Can someone with commit access push this for me please ?

Aug 26 2018, 11:21 PM · Restricted Project

May 20 2018

raj.khem added a comment to D44607: Recompute invalidated iterator in insertTargetAndModeArgs.

Can this be backported to release_60 branch too please ?

May 20 2018, 12:24 PM

May 15 2018

raj.khem created D46914: Run scan-view on systems with python3 as default python provider.
May 15 2018, 4:22 PM

May 12 2018

Herald added a reviewer for D35696: Fix compiler-rt build with aarch64 using -march=armv8-a: javed.absar.
May 12 2018, 11:20 PM

Apr 21 2018

raj.khem retitled D31275: [lldb] Fix lldb build on musl from Fix lldb build on musl to [lldb] Fix lldb build on musl.
Apr 21 2018, 9:50 AM · Restricted Project
raj.khem updated the diff for D31275: [lldb] Fix lldb build on musl.
Apr 21 2018, 9:46 AM · Restricted Project

Aug 16 2017

raj.khem updated the diff for D36809: Fix ldso name for for musl on x86 and x32 architectures.

This version works across all compilers.

Aug 16 2017, 3:40 PM
raj.khem created D36809: Fix ldso name for for musl on x86 and x32 architectures.
Aug 16 2017, 3:24 PM

Aug 2 2017

raj.khem added a comment to D35697: Fix libcxx build with glibc 2.26+.

@EricWF yes please. I don't have push privileges.

Aug 2 2017, 8:55 PM

Jul 31 2017

raj.khem added a comment to D35564: Suppress -pedantic warnings about GNU extension StmtExpr in glibc's assert macro.

There is a proposed fix for glibc's assert here

Jul 31 2017, 11:28 AM

Jul 30 2017

raj.khem added a comment to D18174: Fix libcxx build on musl.

@EricWF you are right. I have made the changes accordingly. This patch can be ignored.

Jul 30 2017, 9:23 PM
raj.khem updated the diff for D18174: Fix libcxx build on musl.
Jul 30 2017, 7:08 PM
raj.khem added a comment to D35697: Fix libcxx build with glibc 2.26+.

@EricWF it builds fine on archlinux with this change and tests show no regressions. archlinux install right now has glibc 2.25, the xlocale.h change is committed to upcoming glibc 2.26 and newer. So I suppose it was not required all along on glibc based builds. Given this I fairly confident that we should be good with backward compatibility.

Jul 30 2017, 7:03 PM

Jul 25 2017

raj.khem added a comment to D35696: Fix compiler-rt build with aarch64 using -march=armv8-a.

I agree clang should not emit __ARM_FEATURE_CRC32 when -march is armv8-a it can generate it if we have march set to armv8-a+crc, there is another issue with compiler-rt build when clang is configured for multiple backends, COMPILER_RT_HAS_MCRC_FLAG macros gets defined even for x86_64 so we actually need to check for target as well.
something like below

Jul 25 2017, 6:35 AM

Jul 21 2017

raj.khem added a comment to D35696: Fix compiler-rt build with aarch64 using -march=armv8-a.

I agree its a clang driver problem and I did mention that in my earlier comment, this is a workaround that helps until clang is fixed and its limited to this one file.

Jul 21 2017, 5:33 AM

Jul 20 2017

raj.khem added a comment to D35697: Fix libcxx build with glibc 2.26+.

I think this one is better because the other patch you point to is double including locale.h which is redundant so I suggests to apply this patch

Jul 20 2017, 7:30 PM
raj.khem created D35697: Fix libcxx build with glibc 2.26+.
Jul 20 2017, 1:32 PM
raj.khem created D35696: Fix compiler-rt build with aarch64 using -march=armv8-a.
Jul 20 2017, 1:26 PM

Mar 22 2017

raj.khem created D31275: [lldb] Fix lldb build on musl.
Mar 22 2017, 10:44 PM · Restricted Project

Mar 15 2016

raj.khem added a comment to D18174: Fix libcxx build on musl.

libcxx still has problem compiling on musl/aarch64 though. I fixed it with this patch

Mar 15 2016, 12:47 PM
raj.khem added a comment to D18174: Fix libcxx build on musl.

I think my problem was that while compiling libcxxabi, it wants to peek into libcxx headers but then libcxxabi cmake infra doesnt have the musl support like libcxx. So Now I solved it by adding -D_LIBCPP_HAS_MUSL_LIBC to CXXFLAGS.

Mar 15 2016, 12:46 PM
raj.khem added a comment to D18174: Fix libcxx build on musl.

3.8 has it in there. So may be this is just not required. I will add
-DLIBCXX_HAS_MUSL_LIBC=ON to Cmake and see what comes out

Mar 15 2016, 12:15 PM
raj.khem added a comment to D18174: Fix libcxx build on musl.

@bcraig, right, check for GLIBC can be moved after including features.h.
https://chromium.googlesource.com/native_client/pnacl-libcxx/+/master%5E!/
seems to add needed tweaks which can be enabled by passing -Dmusl in CFLAGS
may be it can be backported to 3.8 branch

Mar 15 2016, 12:06 PM

Mar 14 2016

raj.khem retitled D18174: Fix libcxx build on musl from to Fix libcxx build on musl.
Mar 14 2016, 8:25 PM

Feb 11 2016

raj.khem added a comment to D12777: Fix libunwind build on aarch64 when using GNU assembler.

OK can you push this too for me please ?

Feb 11 2016, 1:21 PM

Sep 10 2015

raj.khem added a comment to D12777: Fix libunwind build on aarch64 when using GNU assembler.

Is there a bug against GAS for this? These register aliases should probably be supported there (they're mentioned in the AAPCS).

Sep 10 2015, 3:11 PM
raj.khem added a reviewer for D12777: Fix libunwind build on aarch64 when using GNU assembler: rengolin.

Renato, can you take a look at this for me please ?

Sep 10 2015, 2:40 PM
raj.khem retitled D12777: Fix libunwind build on aarch64 when using GNU assembler from to Fix libunwind build on aarch64 when using GNU assembler.
Sep 10 2015, 2:36 PM
raj.khem abandoned D11113: include <type_traits> for getting is_pod defined.

not needed. Fixed elsewhere

Sep 10 2015, 2:33 PM

Jul 24 2015

raj.khem added a comment to D11112: Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline .

Hi Renato,

Jul 24 2015, 1:50 PM

Jul 15 2015

raj.khem added a comment to D11112: Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline .

Can we pull it into branch_37 as well please ?

Jul 15 2015, 12:41 PM

Jul 14 2015

raj.khem added a comment to D11113: include <type_traits> for getting is_pod defined.

this has been fixed by

Jul 14 2015, 10:01 PM
raj.khem updated the diff for D11112: Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline .

Create a test-case as suggested

Jul 14 2015, 9:57 PM

Jul 10 2015

raj.khem retitled D11113: include <type_traits> for getting is_pod defined from to include <type_traits> for getting is_pod defined.
Jul 10 2015, 4:47 PM
raj.khem updated D11112: Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline .
Jul 10 2015, 3:52 PM
raj.khem updated D11112: Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline .
Jul 10 2015, 3:52 PM
raj.khem retitled D11112: Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline from to Support setting ARM dynamic linker name based on hard-float ABI being specified on compiler commandline .
Jul 10 2015, 3:49 PM